From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 8DEFF11BAD; Thu, 06 Nov 2025 09:55:30 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id 3CFF011BA6; Thu, 06 Nov 2025 09:55:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DMARC_MISSING,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 Received: from fhigh-a2-smtp.messagingengine.com (fhigh-a2-smtp.messagingengine.com [103.168.172.153]) by atuin.qyliss.net (Postfix) with ESMTPS id 0D93711BA3 for ; Thu, 06 Nov 2025 09:55:27 +0000 (UTC) Received: from phl-compute-03.internal (phl-compute-03.internal [10.202.2.43]) by mailfhigh.phl.internal (Postfix) with ESMTP id F0977140010D; Thu, 6 Nov 2025 04:55:25 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-03.internal (MEProxy); Thu, 06 Nov 2025 04:55:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1762422925; x=1762509325; bh=Gl5rup0v0M 0Taut2511mySHLJkA/8J6BGqKBiSwnHKE=; b=f8hiC9PYkQ8g4sEbcB3BmrH14O 5J1v5PtDGcCL8I9C6sB11FMLZW4G3c2KzBapIuEvpNd8zRRX1e/YP4BBr6nq3dF1 W9QAUpS+rBot5SigqVw75m8vLHM5te6n4KiWx8XriWB69pMMM+MZbSKAxlNqg0lg krsAxze9jqDYTv8j6x6kPZR5BNA2jKXnAJC6LTKRC/Y4fGpf4roNrhNq5MEg1PJS 6sHEVVExRQ8OZnme5oLSDJUhgWx0qkSMX6XPLy5r8SwZFKMCWRS5CXB3QT0Ivpu2 1pryR2lt5rezcwOqwOlJSvodxPuBUFNkZAjk+jv8LhbbzJHoHVgmy2dkamxg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1762422925; x=1762509325; bh=Gl5rup0v0M0Taut2511mySHLJkA/8J6BGqK BiSwnHKE=; b=A54bAtMR8vOV/yffech6Y1hZHEGPxg/GT3YVbfVnlTPWNdfjRIe Qs3yhdCLB23M4E5ue/NnnMyy+sbepDg1ves+WxGPUNHH0iKSoFrb0kbnHIluvXha kwt1ytqwDhxha+Z0klpTFVX1h6PMHT2btTFdX2r+K2yHdFOXM73xTEPIDYUM+G5c LSaODkItdX0GbQHRsEBCHC6iq7RnJ0i+l9pwq2ZH+H2qtEvJE4RMxMz8kH/9kFKC CUsyneNv9fXoPTGhkmX8R5oYs7VjPlz0CoLiPtno6yWUdwugMpGTZnx184nsy2MY Wj+mX/+UqGV/ZjZe61ufOVrghtyGWn2/Quw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggddukeeigeekucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhephffvvefujghffffkgggtsehgtderredttddtnecuhfhrohhmpeetlhihshhsrgcu tfhoshhsuceohhhisegrlhihshhsrgdrihhsqeenucggtffrrghtthgvrhhnpeeiudffue eilefgtefgtddttdekkeehkefgheekudefveetgeefiefftedvteeuveenucevlhhushht vghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehhihesrghlhihsshgrrd hishdpnhgspghrtghpthhtohepvddpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohep uggvmhhiohgsvghnohhurhesghhmrghilhdrtghomhdprhgtphhtthhopeguvghvvghlse hsphgvtghtrhhumhdqohhsrdhorhhg X-ME-Proxy: Feedback-ID: i12284293:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 6 Nov 2025 04:55:25 -0500 (EST) Received: by mbp.qyliss.net (Postfix, from userid 1000) id A2769673AE6F; Thu, 06 Nov 2025 10:55:24 +0100 (CET) From: Alyssa Ross To: Demi Marie Obenour Subject: Re: [PATCH v6 2/2] host/rootfs: Switch to systemd-udevd In-Reply-To: <20251103-udev-v6-2-704649b85d6d@gmail.com> References: <20251103-udev-v6-0-704649b85d6d@gmail.com> <20251103-udev-v6-2-704649b85d6d@gmail.com> Date: Thu, 06 Nov 2025 10:55:23 +0100 Message-ID: <87seerxz78.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Message-ID-Hash: ADEX6OYYJS2ZVFMP24XRBCYDH7VSIKQE X-Message-ID-Hash: ADEX6OYYJS2ZVFMP24XRBCYDH7VSIKQE X-MailFrom: hi@alyssa.is X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Spectrum OS Development X-Mailman-Version: 3.3.9 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --=-=-= Content-Type: text/plain Demi Marie Obenour writes: > diff --git a/host/rootfs/image/etc/s6-rc/systemd-udevd/run b/host/rootfs/image/etc/s6-rc/systemd-udevd/run > new file mode 100644 > index 0000000000000000000000000000000000000000..a3b74cffe5af191d099ce9314b29669652762092 > --- /dev/null > +++ b/host/rootfs/image/etc/s6-rc/systemd-udevd/run > @@ -0,0 +1,14 @@ > +#!/bin/execlineb -P > +# SPDX-License-Identifier: EUPL-1.2+ > +# SPDX-FileCopyrightText: 2025 Demi Marie Obenour > +s6-setlock /run/sd-notify-wrapper/systemd-udevd.lock > +# Save stdin to restore it later. Stray comment. > +s6-ipcserver-socketbinder -b0 -m -a 0600 /run/sd-notify-wrapper/systemd-udevd.sock > +background { > + fdmove 1 3 > + sd-notify-adapter > +} > +fdclose 3 > +redirfd -r 0 /dev/null > +export NOTIFY_SOCKET /run/sd-notify-wrapper/systemd-udevd.sock > +systemd-udevd > diff --git a/host/rootfs/image/etc/udev/rules.d/99-spectrum.rules b/host/rootfs/image/etc/udev/rules.d/99-spectrum.rules > new file mode 100644 > index 0000000000000000000000000000000000000000..6facab361e82fa48e8e018b69b611693b0a277d0 > --- /dev/null > +++ b/host/rootfs/image/etc/udev/rules.d/99-spectrum.rules > @@ -0,0 +1,9 @@ > +# SPDX-License-Identifier: EUPL-1.2+ > +# SPDX-FileCopyrightText: 2025 Demi Marie Obenour > + > +ACTION=="remove", GOTO="spectrum-end" > +ENV{PCI_CLASS}!="2????", GOTO="spectrum-end" > + > +# systemd-udevd unsets PATH, so fix that. > +RUN+="/usr/bin/env PATH=/usr/bin /usr/libexec/net-add" > +LABEL="spectrum-end" Would it not be easier to follow without the gotos, where we just have a single rule that runs net-add when ACTION isn't remove and PCI_CLASS is as expected? This structure wouldn't hold up when we handle letting the VMM know if a device has been removed, because it would have to go after "spectrum-end", and same if we wanted to handle other types of devices. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRV/neXydHjZma5XLJbRZGEIw/wogUCaQxwiwAKCRBbRZGEIw/w ompNAP49ImWmN7rYduYH7y45mICx0olThwKyLAoeRLocTNPBCwD/dl5z3qcbhQgY 7d48W2wPTCCh2Y4wDbcFt6nnOLHxzgY= =PdW5 -----END PGP SIGNATURE----- --=-=-=--