From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id E2EC74D73; Sun, 21 Sep 2025 11:40:48 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id 407BF4CE1; Sun, 21 Sep 2025 11:40:47 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DMARC_MISSING,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 Received: from fhigh-a8-smtp.messagingengine.com (fhigh-a8-smtp.messagingengine.com [103.168.172.159]) by atuin.qyliss.net (Postfix) with ESMTPS id 9F1334CDE for ; Sun, 21 Sep 2025 11:40:46 +0000 (UTC) Received: from phl-compute-11.internal (phl-compute-11.internal [10.202.2.51]) by mailfhigh.phl.internal (Postfix) with ESMTP id AE96114000E6; Sun, 21 Sep 2025 07:40:45 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-11.internal (MEProxy); Sun, 21 Sep 2025 07:40:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1758454845; x=1758541245; bh=QESeQRcOv+ UIVk8keEPF/VwauVkLHfRZpkODasikETA=; b=k+QECI3xviDbec06+jQvJqQLGN vnEhj2t++gIw2lO2FxcvgBz2F1yrWngQV3ECy5MOoCzVaSPzCsEU7jt/B3dY1ckw KYX9uy0kNOn+6H66LCajqwuWG8w3+mRbUNZBmis6f18SF9Yn6dX6AmNwXcbbTptr dgqGSxWlRvupglZ4xCIQWGSj8tZIZc1YR15WEb3rse2E1NjN74fKjg2GyxQIxwGl abkqPYmaiIZ1BZaGHYdf+aNY8fFpaO6y891eorZKf2Idgf+JPmqDFNjiu6suQzkJ evM2AnVfyuwyynNnqgW+dDZVx67VE/nqiRk5QsKV9RCI9e8vP3PEECbYRZYw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1758454845; x=1758541245; bh=QESeQRcOv+UIVk8keEPF/VwauVkLHfRZpkO DasikETA=; b=T+vLbvdO1VDIbqSSzte8kWb3F43S1IQTfblf50wvt+g86N5t/UX ZZD6PUd3xhqHJhzp1lORaurWOgF5hXt3fcWXbrnyMmL54zUHmQqITy3BJueuBRaC hFeq02p3dg9frHqxF02kiWLhvmC/0vcP/lCFRP8uIkopYQkCWKi8gfCxQ3/7Al9S 8a+eMjt6CFdt07Ij6i46460AEmDJOBXVMN56svkBSA/dx5o9LimsD5rkrzsiMKuW 5U8tByeewFfxK8DHbYHratf0QQMGBpSIeksTHS/gha+HKQSNHmi827nBhhDTrbpS lvKWXKlC6Q/WFO2GQbPHaqcskBiq9He3rJQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggdehgeekjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpefhvfevufgjfhffkfggtgesghdtreertddttdenucfhrhhomheptehlhihsshgrucft ohhsshcuoehhihesrghlhihsshgrrdhisheqnecuggftrfgrthhtvghrnhepieduffeuie elgfetgfdttddtkeekheekgfehkedufeevteegfeeiffetvdetueevnecuvehluhhsthgv rhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhephhhisegrlhihshhsrgdrih hspdhnsggprhgtphhtthhopedvpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopegu vghmihhosggvnhhouhhrsehgmhgrihhlrdgtohhmpdhrtghpthhtohepuggvvhgvlhessh hpvggtthhruhhmqdhoshdrohhrgh X-ME-Proxy: Feedback-ID: i12284293:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 21 Sep 2025 07:40:45 -0400 (EDT) Received: by mbp.qyliss.net (Postfix, from userid 1000) id 60A3320049C4; Sun, 21 Sep 2025 13:40:29 +0200 (CEST) From: Alyssa Ross To: Demi Marie Obenour Subject: Re: [PATCH 2/3] scripts/make-erofs.sh: Avoid calls to dirname In-Reply-To: <20250919-less-dirname-v1-2-5df7ca617b9b@gmail.com> References: <20250919-less-dirname-v1-0-5df7ca617b9b@gmail.com> <20250919-less-dirname-v1-2-5df7ca617b9b@gmail.com> Date: Sun, 21 Sep 2025 13:40:28 +0200 Message-ID: <87seggdoer.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Message-ID-Hash: GYZPQ4E4Q2O76B6AKOONZS7ETDDO36BJ X-Message-ID-Hash: GYZPQ4E4Q2O76B6AKOONZS7ETDDO36BJ X-MailFrom: hi@alyssa.is X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Spectrum OS Development X-Mailman-Version: 3.3.9 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Demi Marie Obenour writes: > Use builtin string manipulation instead. > > Signed-off-by: Demi Marie Obenour With a copyright header added: Reviewed-by: Alyssa Ross > --- > scripts/make-erofs.sh | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/scripts/make-erofs.sh b/scripts/make-erofs.sh > index 82d37573ad0454e79becfddd05f93585df7b671c..ac62a65f53e0b6417b164f475= a537960fc5203bc 100755 > --- a/scripts/make-erofs.sh > +++ b/scripts/make-erofs.sh > @@ -40,7 +40,13 @@ while read -r arg1; do > continue > fi >=20=20 > - parent=3D$(dirname "$arg2") > + # The below simple version of dirname(1) can only handle > + # a subset of all paths, but this subset includes all of > + # the ones passed in practice other than /. > + case $arg2 in > + (*/*) parent=3D${arg2%/*};; > + (*) parent=3D.;; > + esac > mkdir -p -- "$root/$parent" > cp -RT -- "$arg1" "$root/$arg2" > done > > --=20 > 2.51.0 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRV/neXydHjZma5XLJbRZGEIw/wogUCaM/kLAAKCRBbRZGEIw/w oijAAQDpYYP9s0Via/733IzlLDFntfqB3dxNJ3sqRxmR7gqoXwD+K+ACmOjbXXX7 BQ07bBMoOwG8n6chvx+2J0Xw03Ckbg4= =xn6Q -----END PGP SIGNATURE----- --=-=-=--