From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 19F635E998; Thu, 8 Sep 2022 11:30:49 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 496) id F34215E987; Thu, 8 Sep 2022 11:30:45 +0000 (UTC) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by atuin.qyliss.net (Postfix) with ESMTPS id 0B2195E986 for ; Thu, 8 Sep 2022 11:30:44 +0000 (UTC) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 321305C01C0; Thu, 8 Sep 2022 07:30:43 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Thu, 08 Sep 2022 07:30:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1662636643; x=1662723043; bh=cjpc2RUvOX FhZp4S0fnwBTc/HBEJ8j/z1M6a0w3wB30=; b=YuvBdlfENXIEixsrWN6Q0qOljH dsnChs77syHpyNgNvKpCsg78//uV/8RrXrtN0Gba7KiAUgU0XqVLOUla6r2sk5Rr w5gZ+jOrtKqNtYXLYo8sia8CAYgCkxl9MsfqFKspsQJgjy3Y0aBtNWuCKrj58uJY Sxp+JPkSl/ZDraJksXmrtEiLIxJz5G0CP8j8p5Jws1861utOOQxzaSz6Ra5HAOPB YOCgRjAWPl876T0FVQVuTcbGK8Ll+GIPNujpIXa9aroxmwsJBxCnEMNc237krHGD otjGxWY1nczv1lhtAMo6S3z7PWMF3j+ptN+mXFVjaLEsoxTzpqwQHT8Vm8DQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1662636643; x=1662723043; bh=cjpc2RUvOXFhZp4S0fnwBTc/HBEJ 8j/z1M6a0w3wB30=; b=CKmMdlIA4jQmK1TEDav3FjXn5jGFElf8qp7AbGtpsIHM fzfpKPYYwEd5dYjNadUqVTsB33drmnLfJ/II2ZACyJNXQAG5kANIrAhHsH7I4vdv 5n/8j9c16aQ3E5gJ41vHmv8GWEVc3SshA5/feHZgnwzqMWcy4GQvXWeCpDycxrkH 4F0T1bykTWOV6yZ8L9iNe/iqv8U6SFHp3oGySrucL0cBKIcW3uS5khFHnZ8KjZYr CF1L8/dmzLpQDfR4GBSjzZWWrbupjMXgn075FZc/IzNUsfPw7sgjiZei0TSF+y69 wcURLGmpvHZKcH0EiW8hb+fPFfzR2w3b/QjI8ZXCjg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfedtvddggedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefujghffffkgggtsehgtderredttdejnecuhfhrohhmpeetlhihshhs rgcutfhoshhsuceohhhisegrlhihshhsrgdrihhsqeenucggtffrrghtthgvrhhnpeethe evudfgjefghefhieejudelkeeljeegvdekueeuhffhgedvveefteevgeetieenucevlhhu shhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehhihesrghlhihssh grrdhish X-ME-Proxy: Feedback-ID: i12284293:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 8 Sep 2022 07:30:42 -0400 (EDT) Received: by x220.qyliss.net (Postfix, from userid 1000) id 7B6A92AC; Thu, 8 Sep 2022 11:30:41 +0000 (UTC) From: Alyssa Ross To: =?utf-8?Q?Jos=C3=A9?= Pekkarinen Subject: Re: [PATCH 1/2] host/rootfs: use initramfs in "make run" In-Reply-To: References: <20220901104629.863380-1-hi@alyssa.is> <87y1uu9lyz.fsf@alyssa.is> Date: Thu, 08 Sep 2022 11:30:35 +0000 Message-ID: <87sfl29k84.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Message-ID-Hash: DH4JTQWY6RTOMPYJQAKJMI3AFUNEP34S X-Message-ID-Hash: DH4JTQWY6RTOMPYJQAKJMI3AFUNEP34S X-MailFrom: hi@alyssa.is X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: devel@spectrum-os.org X-Mailman-Version: 3.3.5 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Jos=C3=A9 Pekkarinen writes: > On Thu, Sep 8, 2022 at 1:52 PM Alyssa Ross wrote: > >> Jos=C3=A9 Pekkarinen writes: >> >> > On Thu, Sep 1, 2022 at 1:47 PM Alyssa Ross wrote: >> > >> >> This will allow us to stop compiling e.g. the virtio-blk module into >> >> the kernel, because it will be loaded by the initramfs. >> >> >> >> This introduces some duplication between the rootfs and initramfs's >> >> Makefiles. I don't think it's worth the effort at the moment to try >> >> to reduce that, because it would come at the expense of additional >> >> complexity in the Makefiles. We can revisit this later if we want to. >> >> >> >> Signed-off-by: Alyssa Ross >> > >> > Hi, >> > >> > This patchset introduces errors in the default qemu >> > >> > configuration of spectrum, where it is possible to see in the >> > console log attempts to load broken aliases like: >> > >> > modprobe: FATAL: Module acpi:PNP0C0F: not found in directory >> > /lib/modules/5.18.0 >> >> This is pretty much expected. The only job of the initramfs is to get >> the root filesystem mounted, so most kernel modules are not included in >> it to keep the size down. It just contains modules related to block >> devices, dm-verity, ext4, etc. If a we try to load a driver in >> initramfs, and it isn't available, that's fine, because when we get to >> the root filesystem, we run mdevd-coldplug again, and the module will be >> loaded at that point. >> >> The reason this didn't happen before when testing Spectrum in a VM is >> that since all the drivers we needed were built in to the kernel, the >> the block device nodes would be available before userspace even started, >> meaning that the initramfs simply wouldn't have any time to try and fail >> loading any other drivers before the rootfs was ready. On hardware, >> where the appropriate drivers wouldn't have been built in, I assume >> these messages would already have been normal without this change, >> although I didn't test. >> >> > As well as valid modules load failures like: >> > >> > modprobe: ERROR: could not insert 'vfio_pci': Invalid argument >> >> I wasn't able to reproduce this, with this series applied on top of >> commit c0b9dff8653b59f5d2a24bb539cba6c91d3f7506, >> Nixpkgs commit 4d05083dd894b73941e2e7d3b4f428b0ce1c7007, running >> Spectrum with `make run' in the host/rootfs directory. I started netvm >> and verified that the QEMU ethernet device was successfully passed >> through as well, so vfio-pci was definitely working. >> >> Does that differ to the versions you were using to test? If so, could >> you try with those versions and let me know if that works for you? >> > > Yes, I was living in b01594b2c089ce2434dacddccf9a285af7334d24, > > right version on nixpkgs. Rebasing on upstream main solved the issue. > > Thanks! Awesome! If it's now working for you, want to send me some Tested-by: lines for the patches you've tested, so they can be recorded in the commit log? (Just reply to the patches you've tested with "Tested-by: Jos=C3=A9 Pekkarinen " on a line on its own, and then it'll be automatically picked up when I apply the patches.) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEH9wgcxqlHM/ARR3h+dvtSFmyccAFAmMZ0l8ACgkQ+dvtSFmy ccCdJw/+LkzheR86+hh44/6uwVLWvSmVNLW94fSMsEs0N08Yb2huwlsYgIbnunMN X1RtaNxlBztSvrsb6Zw7a5xBApDLMW6Pr0ymCSoGgslQG6c97QcVeO46xY3kjSZr DSz2l/cVTIkS+xnZ95C6wOJs+iRhT/WA9+GG2qlyzrP8+D5dEobLrVhMvQebvJJP iBPcqFKZu4JLdQIPQRGXuIwupTmkxEUuEt/8xQso7kdXHtonJJkme6m4W8DMTLuF uKVsHuNBaM6aMLePlQUacCA+PJsrddtwhNZxAz8WtAsZZrYytkcM8KBkwJaC/GHV KDV+4Sh1BTjQ7d0mnuQE2Fccz4Z+0cI7dJERWPiUHAzl5SQDur3vwF4fP1QYybqk CB4qPVSSBboHy2DUQ6rpqtc8+eBzYqgCfPzJj5awoBygk7a8is1U4jPo03o5kxfo GH3L7pygUqYS0TIhnhR6Dar6EIcfD76+AlXLiJD/w4glATVTnWlgd8wEaPYul/Yu AYg5I/qanoWYBOAroZl7C0Nq6pjFf2OyhmnvvDHRJRxnrrlo7BH6xOj9w4ssHtKk VLdxDPk/agbzEHG64MHbxE4hepYuvK67NFlo+62Bbgn55bfHus7a5UqMi61EXbZ7 ZGbzKEDwGZxHs+DI/TrCZFyMcCBF6UVWIbcHFenFkAlJhZQU1/M= =NMk3 -----END PGP SIGNATURE----- --=-=-=--