From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 4ECA220146; Fri, 19 Sep 2025 11:55:19 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id 97555200A2; Fri, 19 Sep 2025 11:55:16 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-0.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DMARC_MISSING,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 Received: from fhigh-a3-smtp.messagingengine.com (fhigh-a3-smtp.messagingengine.com [103.168.172.154]) by atuin.qyliss.net (Postfix) with ESMTPS id CE6E2200A0 for ; Fri, 19 Sep 2025 11:55:14 +0000 (UTC) Received: from phl-compute-06.internal (phl-compute-06.internal [10.202.2.46]) by mailfhigh.phl.internal (Postfix) with ESMTP id 65BD614001D4; Fri, 19 Sep 2025 07:55:13 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-06.internal (MEProxy); Fri, 19 Sep 2025 07:55:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1758282913; x=1758369313; bh=BlwNAVxbyF IfEDO67/zS3BEdpSBsBgu2P1WhsJ3Mhy4=; b=AlZhkbDZzebImEqUmP9BoYN1BR G/t5qeQypzmPTcPBpv7GJ2tGlrRqFcTJed14ptmzVd7k/8SSUVNsFw3ieZAXnEUq Tf6KQa2TzFI5FPT6NESVyBOO7sUuhLIJ6pcjX8HJnmhKn/mttlN9dn4sa0bn2cvG CUdvQtmw5faP9YMiJW3F9j+cAbx8xJQhej1P+gYfNTZt28PuZYe2K8OzbeujRLPF 7wMXPIjIFjNmO0QMMEn+3GqeWEMljdag01sHqzdn7uoqqRzUsyLBvdmcL8R2TPGY 00VDiUP0l87ptPXoATcNtfsn7fPiZuKlCkYss9/WGI62jwvLn0+w8uau/Y5Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1758282913; x=1758369313; bh=BlwNAVxbyFIfEDO67/zS3BEdpSBsBgu2P1W hsJ3Mhy4=; b=oX8qic3EekDKAcUP6uA1Fcbg/RLFQTXPU6qfihyaCdOdz6ikQST 6caaHaP2PoN/8N/nN68+eNHexGfB5VTD3zjbF06ffalmsmXABTD3iujpLKMkKHjc g0IJnzdCNlSJ77kI4lAwoHB73QEhP0VP1ocmoCuL749HMyzG88x7JSina4XWjAG7 FjSRcFhzD02n1J7HFp0z/il9Y5BHdcgC7N6kRL9RfolUATeXyM4FYk5tF1R5IP0j lrSP44Dr5bRIdEWVygCUTP3krjBU9o6n2DOM/oc8GmLRbT0Tb0Bz/eCwGCYqAGKV hEiS+DStCDhjWd42J4pJMuWha9zPALHkqgQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggdegledugecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpefhvfevufgjfhffkfggtgesghdtreertddttdenucfhrhhomheptehlhihsshgrucft ohhsshcuoehhihesrghlhihsshgrrdhisheqnecuggftrfgrthhtvghrnhepieduffeuie elgfetgfdttddtkeekheekgfehkedufeevteegfeeiffetvdetueevnecuvehluhhsthgv rhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhephhhisegrlhihshhsrgdrih hspdhnsggprhgtphhtthhopedvpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopegu vghmihhosggvnhhouhhrsehgmhgrihhlrdgtohhmpdhrtghpthhtohepuggvvhgvlhessh hpvggtthhruhhmqdhoshdrohhrgh X-ME-Proxy: Feedback-ID: i12284293:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 19 Sep 2025 07:55:12 -0400 (EDT) Received: by mbp.qyliss.net (Postfix, from userid 1000) id 6C04A1FA0EF7; Fri, 19 Sep 2025 13:55:01 +0200 (CEST) From: Alyssa Ross To: Demi Marie Obenour Subject: Re: [PATCH] tools/start-vmm: Add additional warning options In-Reply-To: <20250918-more-c-warnings-1-v1-1-5fe4eaff8a30@gmail.com> References: <20250918-more-c-warnings-1-v1-1-5fe4eaff8a30@gmail.com> Date: Fri, 19 Sep 2025 13:55:00 +0200 Message-ID: <87tt0yslm3.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Message-ID-Hash: J3AHQDN34HZTHXTV66TJHMG3UPQNPQBU X-Message-ID-Hash: J3AHQDN34HZTHXTV66TJHMG3UPQNPQBU X-MailFrom: hi@alyssa.is X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Spectrum OS Development X-Mailman-Version: 3.3.9 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Demi Marie Obenour writes: > This detected a missing prototype. > > No functional change. > > Signed-off-by: Demi Marie Obenour > --- > tools/meson.build | 2 ++ > tools/start-vmm/ch.h | 1 + > 2 files changed, 3 insertions(+) > > diff --git a/tools/meson.build b/tools/meson.build > index 9cebd03e323531fca7600cacf120161a98de16c5..8262f3e01d7bd56561306d7dd= 4650a22ca40ebe7 100644 > --- a/tools/meson.build > +++ b/tools/meson.build > @@ -9,6 +9,8 @@ project('spectrum-tools', 'c', > }) >=20=20 > add_project_arguments('-Wno-error=3Dattributes', language : 'c') > +add_project_arguments('-Werror=3Dmissing-prototypes', language : 'c') > +add_project_arguments('-Werror=3Dmissing-declarations', language : 'c') >=20=20 > if get_option('host') > add_languages('rust') > diff --git a/tools/start-vmm/ch.h b/tools/start-vmm/ch.h > index 7230913ef0abf41a4f712ac4a543c7f7fdecec0f..5431365e6e2894cdebae22a9a= 44e2ccf1222e0d2 100644 > --- a/tools/start-vmm/ch.h > +++ b/tools/start-vmm/ch.h > @@ -8,3 +8,4 @@ struct net_config { > char id[18]; > uint8_t mac[6]; > }; > +struct net_config net_setup(const char name[static 1], int name_len); Why do we need to declare this in a C header? It's only used from Rust. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRV/neXydHjZma5XLJbRZGEIw/wogUCaM1ElAAKCRBbRZGEIw/w ou0KAP9zKOXy+d+vl1aKCrlvl8M4VQx7sMoXCFEFgUGd9ixYhAD+P0CgpGWdwmH3 GRZ36eODKldqU7x0m1Q9gcP93AcKWgI= =NGN5 -----END PGP SIGNATURE----- --=-=-=--