From: Alyssa Ross <hi@alyssa.is>
To: Cole Helbling <cole.e.helbling@outlook.com>
Cc: devel@spectrum-os.org
Subject: Re: [PATCH crosvm 2/2] sys_util: expand on UnixSeqpacket documentation
Date: Mon, 06 Jul 2020 23:07:11 +0000 [thread overview]
Message-ID: <87tuykfdk0.fsf@alyssa.is> (raw)
In-Reply-To: <SJ0PR03MB5581336249C463C95D83E023B3690@SJ0PR03MB5581.namprd03.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 562 bytes --]
Cole Helbling <cole.e.helbling@outlook.com> writes:
>> - /// Receive data from the socket fd to a given buffer.
>> + /// Receive a message from the socket fd to a given buffer. The message will then
>> + /// be removed from the socket, whether `buf` was large enough to hold all of it or
>
> "whether or not `buf` was large enough..." sounds better, IMO.
I agree.
>> + ///
>> /// # Errors
>> /// Returns error when `libc::recv` failed.
>
> Returns *an* error.
Ah, yes, I can change this while I'm here. Good catch. :)
v2 on its way!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2020-07-06 23:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-06 15:59 [PATCH crosvm 1/2] sys_util: make UnixSeqpacket::recv use libc::recv Alyssa Ross
2020-07-06 15:59 ` [PATCH crosvm 2/2] sys_util: expand on UnixSeqpacket documentation Alyssa Ross
2020-07-06 16:24 ` Cole Helbling
2020-07-06 23:07 ` Alyssa Ross [this message]
2020-07-06 23:14 ` [PATCH crosvm 2/2 v2] " Alyssa Ross
2020-07-06 23:22 ` Cole Helbling
2020-07-08 17:06 ` [PATCH crosvm 1/2] sys_util: make UnixSeqpacket::recv use libc::recv Cole Helbling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tuykfdk0.fsf@alyssa.is \
--to=hi@alyssa.is \
--cc=cole.e.helbling@outlook.com \
--cc=devel@spectrum-os.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://spectrum-os.org/git/crosvm
https://spectrum-os.org/git/doc
https://spectrum-os.org/git/mktuntap
https://spectrum-os.org/git/nixpkgs
https://spectrum-os.org/git/spectrum
https://spectrum-os.org/git/ucspi-vsock
https://spectrum-os.org/git/www
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).