Re: [PATCH 3/3] host/rootfs: Avoid redundant mounts of /proc and /sys

[Alyssa Ross <hi@alyssa.is>]

[-- Attachment #1: Type: text/plain, Size: 1384 bytes --]

Demi Marie Obenour <demiobenour@gmail.com> writes:

> The initramfs already mounted both of them.
>
> Signed-off-by: Demi Marie Obenour <demiobenour@gmail.com>
> ---
> It's true that this does increase the reliance on an initramfs, but it
> is also trivial to revert if Spectrum OS ever stops using one.  Linux
> supports creating dm-verity devices via dm-mod.create= and (if needed)
> dm-mod.waitfor=, so eliminating an initramfs might be possible but is a
> separate project.

I'd still prefer we don't rely on initramfs behaviour any more than we
need to — it just makes things more brittle and difficult to understand.

IIRC I tried using those kernel parameters before, but they weren't
workable for what we needed.  I don't remember the details.

> ---
>  host/rootfs/etc/fstab | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/host/rootfs/etc/fstab b/host/rootfs/etc/fstab
> index 6a82ecc85090a37b13603b29f74ca6e554a28c33..4d303d277409279976bc102969d902466bc39c47 100644
> --- a/host/rootfs/etc/fstab
> +++ b/host/rootfs/etc/fstab
> @@ -1,6 +1,4 @@
>  # SPDX-License-Identifier: CC0-1.0
>  # SPDX-FileCopyrightText: 2020-2021 Alyssa Ross <hi@alyssa.is>
> -proc	/proc		proc	defaults		0	0
>  devpts	/dev/pts	devpts	defaults,gid=4,mode=620	0	0
>  tmpfs	/dev/shm	tmpfs	defaults		0	0
> -sysfs	/sys		sysfs	defaults		0	0
>
> -- 
> 2.51.0

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]