From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 4F0E81A7AF; Thu, 30 Jan 2025 11:30:17 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id 9A2B01A78A; Thu, 30 Jan 2025 11:30:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DMARC_MISSING,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS, URIBL_SBL_A autolearn=unavailable autolearn_force=no version=4.0.1 Received: from fout-a1-smtp.messagingengine.com (fout-a1-smtp.messagingengine.com [103.168.172.144]) by atuin.qyliss.net (Postfix) with ESMTPS id E72991A785 for ; Thu, 30 Jan 2025 11:29:56 +0000 (UTC) Received: from phl-compute-10.internal (phl-compute-10.phl.internal [10.202.2.50]) by mailfout.phl.internal (Postfix) with ESMTP id 3D1411380137; Thu, 30 Jan 2025 06:29:54 -0500 (EST) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-10.internal (MEProxy); Thu, 30 Jan 2025 06:29:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1738236594; x=1738322994; bh=OVDJI0xmmK btmijt4hqtFISi7b5sDQYkDjOzPIhkiRE=; b=L4c3cUHb3AfwDgSqePxh1+poQ0 ojyjHftqRVX1U1VOPcsVsxBr4imPeuEqz5rpvXXHhMn/iwIiWe0JO2bSjKTivC5A eTCUUML12AId+pGKTtW4ycy2qzaRxX2cYROD7iIJUAiExshNLqsu6gBXZS28F10o ZhUbKabXuQxMepCmUNQmjUSA7fD3/TIy2E36qLpjVx6EQtnx84n1O2pBLWDJc46X x322UH2r9XKDNZYJCIpuHKi1Y6yNWszYv+DyIsmbZj3jDoBONMHR1ZwzGk///c2a C+6/pKltZdYoqjDbwjaS9wGEKLexW727RLTyS1cbRHkc18KXzSTRnEQvSG/A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1738236594; x=1738322994; bh=OVDJI0xmmKbtmijt4hqtFISi7b5sDQYkDjO zPIhkiRE=; b=EGry31V24F8KeKNTtE7VrwCryIFOpYP+HP0XlU0Fea86g9cYy6d GzB6xS3XzCLktO7wYTK80OHEOunOLXteGHWEMXesAkUgGu75jeOB8CwXx/ity1NX 9qmrYE01bETaF9D+At4qhXY3jcTYPFpd38k/967JLDU3i5Kodjp4NE5vC23VT4tP tEDJm5+t4dyoeHy5vS1o3ou056LM41JrVwiWE0sX52d4xi8Fouhrq0J7YMkGUmMD 9nqFKFF4SiDjJ3C6HxyxTCeQjhenUB95w5P1mAQUKhW+4dFCM6bLPpAe9qcfhQM3 d/95cTjINbI+AIOP4uhvXOdrc79N2hQD0Wg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdehieelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhephffvvefujghffffkgggtsehgtderredttdejnecu hfhrohhmpeetlhihshhsrgcutfhoshhsuceohhhisegrlhihshhsrgdrihhsqeenucggtf frrghtthgvrhhnpeetleevueeuvdejhfduudffieekjeekgfelueevudeivdeuvdeftedu ieekieekgeenucffohhmrghinhepshhhuhhtughofihnrdhfihhnrghlnecuvehluhhsth gvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhephhhisegrlhihshhsrgdr ihhspdhnsggprhgtphhtthhopeefpdhmohguvgepshhmthhpohhuthdprhgtphhtthhope hsrghmhidoshhpvggtthhruhhmsehlrghhfhgrrdighiiipdhrtghpthhtohepshhhhihm vghgrgesshhhhihmvghgrgdrohhrghdruhhkpdhrtghpthhtohepuggvvhgvlhesshhpvg gtthhruhhmqdhoshdrohhrgh X-ME-Proxy: Feedback-ID: i12284293:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 30 Jan 2025 06:29:52 -0500 (EST) Received: by sf.qyliss.net (Postfix, from userid 1000) id 8150E19D7C461; Thu, 30 Jan 2025 12:29:51 +0100 (CET) From: Alyssa Ross To: Samy Lahfa Subject: Re: [PATCH] fix(foot-vm): add dejavu_fonts and fontconfig In-Reply-To: <20250128222241.914713-1-samy+spectrum@lahfa.xyz> References: <20250128222241.914713-1-samy+spectrum@lahfa.xyz> Date: Thu, 30 Jan 2025 12:29:49 +0100 Message-ID: <87v7twy1xu.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Message-ID-Hash: WMJNBVSXDZHRZVLVTFH3QWF2W3OOR4UX X-Message-ID-Hash: WMJNBVSXDZHRZVLVTFH3QWF2W3OOR4UX X-MailFrom: hi@alyssa.is X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: devel@spectrum-os.org, "Dom Rodriguez (shymega)" X-Mailman-Version: 3.3.9 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Samy Lahfa writes: > Signed-off-by: Samy Lahfa Great, thanks for fixing this! As Dom says, it would be nice to have more explanation in the patch description for what the purpose of this change is, and please have a look at other Spectrum commit messages to see how the subject line should be formatted =E2=80=94 it should start with "img/app:", and it might be nicer to emphasize what it fixes rather than the underlying change being made. Some more feedback inline below. > --- > img/app/Makefile | 3 ++- > img/app/default.nix | 1 + > img/app/etc/fonts/fonts.conf | 21 +++++++++++++++++++++ > 3 files changed, 24 insertions(+), 1 deletion(-) > create mode 100644 img/app/etc/fonts/fonts.conf > > diff --git a/img/app/Makefile b/img/app/Makefile > index 7887aa8..8bfb7a1 100644 > --- a/img/app/Makefile > +++ b/img/app/Makefile > @@ -51,7 +51,8 @@ VM_FILES =3D \ > etc/s6-linux-init/scripts/rc.init \ > etc/s6-linux-init/scripts/rc.shutdown \ > etc/s6-linux-init/scripts/rc.shutdown.final \ > - etc/xdg/xdg-desktop-portal/portals.conf > + etc/xdg/xdg-desktop-portal/portals.conf \ > + etc/fonts/fonts.conf Please keep this list sorted. > VM_DIRS =3D dev run proc sys tmp \ > etc/s6-linux-init/run-image/service > VM_FIFOS =3D etc/s6-linux-init/run-image/service/s6-linux-init-shutdownd= /fifo > diff --git a/img/app/default.nix b/img/app/default.nix > index 6537fb2..fc2af0e 100644 > --- a/img/app/default.nix > +++ b/img/app/default.nix > @@ -37,6 +37,7 @@ let > s6-rc > terminfo > xdg-desktop-portal-spectrum > + pkgs.dejavu_fonts Can you take this as a callPackage input and refer to it without "pkgs." please, like the other packages above it? (Arguably, there's probably no point having anything coming from pkgsStatic any more in this image, since there's so much non-static stuff now, but for now let's stick with it to at least stay consistent.) > # Some packages can't (currently?) be built statically. >=20=20 > diff --git a/img/app/etc/fonts/fonts.conf b/img/app/etc/fonts/fonts.conf > new file mode 100644 > index 0000000..0dcde54 > --- /dev/null > +++ b/img/app/etc/fonts/fonts.conf > @@ -0,0 +1,21 @@ > + > + > + > + > + > + > + monospace > + > + DejaVu Sans Mono > + > + > + > + > + sans-serif > + > + DejaVu Sans > + > + > + > + /usr/share/fonts > + > --=20 > 2.47.2 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRV/neXydHjZma5XLJbRZGEIw/wogUCZ5tirQAKCRBbRZGEIw/w opaxAP4gi+/1OtPJ+X1DMzLxE6RpG6sj8MBTc4aGcINEn7U0OAD/X5/Elkxbwqcf 2i/P+PPodfzGHbzjdPcqRMm5+GV6Ng8= =M3KH -----END PGP SIGNATURE----- --=-=-=--