From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 8E8BD7027; Sun, 08 Sep 2024 07:46:21 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id 98944709A; Sun, 08 Sep 2024 07:46:16 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DMARC_MISSING, RCVD_IN_DNSWL_LOW,SPF_HELO_PASS,WEIRD_PORT autolearn=unavailable autolearn_force=no version=4.0.1 Received: from fout4-smtp.messagingengine.com (fout4-smtp.messagingengine.com [103.168.172.147]) by atuin.qyliss.net (Postfix) with ESMTPS id 88242701B for ; Sun, 08 Sep 2024 07:46:14 +0000 (UTC) Received: from phl-compute-06.internal (phl-compute-06.phl.internal [10.202.2.46]) by mailfout.phl.internal (Postfix) with ESMTP id 7D34E13802F3; Sun, 8 Sep 2024 03:46:13 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-06.internal (MEProxy); Sun, 08 Sep 2024 03:46:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1725781573; x=1725867973; bh=vXMxjUaHxD YwZgvybtHtJYQJIFIPBnLt2TbeUcgRiq0=; b=un+xUyJQi1P34ogv83x+lpeWgJ /qAc958Uu2LuDqxbiUJmX6N+lZiwgMl1GcP4G3ecZeaFq5V+6NJYiVWfOdEVQ4wi R509gOY1JIc1p8Sd+aXXlDKKKIjhPI5Gj2CiJ64hD7SW+vGV9WABZKa8e99Btsmp lAxdjo1Xa/kjQ7czFmMXusSI4YV0EQ2hOWrSeDUvPxwKt2hrj1uHC8qTx6cLhq11 haxy9TxVoC/GO8Dn6IH8wnT/3YK5eRFVq8YTjHirvs3Fdi0QzMoLGPizm9+wJdo/ CVEVp+qoyQofoCeNzzlHsHUvShPz3AF1VBjD7MITQSsyeEvkncGLEM3+yY8A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1725781573; x=1725867973; bh=vXMxjUaHxDYwZgvybtHtJYQJIFIP BnLt2TbeUcgRiq0=; b=PdqoUaBhTdspXN1MOsBgaBX8MIEJTJQr89CE8f6ME+WH WXdxvvzLzl3hId4KmT0KMf+aKHR9jjbVpOuaKF+QsnE8O4gybb3ktFy/A/6k+8Jh uuz1+j1+Sh87tKUfBA6Uf4+q3jtS4niiV4CrSqwhFsXz4m9huFqMetifLH3rkoDW Qr+UvJW5FCpobG9MEhBIBmnWLNSMPxB6XbgF7dRn5r01IR4z/IISADvN23GDl3Wo 32JUNQyT8WhK+Ik7RCOoir6IsgqF46EOq8WUbRmUTKqLRnNiIq1NbtqX58vICbX5 3ghsnBRPpkQ+aCnL/7i11yV//CoQEdHa3zrdbhtd9Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrudeigedguddvhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecunecujfgurhephffvve fujghffffkgggtsehgtderredttdejnecuhfhrohhmpeetlhihshhsrgcutfhoshhsuceo hhhisegrlhihshhsrgdrihhsqeenucggtffrrghtthgvrhhnpeetheevudfgjefghefhie ejudelkeeljeegvdekueeuhffhgedvveefteevgeetieenucevlhhushhtvghrufhiiigv pedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehhihesrghlhihsshgrrdhishdpnhgspg hrtghpthhtohepvddpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepshhhhihmvghg rgesshhhhihmvghgrgdrohhrghdruhhkpdhrtghpthhtohepuggvvhgvlhesshhpvggtth hruhhmqdhoshdrohhrgh X-ME-Proxy: Feedback-ID: i12284293:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 8 Sep 2024 03:46:12 -0400 (EDT) Received: by sf.qyliss.net (Postfix, from userid 1000) id F3D631874302E; Sun, 08 Sep 2024 09:46:11 +0200 (CEST) From: Alyssa Ross To: Dom Rodriguez Subject: Re: [PATCH] crosvm: Rename `--vhost-user-{fs,gpu}` args In-Reply-To: References: <20240906093430.1168464-1-shymega@shymega.org.uk> <87msklgh71.fsf@alyssa.is> Date: Sun, 08 Sep 2024 09:46:04 +0200 Message-ID: <87v7z6ziyr.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Message-ID-Hash: GO4I7QSC6JZKPNBHMRTMXE5AV6G6CRFW X-Message-ID-Hash: GO4I7QSC6JZKPNBHMRTMXE5AV6G6CRFW X-MailFrom: hi@alyssa.is X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: devel@spectrum-os.org X-Mailman-Version: 3.3.9 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Dom Rodriguez writes: > On 06.09.2024 13:22, Alyssa Ross wrote: >>Dom Rodriguez writes: >> >>> crosvm was producing warnings when using `--vhost-user-gpu` and >>> `--vhost-user-fs`. >>> >>> In this commit, I have adjusted the `crosvm` invocations to look >>> something like `--vhost-user $DEVICE`, where `$DEVICE` is, in this case, >>> `gpu` or `fs`. >>> >>> I have run unit tests, but would appreciate testing. >> >>How did you run them? release/checks/wayland is failing: >> >>vm-test-run-spectrum-wayland> machine # [ 14.028205] crosvm[968]: [2024= -09-06T11:19:20.132395456+00:00 ERROR crosvm] arg parsing failed: Error par= sing option '--vhost-user' with value 'gpu': missing field `socket` >>vm-test-run-spectrum-wayland> machine # [ 14.029442] crosvm[968]: [src= /main.rs:737] arg parsing failed: Error parsing option '--vhost-user' with = value 'gpu': missing field `socket` >> >>Does it need to be (from memory) --vhost-user gpu,socket=3Dpath or someth= ing? > > I thought I had tested them, but as it turned out, the command I used > was only for shellcheck. I've run unit tests again, and all seems to > pass. I've queued up the v2 patch for review. Do you think we could change anything about the documentation to avoid people making that mistake in future? It's hard to anticipate what will confuse people in advance. > Just a side note from my article about Flakes - we could use the > `checks` output to run on the `pre-commit` Git hook. This could then > check the commit message, run tests, etc. We could do that already, right? There's already a command you can run to run all the checks. My concern would be that some of the checks are slow (the ones that involve building images), so I think we might want a release/checks/fast.nix or something so it's not too annoying =E2=80=94 I f= ind slow pre-commit hooks to be a real drag if I want to keep rewording or slightly modifying a commit. The flake eval cache would certainly help with the other slow bit (Nix eval), though. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEH9wgcxqlHM/ARR3h+dvtSFmyccAFAmbdVj0ACgkQ+dvtSFmy ccBaWA//dvqyaI2P24ztVX7o4bqkFh1VCKgsXmgNuMXeriw8KRWofChwCORgsYIH f+GRjHf6wTHRFiVMm9C2MGPhYNwcluzS/ENmXhI25j6uHqHEPGf+a6SJ1xTeappv ZZJYKjm0ZBcH9rjgK2MeM8kFvsxiUa/kPGmq0PQShSb+OBcodNkMFI07cppexuzE YGm9PBfsrDb3fWirQ7ufv+pHTfLJnCHISu34RqDt0/RyDFKy8rgIQ+nCqt+IPyC7 2o5EByed6wR7J/bHL4IXfuggwFjAvrTIj4yf1KYr5fWiSO8MeSONtVISulwWKljj zz6D85d8LLGsy8OmVFRnMHOV5UzFf0K46MzXYEfUL1Odfx89nliGlJzQms4cwFF9 vQditWItTzgg/ALa3TrUJivRcyO4+DSqdGbWH9nEli6ZOoOxVe00B9eemwTpoBdK MslwB/23V9+HbgZwc41ulr15d4A1IVBMO3S4ogQsoGvO23app3PsUQiz20YlPnxg XcPz8DNPPJzyF+6yF/sER+rUq6iI/B1EPpgD5W9UvtQcChi/sV4JFRTzvv2hU84f 5YII0W3XdLXdZ8GL0V21ec55UyrUmdx3CufzBh5DP7er56lpDMI0AIBvyAHHOFhZ 7uOSjZKyc93a+YUPgjfKSixBGPaHmQ5ixx63+gWN6CYGpeocMl0= =KDaS -----END PGP SIGNATURE----- --=-=-=--