Re: [PATCH] host/rootfs: add /dev/fd and /dev/std*

[Alyssa Ross <hi@alyssa.is>]

[-- Attachment #1: Type: text/plain, Size: 1415 bytes --]

Demi Marie Obenour <demiobenour@gmail.com> writes:

> This is the same as 14483e1a690c (img/app: add /dev/fd and /dev/std*),
> but for the host.
>
> Signed-off-by: Demi Marie Obenour <demiobenour@gmail.com>
> ---
>  host/rootfs/etc/s6-linux-init/scripts/rc.init | 5 +++++
>  1 file changed, 5 insertions(+)

Hmm.  I did it only for img/app on purpose, because that's the only
place we run arbitrary executables.  In host/rootfs (and vm/sys/net),
we only run a limited set of code that we control.  WDYT?

> diff --git a/host/rootfs/etc/s6-linux-init/scripts/rc.init b/host/rootfs/etc/s6-linux-init/scripts/rc.init
> index 674fd38cc76837c7be25a5ef060f0f4d4b786394..ec654dd0ff329e01a25c03bdd80ee839e679e4d0 100755
> --- a/host/rootfs/etc/s6-linux-init/scripts/rc.init
> +++ b/host/rootfs/etc/s6-linux-init/scripts/rc.init
> @@ -2,6 +2,11 @@
>  # SPDX-License-Identifier: EUPL-1.2+
>  # SPDX-FileCopyrightText: 2020-2022, 2024 Alyssa Ross <hi@alyssa.is>
>  
> +if { ln -s /proc/self/fd /dev }
> +if { ln -s /proc/self/fd/0 /dev/stdin }
> +if { ln -s /proc/self/fd/1 /dev/stdout }
> +if { ln -s /proc/self/fd/2 /dev/stderr }
> +
>  if { s6-rc-init -c /etc/s6-rc /run/service }
>  
>  if { mount --make-shared /run }
>
> ---
> base-commit: 39baa378367d95fac6ce4d0140b25203b2ee9b53
> change-id: 20250805-host-dev-fd-51d57d8341bb
> -- 
> Sincerely,
> Demi Marie Obenour (she/her/hers)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]