From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 5EF5A96CC; Mon, 27 Jul 2026 12:18:58 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id E84B89660; Mon, 27 Jul 2026 12:18:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DMARC_MISSING,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 Received: from fout-b7-smtp.messagingengine.com (fout-b7-smtp.messagingengine.com [202.12.124.150]) by atuin.qyliss.net (Postfix) with ESMTPS id 5EC2D96B7 for ; Mon, 27 Jul 2026 12:18:55 +0000 (UTC) Received: from phl-compute-05.internal (phl-compute-05.internal [10.202.2.45]) by mailfout.stl.internal (Postfix) with ESMTP id 1456A1D001E5; Mon, 27 Jul 2026 08:18:54 -0400 (EDT) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-05.internal (MEProxy); Mon, 27 Jul 2026 08:18:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1785154733; x=1785241133; bh=KvjQEf7tub OdZTjayVVpumvTiFeqOimDRuJJV2+eOOo=; b=Xy48uP1oqWrgpgmshNJLl0XpJh Epg7VRICv5QdICixUBM8cyDlAfs96Sk8tHofjQ8ZYsEcgUqc+LND4si2D4+IprBP P9CbEKUdUod7QQiLUlu3O7k+Tn5R/05D+/zN96bGTRYtGSkZDTvOoNP/wfMLJjJ2 po+S6sHbaLo+awzf7JP84gTx0Mz8oY2Gp6orRPCuKExPRSfsyfu6X2oBfaOWmZ+y UUCcfJxOf8fcsn4rkTH6eN760+isQBLUGj8pBIQs2dTOdquxFXeNo83C0HoR47kA sSp/Ky/r6DxGfR0ExqO5lVnNjKfU9Inxs0oZ7Kr5iMBRcFVQ5VGoH27Oyaew== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1785154733; x=1785241133; bh=KvjQEf7tubOdZTjayVVpumvTiFeqOimDRuJ JV2+eOOo=; b=cBBKkTBqQW10kK6VrfdbaTNe0zzhtwWPRzsb90SpMrc7pJXUvk+ cEBwIFN2MC871f3eXEjyW41YOFfjKk2J2QmhYIl9p2jHAFhOCYz4YyuuwcRmh1dV /cRPoxDG4Jmst0zSxL35eyu00Y06Qrrg8SiC8lZefL5hPutcqg/ADfgOgCXn6RzY 73+uNFklZ7OffMHIEln7drObimydsDbXw9e4emJO2K6nEmTECz4JOyDJVzLCNHJ3 p1PGfrAXrxjQLodq8JvekyEgmMH7c3jAEn+zpK/QwAXXng/TQUKpmt8E9Z1G5pey 4qseb32+A9KQdw7tpYgIdmMxlRdSH9EE1kg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTGXP4jU7Ebg979q/prvspCwgWFae7HHpvj1tJQmrzInYwsCH77HFGApAHV9jyjxba 4XmW9wUakkJNcdlqJdsDPzSZhOlYXILXAGGnVx9afH8dBl6gZ1nHkcMk3VEhJxEzGa+VDk t0a9b2BM0Ascz5Q1zD61zZYQ+/MjQug6yOnVVxdyGlaJclw3neljwrnO0328+LIyFaTp++ kurNI2ybAq4zrd7W5oLlEbjKJlrbdofl1KN7usedbS5U9eWreKh2doLIMp4tKODxwuBXN+ B/8Y/f5+eewEUe05olHpPeCuL7ba2XuVQz/t6NoXV1oG+eKJgZZATmBV00GauH12IoK9Et xfSwF07uUD08lB+ErfWQNcvS2NJOHoa7eBADEYR3Re9j6uYJ2TOdaRNn8F+x+Hc9Sh5qbR x45eJatiVw981FyVfVb93vOkBimQfkIDK6f88eystu5T6v9U/phsrxafr3whCgAxue7IzC hue99BcFsRXjqP+wgfNYG3Iv5X4+I+aafN26onAADA2/QEACcdhxpWV4TDjiI91vMGCIg1 5oeWsIloOf5DiwdT+vOoRXlSaSTWvudfSqhzuNMmbfEb0O0fviwjEML0P93m2Jpu9A00PV VxTOWJA8MsINHnFSslhaFS4EK14i0zD3xGj6LpqXuuU/Y6/G6gAkSlKAkP0Q X-ME-Proxy: Feedback-ID: i12284293:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 27 Jul 2026 08:18:53 -0400 (EDT) Received: by fw12.qyliss.net (Postfix, from userid 1000) id 9E0D7C4D7AEC; Mon, 27 Jul 2026 14:18:52 +0200 (CEST) From: Alyssa Ross To: Demi Marie Obenour Subject: Re: [PATCH v4 12/20] host/rootfs: run-appimage: Purge the per-VM cgroup In-Reply-To: <20260721-cgroups-v4-12-46b2e5fff7b6@gmail.com> References: <20260721-cgroups-v4-0-46b2e5fff7b6@gmail.com> <20260721-cgroups-v4-12-46b2e5fff7b6@gmail.com> Date: Mon, 27 Jul 2026 14:18:51 +0200 Message-ID: <87y0ewk4lw.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Message-ID-Hash: ORTMBUANSAMR3KA5CV2QSA6D6AZGP7A6 X-Message-ID-Hash: ORTMBUANSAMR3KA5CV2QSA6D6AZGP7A6 X-MailFrom: hi@alyssa.is X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Spectrum OS Development X-Mailman-Version: 3.3.10 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Demi Marie Obenour writes: > Signed-off-by: Demi Marie Obenour > --- > host/rootfs/image/usr/bin/run-appimage | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/host/rootfs/image/usr/bin/run-appimage b/host/rootfs/image/u= sr/bin/run-appimage > index 672ec22d4b815fb9c2940e13ae08ed4093baee4e..03020c89b02f295844f5ed814= 034ba66be741f4b 100755 > --- a/host/rootfs/image/usr/bin/run-appimage > +++ b/host/rootfs/image/usr/bin/run-appimage > @@ -89,7 +89,12 @@ fdclose 4 > foreground { run-vmm $id } > fdclose 3 >=20=20 > -if { s6-instance-delete /run/service/vm-services $id } > +if { > + # Even if s6-instance-delete fails, cgroup-purge is enough > + # to ensure that the VMM and all per-VM services are killed. > + foreground { s6-instance-delete /run/service/vm-services $id } > + cgroup-purge /vm-services.slice/vm-${id}.slice > +} >=20=20 > if { umount -R /run/vm/by-id/${id}/ns } > rm -r -- $diskdir /run/vm/by-id/${id} /run/configs/${id} > Reviewed-by: Alyssa Ross --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQQGoGac7QfI+H5ZtFCZddwkt31pFQUCamdMqwAKCRCZddwkt31p FYl3AP9wfGadTfy0ZZKAYurFdShE1yc7FOyt7HvmzAHNNviAFgEAu5EMZWIag2w8 amnbYaHYeNfYr5Kuayh++9ngQkx17QM= =vAi3 -----END PGP SIGNATURE----- --=-=-=--