From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 48D0260BA; Tue, 21 Jul 2026 16:00:43 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id C6A4660B3; Tue, 21 Jul 2026 16:00:40 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DMARC_MISSING,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 Received: from fhigh-a7-smtp.messagingengine.com (fhigh-a7-smtp.messagingengine.com [103.168.172.158]) by atuin.qyliss.net (Postfix) with ESMTPS id 6690F60B0 for ; Tue, 21 Jul 2026 16:00:39 +0000 (UTC) Received: from phl-compute-09.internal (phl-compute-09.internal [10.202.2.49]) by mailfhigh.phl.internal (Postfix) with ESMTP id 5550D140014E; Tue, 21 Jul 2026 12:00:38 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-09.internal (MEProxy); Tue, 21 Jul 2026 12:00:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1784649638; x=1784736038; bh=e6Co4CVYeP oqmH4LDSDxk3Uc9uiu7VDn/0KsoYTfTbA=; b=jf+OoWomOiYWbhoAt/w1ohSmNT m4Q33umrNxQUgSS3D2ezbbInF70XFLufsa0Qg7wWTfi0QrsIfSfCDuihfsBpnl2X xxhAVy11+h9X8BXp3KFZYTfoN51LZZzF//+BH7R9XH16QcKAYiIUSdU4hxh9Wxm8 LtucM0pr+K1LMs7X4o/Ak7zm4phB9uSN2gUO1Zj3nFLep3MqoU21EYCPr6g4jlyo qmInoAXuWv0IXeEfv4OZZwwe/qSOD9pbKocaGpcxaIrNAdw8QtsB/VOIPRwPaNpj GXZdYe36Hyg5xUt/WPruSqlETk/ZJkvEjQSFZ9Qbt3xArVUCdLpOlePVh/fQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1784649638; x=1784736038; bh=e6Co4CVYePoqmH4LDSDxk3Uc9uiu7VDn/0K soYTfTbA=; b=UfSxk7vVhAmNGt8OdOhm4kI+hSoyy32wSDrqds9WmbfGgx/r98U Plhahx9HBqEW+mwzt+n+BqTzFmD63fdkm58TWB9MoYDAZUMLZZIsS324nC2HAsAG c8jDq0pZ+DBVJu/Rapjy6WBbCl+ZRA6Kc94w7CkeVvGvBkgpbWULxYTWN3471sYY DxLpLY/aV7gqEZLEt9Ewfs6jzHCvTcyL6ggnPXrgx0RC+O34mB0mO2f839l2IqX6 iG0TOnRVUEvgbJ58FOxwayb5BzJ5NWQVRupchdyYrF9Ru+gnPdtmrf9aow2c/cS8 imoxpvj/G9I8ronneV0O8j6uQQG9Z40E9xg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTFdTjvYhV9BVFg1vxfIiupNd6fVt+z6dDo+wbx+vUl3u8zFxbhRb2kcSCUGU/vvlc LUoB207vBdmeOCMV0hVwCtIV2NQROD9NhoKLAMpV/844CbxcZCILFou3zqqxIKMyCazAhi oJqmLUXcICsX8OBiqW7TrTyNf0By3kvDeGUs81RmTrG7PJIyE3Scy/u9TWnkt/ma0k2ziq 8glH7eI3g8cOnpwLcxvhbpz/cROnYHc4hlRSIcQEr4NMvdn52i9bMHOZS/MT+0FwHTWT8L Y0gNRukp/wKtB+/9drFOpbZR1gzvjqd0VWIAejF+y5GM/t1Q6y7A5oamq5u46H15xsh3t1 HSr7lJKHTyYwbZq9a1XMRf3SozcX5IRddkja69nZUkxC6J3CYDY0wbtt1utPe8kfyCB0JI ESFcHbEUPZykCVCrHJ7lnbB5OhMrlsilv40dxHXYiUPkqhONsdATyrX5LS1qJXUiZJQIOU VSAostaEnlt39T3MzRpTegoR5Xc+gD0+OfUIz6gxYXZVKhOM4IpyIXZLi8vU9a7LxnooYE hkbvjf3wVR0Xxx05lhEwGY5A3nz4DEIl615lULk/IeMQXSMcGpASoc9JSSOFEaEHcD4lcQ mIeGigXqS3OBb6W0Gy7nVEjbd+MaKgnnG6/gSqSEqaoQN/B+2Pssvbj6k40g X-ME-Proxy: Feedback-ID: i12284293:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 21 Jul 2026 12:00:37 -0400 (EDT) Received: by mbp.qyliss.net (Postfix, from userid 1000) id 2B5708964350; Tue, 21 Jul 2026 18:00:36 +0200 (CEST) From: Alyssa Ross To: Demi Marie Obenour Subject: Re: Networking test runs run-vmm twice with the same VM ID In-Reply-To: References: <87h5lze3s1.fsf@alyssa.is> Date: Tue, 21 Jul 2026 18:00:35 +0200 Message-ID: <87y0f4l4d8.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Message-ID-Hash: 4HZR4WMKVDFSW6VJDBOPBD2YHPJYZM74 X-Message-ID-Hash: 4HZR4WMKVDFSW6VJDBOPBD2YHPJYZM74 X-MailFrom: hi@alyssa.is X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Spectrum OS Development X-Mailman-Version: 3.3.10 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Demi Marie Obenour writes: > On 7/16/26 04:29, Alyssa Ross wrote: >> Demi Marie Obenour writes: >>=20 >>> The networking test runs run-vmm twice with the same VM ID. >>> If it waits for the previous cgroup to be empty, the second >>> call waits forever. >>> >>> Is this expected? I would expect that run-vmm is only called >>> once. >>=20 >> Assuming you mean run twice in sequence, rather than run twice at the >> same time, then yes, it is expected. >>=20 >> The way it works at the moment is that imported VMs have a VM ID >> assigned when they're imported, and they can then be started any number >> of times. When the VM shuts down, the VMM exits, so if the VM is >> started again after that, run-vmm will be run again with the same VM ID. >> If this were not the case, VM IDs could not be assigned at import time, >> and stay the same between successive boots of the same VM. >>=20 >> If your cgroup is not being emptied as expected, that is a bug, >> regardless of whether it ends up being used again, because there >> shouldn't be lingering processes or cgroups hanging around forever. >> It sounds like we should have a test that confirms that this doesn't >> happen, if it's hard to get right. >>=20 >> The networking test does do something slightly unusual, which is that it >> restarts the VMM with s6-svc -Wr -r, rather than e.g. via the Cloud >> Hypervisor API. I would expect that this runs the finish script, but >> might be worth confirming. > > What should happen if run-vmm is run more than once for the same VM? At the same time? That shouldn't happen. That can either be ensured outside of run-vmm or inside it =E2=80=94 I don't think that every time we factor out a common script it needs to add a new check that it's being used correctly, or the codebase will end up all usage checks. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRV/neXydHjZma5XLJbRZGEIw/wogUCal+XowAKCRBbRZGEIw/w opUbAQD5QCAfglg1qI6GEyNoAQmpuHy9sj3o/cErUx+q88BABQD/ccxItbTgcyPb f/xQ0yp+4iXAojsaHe6JBwba5QlPowQ= =e6vb -----END PGP SIGNATURE----- --=-=-=--