From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 178A61EF64; Fri, 19 Sep 2025 07:55:09 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id 150091EFAE; Fri, 19 Sep 2025 07:55:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DMARC_MISSING,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 Received: from fout-a2-smtp.messagingengine.com (fout-a2-smtp.messagingengine.com [103.168.172.145]) by atuin.qyliss.net (Postfix) with ESMTPS id 59DB01EFAC for ; Fri, 19 Sep 2025 07:55:06 +0000 (UTC) Received: from phl-compute-05.internal (phl-compute-05.internal [10.202.2.45]) by mailfout.phl.internal (Postfix) with ESMTP id 79768EC01F0; Fri, 19 Sep 2025 03:55:05 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-05.internal (MEProxy); Fri, 19 Sep 2025 03:55:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h=cc :content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1758268505; x=1758354905; bh=+URCjBVtnE 40q7xj41V38XzOnckEi29gHOzrdwquw5s=; b=Y7rlOoO4pJ5C0+8oIXFFEnQvyZ TSHIgJm/7eUVzstvm58f8z8uzDdWcrkfNuut9NRcSHUx0VhrayfGecJ5Hz7FOR4T 0A1DO52GERFttsa5JMd3ryKu0dESquT7Ulkc4zvYnieSUIwaC+Ekgc7zJEnt3SwF wJXPI1R0wgyciqWQyCd1kRe41cCMsaKIM0HmC6WdBTkssc0zax5AZkkqw1ZV05IP YJ9P7KCyH/b5Rd0Dy6CBhXT2ukxxfN/PY+pXwVGs9rgdWznEb8Kk9BCrhXvORcm2 CQc+daKxhjuJ0apvshajhSDd0EPxSE4BgjjLbXlNvjiMSVbkyRxi4mG9jwDg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1758268505; x=1758354905; bh=+URCjBVtnE40q7xj41V38XzOnckEi29gHOz rdwquw5s=; b=l2NkTE2lU7lYjcZ6O1QmncSJSQa+KEmAwn48ZFuuUM4pEgdTwcE S3zCgsy2/1mv+Z/MA1ZbCQG8AOHK4bW3V4JazTsMfPLL7NRB0hHlImW1TpcDak66 zDmwpMWvUhL+u97Ix3GQDCn/uG7DitA95SGFK00s2XedOO485KfEqHO+0kftjvDq U+/2CF/zyvmxnhp9o91mdz+dV/TACRaBkYCUHMSzIyWuMauHnl1E0s/BuPsT6k0+ LTNDH/dUb3QDT7/UQi+Ij7AdsOZTZt5/sk4e3fdbn9hA7NRmlvWMqHa8LY9QsSNl eNoKkfeQceQtpGr36Nq3l79UQF9W3qk3tGg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggdegkeeiiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpefhvffujghffffkgggtsehgtderredttddtnecuhfhrohhmpeetlhihshhsrgcutfho shhsuceohhhisegrlhihshhsrgdrihhsqeenucggtffrrghtthgvrhhnpeduffeiueeltd ehveehfeeiteevveffhfdvudethfeivdfgheeitdeffeelvefgudenucffohhmrghinhep shhpvggtthhruhhmqdhoshdrohhrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrh grmhepmhgrihhlfhhrohhmpehhihesrghlhihsshgrrdhishdpnhgspghrtghpthhtohep vddpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepuggvmhhiohgsvghnohhurhesgh hmrghilhdrtghomhdprhgtphhtthhopeguvghvvghlsehsphgvtghtrhhumhdqohhsrdho rhhg X-ME-Proxy: Feedback-ID: i12284293:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 19 Sep 2025 03:55:04 -0400 (EDT) Received: by mbp.qyliss.net (Postfix, from userid 1000) id 0D6311F879FE; Fri, 19 Sep 2025 09:55:03 +0200 (CEST) From: Alyssa Ross To: Demi Marie Obenour , Spectrum OS Development Subject: Re: [PATCH v3 1/4] Do not ignore errors from tar In-Reply-To: <20250911-genfiles-v3-1-d8709081dc5c@gmail.com> References: <20250911-genfiles-v3-0-d8709081dc5c@gmail.com> <20250911-genfiles-v3-1-d8709081dc5c@gmail.com> Date: Fri, 19 Sep 2025 09:55:01 +0200 Message-ID: <87y0qazxka.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Message-ID-Hash: CYY4Z5DZT4N5P4GBPC4YCWZG4YKABCEF X-Message-ID-Hash: CYY4Z5DZT4N5P4GBPC4YCWZG4YKABCEF X-MailFrom: hi@alyssa.is X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Demi Marie Obenour writes: > These would be ignored due to a missing -o pipefail in the shell script. > As a result, listing nonexistent s6-rc-compile inputs would cause a > broken image to be successfully built. > > Reported-by: Alyssa Ross > Link: https://spectrum-os.org/lists/archives/spectrum-devel/87segu879h.fs= f@alyssa.is > Signed-off-by: Demi Marie Obenour > --- > host/rootfs/Makefile | 4 ++-- > img/app/Makefile | 4 ++-- > vm/sys/net/Makefile | 4 ++-- > 3 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/host/rootfs/Makefile b/host/rootfs/Makefile > index e96458dba06ae31129b115b2b649962f8d88187a..2288ae4d22ca817ba9fe8ebfc= 42326fe38b27c27 100644 > --- a/host/rootfs/Makefile > +++ b/host/rootfs/Makefile > @@ -169,8 +169,8 @@ build/etc/s6-rc: $(S6_RC_FILES) > mkdir -p $$(dirname $@) > rm -rf $@ >=20=20 > - dir=3D$$(mktemp -d) && \ > - tar -c $(S6_RC_FILES) | tar -C $$dir -x --strip-components 2 && \ > + set -uo pipefail; dir=3D$$(mktemp -d) || exit; \ > + { tar -c $(S6_RC_FILES) | tar -C $$dir -x --strip-components 2; } &= & \ Why do we need to change `dir=3D$(mktemp -d) &&` to `dir=3D$(mktemp -d) || = exit;`? In my testing we'll jump to the rm/exit with the former, which seems like the right thing. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRV/neXydHjZma5XLJbRZGEIw/wogUCaM0MVQAKCRBbRZGEIw/w ootjAP44QZFU7uVoJe50nQ+zy0T42o6E2AM4ReCi3bpyRlmHGQEAuJHzxvzGdc/r C91ufwTqfEjgM2BHftFbq/XHCq9nUAs= =YrR/ -----END PGP SIGNATURE----- --=-=-=--