From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 8154C1861C; Mon, 21 Oct 2024 19:54:09 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id 1C4BD1857B; Mon, 21 Oct 2024 19:54:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-1.7 required=5.0 tests=DMARC_MISSING, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,WEIRD_PORT autolearn=unavailable autolearn_force=no version=4.0.1 Received: from fout-b5-smtp.messagingengine.com (fout-b5-smtp.messagingengine.com [202.12.124.148]) by atuin.qyliss.net (Postfix) with ESMTPS id 08334185AD for ; Mon, 21 Oct 2024 19:54:03 +0000 (UTC) Received: from phl-compute-07.internal (phl-compute-07.phl.internal [10.202.2.47]) by mailfout.stl.internal (Postfix) with ESMTP id 47AD21140099; Mon, 21 Oct 2024 15:54:02 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-07.internal (MEProxy); Mon, 21 Oct 2024 15:54:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1729540442; x=1729626842; bh=MNnPG5mNWL lDDe3b0hX5pBSixLiayMMkDTzmE9Zc/XI=; b=tyPcVAOYef4O9P1Y10fNJz6pFh QPvLRchUdax/e3GEdyZoN3C6AED+UEcvtOPN70Ij1Gs6diTwS4P1F53FsiDwB9uu tFIOLEVqsB+MLfcSlJPwOkhtiD0UEI9/70pKgBdCMbNKzgJPBsEcW5pfMNT6dKp5 KH8lhk/LZ/jzgAHrCxyM8qxrr1MzLA51vKISMyq7GJGeeJUzAlDYQEbTagfCTdyW i13siegV+jv+5MRqrKrWHyQoq3Lme+tOpqRK3jRibwTo5M/t9wnSWAGi/Z6X2bdA AsVDNeeipD7OpooGJ6QAmVsGgGRpA+IyPh8V/mR7VlVXckIFtb/Xl9xmBmpA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1729540442; x=1729626842; bh=MNnPG5mNWLlDDe3b0hX5pBSixLia yMMkDTzmE9Zc/XI=; b=YpSMoEq/brHGBKrqv+OhCUWRzAIwjHv5sAlFbc3ZqtJE Gk+ArjoM/qUeIPv26z0h29btFSXwaL3eU1sgIJMA+EaSduitVRZ1TlgM6S18yEFK +H/5XPqcSzo5b8cAAdB9GQ3NKQ1PXd1UmrW5/UEDNISHj3yK7ToJJztE0lRpqRsl O2Y5I/w3y3IU48itkojZqiEYY17RzlPg2DZ9mSnZOYvjoHrW4fX20/oz+6j8fbla iPfM2VG8TPsic+fUK9dBwVOS+tpNL1ddXhWnzpLSPraTKwrVEYYkUZoymVdNrCb8 woEKuMYiOpNYCcHGtFWcZTuoohYni2WeIQj1lp7K9A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdehledgudegfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecunecujfgurhephffvve fujghffffkgggtsehgtderredttddtnecuhfhrohhmpeetlhihshhsrgcutfhoshhsuceo hhhisegrlhihshhsrgdrihhsqeenucggtffrrghtthgvrhhnpeeiudffueeilefgtefgtd dttdekkeehkefgheekudefveetgeefiefftedvteeuveenucevlhhushhtvghrufhiiigv pedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehhihesrghlhihsshgrrdhishdpnhgspg hrtghpthhtohepvddpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepshhhhihmvghg rgesshhhhihmvghgrgdrohhrghdruhhkpdhrtghpthhtohepuggvvhgvlhesshhpvggtth hruhhmqdhoshdrohhrgh X-ME-Proxy: Feedback-ID: i12284293:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 21 Oct 2024 15:54:01 -0400 (EDT) Received: by sf.qyliss.net (Postfix, from userid 1000) id D61911A9CA914; Mon, 21 Oct 2024 21:53:58 +0200 (CEST) From: Alyssa Ross To: Dom Rodriguez Subject: Re: [PATCH v2] crosvm: Rename `--vhost-user-{fs,gpu}` args In-Reply-To: <875xpl962r.fsf@alyssa.is> References: <20240906224329.2336996-1-shymega@shymega.org.uk> <877cbnfmdf.fsf@alyssa.is> <87bk07am4z.fsf@alyssa.is> <7nuyrpnpikc7ctg54yupkv72wdk2ckaqwbexfjtz3bnmxlvkoj@qhrjrshiotxh> <875xpl962r.fsf@alyssa.is> Date: Mon, 21 Oct 2024 21:53:54 +0200 Message-ID: <87y12htep9.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Message-ID-Hash: 5ROUUJA3YWSRVSS5HYSVL4MHQR7CMTR5 X-Message-ID-Hash: 5ROUUJA3YWSRVSS5HYSVL4MHQR7CMTR5 X-MailFrom: hi@alyssa.is X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: devel@spectrum-os.org X-Mailman-Version: 3.3.9 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Alyssa Ross writes: > Dom Rodriguez writes: > >> On 28.09.2024 16:27, Alyssa Ross wrote: >>> >>>You're right! I've just spent the last little while looking around >>>trying to figure out what's up here, and I think I've figured it out. >>> >>>In this commit[1] they made the vhost-user-fs tag optional, because it >>>can now be set with virtiosfd instead of the VMM. This is probably >>>good, because the more generic vhost-user becomes, the more hope >>>Spectrum has of one day not needing Cloud Hypervisor patches. :) So we >>>could try using --vhost-user fs for crosvm, and then passing --tag to >>>virtiofsd, but it'd need to be tested with VMM=3Dqemu and >>>VMM=3Dcloud-hypervisor as well, because I'm not sure whether they support >>>a backend-provided tag. >> >> Oh, that explains *a lot*! I agree, a generic approach would be >> preferable. >> >>>If that's too much work, I'd also be happy to apply just the GPU part of >>>this patch. Just let me know. :) >> >> I've started a new job, and so I've only really got weekends free - and >> even then, I have Repair Cafes to volunteer at.=20 >> >> If I send over the GPU patch only, can you apply that, and then we can >> discuss on Matrix/IRC the best approach for `vhost-user-fs`? Feel free >> to tag me - I'm mostly using IRC rightn ow. > > SGTM. BTW: I've just seen this when building release/checks/wayland after a recent Nixpkgs update: machine # [ 18.830327] crosvm[987]: [src/crosvm/cmdline.rs:2829] Deprec= ated disk flags such as --[rw]disk or --[rw]root are passed. Use --block in= stead. Just in case you're interested. :) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEH9wgcxqlHM/ARR3h+dvtSFmyccAFAmcWsVIACgkQ+dvtSFmy ccAuyA/9Fr7jJHHdYS9NDo0oA1lsFFskcbQh85sp5jzKTBl++/Xr2y0OCO5E0/Y1 8A+lGMgpOk5zJzy2ZCr/Q/jjfsjjtDiNKw9qhE4W0q1wze/FLYcC1xgaGFjP0kxC cdTHXJggpakSiobOOBw1TgsnyymYczMqKDfeX5Ibq3cxbhUu2AaYw1kGtYmNRpMx RkSaRnsks1aSRUZc4mDZ3kvlKZDYxXimba8lGsxI8P8uCtUBC7y8IsIj7bN+EAsZ lihizDclaF9PdSyla4Y/+jgxr418hUIUxxCJ1XtgJZpkriPhvhSm59LeljpdRqTY p7+F2ShjJXqJHcqXg6Y7PanWJ812a3NNd65JxyQtKKpKAl0uci12/QtOARoHRZZq SR0A9X9Oqf6X6M6+Yheo009BihtgV5UbKxLMD7Qvj+wDGFJmzrmcwseAUl7lNkqf UYffW4uurbtbDki45LxzAk/Je66FFDathFm3mvmowQZIYFpdG2gEAf6ri9bYC3Wx zMCzpA7ZalzbG2bhBxq1eRbdJWFUCKcMQoUYohUfsZK/XEXhQiEcfCla6L3d3P6j uULyDTnmkpC/x5QRrEPpqyMg2wBxl6h4LBgfdgpSdw1TkDo0nmz13A12+L79qnjZ Nlpi2bKeXMMAsnnREXVE7xzGlg3mNb0YpTQHaTBknGPehX5y96w= =RGi/ -----END PGP SIGNATURE----- --=-=-=--