From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 3E58B5E64D; Thu, 8 Sep 2022 10:53:05 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 496) id 83CFF5E688; Thu, 8 Sep 2022 10:53:03 +0000 (UTC) X-Remote-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on atuin.qyliss.net X-Remote-Spam-Level: X-Remote-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL, SPF_HELO_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by atuin.qyliss.net (Postfix) with ESMTPS id 3B02D5E686 for ; Thu, 8 Sep 2022 10:53:00 +0000 (UTC) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 9BA275C0162; Thu, 8 Sep 2022 06:52:58 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Thu, 08 Sep 2022 06:52:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1662634378; x=1662720778; bh=O9jOFEtZXx lzxT1V9XvUNTrZ0p1yZfS5K9hJWAlEjrY=; b=nnTyTIxsWbONPZaEUVQbt2gReV hTgjqdhe8+6RqvM+442RM/Rt3p1y+/LInmWIqDGc8FMQ0wGXftXxq4+iLnk8Hawv z1UgffQOR+72J38a1jQ64F7gh4Evvfph5WJfP8fjOKR9CzzwMYqF2XmUgAompXwB 78HJNc+LGytYlJHUB1ibbESn6qF7eWzRho//6RXHzvSrsw5OfaSDSRLbsf5xIDtg R7WHFf0jCUGnhzkislxOcV8BlLyeVmDRJwCiJITva3zuKFPYLg0TnU0xZjWCMRNH dKK/xQNY+W0JcbztkLm3GJAk1A2bTOHN+Qahyjfz2+kGyGLWNKpUfC0drmqQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1662634378; x=1662720778; bh=O9jOFEtZXxlzxT1V9XvUNTrZ0p1y ZfS5K9hJWAlEjrY=; b=c/10THGzXQ7Mtc0UY3FDmNNV/cCIzaQBxqvtO66tKeat YcyMGPTn/ap6+Ur+KYNuuiZ6K0A2ZzL/R4lpBwJRwZu8RiupVEMxzEnerhdHuMAn B1pN0IISAhtoBtLsX/OrTUieLhO2kxoSb91ZoH0PoD3CjLrBozOkTMjbLARJvLxJ /di31lkkQ1g4JoX5EBR2+N8B4CjLiaxABS3zg+PX33XwNar95L1WURVKjIjClTKP s5KJXENSCUx0NNdsd67lrZ6H35scpcqDTjfsd47LubI0v0ucQ0PBeeF5bkt7TUBV J1ljESfvFM+38OR/Lg2WA9pL8psE15Ko/dE6l5O0Tg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfedtvddgfeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefujghffffkgggtsehgtderredttdejnecuhfhrohhmpeetlhihshhs rgcutfhoshhsuceohhhisegrlhihshhsrgdrihhsqeenucggtffrrghtthgvrhhnpeethe evudfgjefghefhieejudelkeeljeegvdekueeuhffhgedvveefteevgeetieenucevlhhu shhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehhihesrghlhihssh grrdhish X-ME-Proxy: Feedback-ID: i12284293:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 8 Sep 2022 06:52:58 -0400 (EDT) Received: by x220.qyliss.net (Postfix, from userid 1000) id 00D2029F; Thu, 8 Sep 2022 10:52:56 +0000 (UTC) From: Alyssa Ross To: =?utf-8?Q?Jos=C3=A9?= Pekkarinen Subject: Re: [PATCH 1/2] host/rootfs: use initramfs in "make run" In-Reply-To: References: <20220901104629.863380-1-hi@alyssa.is> Date: Thu, 08 Sep 2022 10:52:52 +0000 Message-ID: <87y1uu9lyz.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Message-ID-Hash: OT5VZISF4XO7RMZSKODZTGRXUXZW4VBZ X-Message-ID-Hash: OT5VZISF4XO7RMZSKODZTGRXUXZW4VBZ X-MailFrom: hi@alyssa.is X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: devel@spectrum-os.org X-Mailman-Version: 3.3.5 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-TUID: 5Au2L2YwQP03 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Jos=C3=A9 Pekkarinen writes: > On Thu, Sep 1, 2022 at 1:47 PM Alyssa Ross wrote: > >> This will allow us to stop compiling e.g. the virtio-blk module into >> the kernel, because it will be loaded by the initramfs. >> >> This introduces some duplication between the rootfs and initramfs's >> Makefiles. I don't think it's worth the effort at the moment to try >> to reduce that, because it would come at the expense of additional >> complexity in the Makefiles. We can revisit this later if we want to. >> >> Signed-off-by: Alyssa Ross > > Hi, > > This patchset introduces errors in the default qemu > > configuration of spectrum, where it is possible to see in the > console log attempts to load broken aliases like: > > modprobe: FATAL: Module acpi:PNP0C0F: not found in directory > /lib/modules/5.18.0 This is pretty much expected. The only job of the initramfs is to get the root filesystem mounted, so most kernel modules are not included in it to keep the size down. It just contains modules related to block devices, dm-verity, ext4, etc. If a we try to load a driver in initramfs, and it isn't available, that's fine, because when we get to the root filesystem, we run mdevd-coldplug again, and the module will be loaded at that point. The reason this didn't happen before when testing Spectrum in a VM is that since all the drivers we needed were built in to the kernel, the the block device nodes would be available before userspace even started, meaning that the initramfs simply wouldn't have any time to try and fail loading any other drivers before the rootfs was ready. On hardware, where the appropriate drivers wouldn't have been built in, I assume these messages would already have been normal without this change, although I didn't test. > As well as valid modules load failures like: > > modprobe: ERROR: could not insert 'vfio_pci': Invalid argument I wasn't able to reproduce this, with this series applied on top of commit c0b9dff8653b59f5d2a24bb539cba6c91d3f7506, Nixpkgs commit 4d05083dd894b73941e2e7d3b4f428b0ce1c7007, running Spectrum with `make run' in the host/rootfs directory. I started netvm and verified that the QEMU ethernet device was successfully passed through as well, so vfio-pci was definitely working. Does that differ to the versions you were using to test? If so, could you try with those versions and let me know if that works for you? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEH9wgcxqlHM/ARR3h+dvtSFmyccAFAmMZyYcACgkQ+dvtSFmy ccDTgQ/8DSbiT78VEwa0oF8gUmGyVqQiA4RSuTYesgGqBh6J8tHEua1obKxIN+nq WK8oLcwkhNT9jXkYZ/o7jIltCskRh4Cc9iIE83uzVQjNrUoIkenUgrEZSOUKd7UO l/iInFY/nT4d7a5lEpb2G0OuX4wYLcySsnis7lzBykE0dsvUMiwHOG+MF/DVHUoN Z13Va/V1L+RwZ6IUpvUefmRtbfbwXMKlhuhQ00T04aE5u9kIsffurDXhoT1odyLO vg+829f/LTe2kP9Fh6YjXM3Z+wNJrqAzJR9Q/GNKqkLOYzCJRY4Ot+rORx9fpcWU mvFfCQZzWZc1Qw/+dUvjSjmTwZkNskzZxqlWoylEW4uViN8H81HwGImgntRca2FZ HCHAPiOXN0WxLRXdjiwrRvxvucCsxC+IXaZN9yjgYfZUrvolQJkMmqliqHW2F+Jd qG2Yv84FZywqp+C8A386pz8WEQ3H1n8Uw4LCbctLQMQgmzm0Q13hLmx4yRx3BKo8 EJ0oHf3LZk4k6OWjtzWBmkXrGZ/5Kc+NDeHnNaoll6JQ1w+113zR4e/udqcVsLXx wLflwBZPi4X4kd6O73hbsG+TvYcsIgta/5GPwekqKLTNBFzqyttz5tmYZH/K5sEF 2nHlix+CEyBj7kZZGxjhn6FKPksJnx7oFf8o/64pB9HvAJXSoFU= =OPLY -----END PGP SIGNATURE----- --=-=-=--