From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 63E2BC3FC; Tue, 23 Sep 2025 13:58:40 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id 5510EC3EE; Tue, 23 Sep 2025 13:58:37 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DMARC_MISSING,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 Received: from fhigh-a7-smtp.messagingengine.com (fhigh-a7-smtp.messagingengine.com [103.168.172.158]) by atuin.qyliss.net (Postfix) with ESMTPS id 14DEBC40B for ; Tue, 23 Sep 2025 13:58:35 +0000 (UTC) Received: from phl-compute-12.internal (phl-compute-12.internal [10.202.2.52]) by mailfhigh.phl.internal (Postfix) with ESMTP id B0E76140009E; Tue, 23 Sep 2025 09:58:33 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-12.internal (MEProxy); Tue, 23 Sep 2025 09:58:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1758635913; x=1758722313; bh=d4FKpK45eU VYJilNWVTKYTSQVMG0mdvmJjgkTBSL3wk=; b=KNxrkmwp/0sCzmkMMwJyRgxw7q MpwDvEiEzD7ACHKV1GNDbwyGHG45j/zkkk6hWE0arK89J/+NxhDNbf6g8Zd7FUXT WYMf/L6xUe6zZz1vqGIKhPr+Kezg/CpkqV+vsdTHTgrmV/w46TCE5stnEJkOYjN9 TEssrzoV6rLQjuIwlWNwE3ksa2M/5PaUJSvY8B3JBC76bEZtFnGzMk/D5PuV5agJ Gg5P6iTdlq6RFyDy9itX/PmG+t6bwiCf92mHFarAAm2iYCLLSRf4B6xDVNNGg8A0 /EHtGaD/0mTKkl3W7uReAL0g2yZuWYkiFQXevGSjS2EJlO6oNP6bLGRu8blw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1758635913; x=1758722313; bh=d4FKpK45eUVYJilNWVTKYTSQVMG0mdvmJjg kTBSL3wk=; b=mfyBVwqenIY2oHTFt1MGMuosjBmUHfHmqg7raUtetEpmHbs6/JQ lizyTr/i9Iv4CB8Tc2WKVlPFaUW6J9WfK6TERAaPbaeFycGx/wMwfyaP4cZq0Xc9 316b2yy8vZKjkbgvimsI+yF1ETFkTszmXC8kFJrdjbG18rFvdmaHFG4lctNc65PV O7rIh3QGuU+aIUBAUDYh12hp7qxCExk5UpQT5pKH+itzGWNY6jsGyTKGTJaD2+OZ gBR7PeI662VJxPkaJCL0hmmKx5t3vuUGuu3CW6XvXedeJsU2MiafVRQXjx4ysck1 BZAbTwCkjU2bDQbxDVWTcqDxJFy5zNG+HNg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggdeitdeludcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpefhvfevufgjfhffkfggtgesghdtreertddttdenucfhrhhomheptehlhihsshgrucft ohhsshcuoehhihesrghlhihsshgrrdhisheqnecuggftrfgrthhtvghrnheptddtkedtvd eltdeufeetheffjedtjeektdegudegjedujefhveevtdekueejgeejnecuffhomhgrihhn pehkvghrnhgvlhdrohhrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmh grihhlfhhrohhmpehhihesrghlhihsshgrrdhishdpnhgspghrtghpthhtohepfedpmhho uggvpehsmhhtphhouhhtpdhrtghpthhtohephihurhgvkhgrsegthigsvghrtghhrghosh druggvvhdprhgtphhtthhopeguvghmihhosggvnhhouhhrsehgmhgrihhlrdgtohhmpdhr tghpthhtohepuggvvhgvlhesshhpvggtthhruhhmqdhoshdrohhrgh X-ME-Proxy: Feedback-ID: i12284293:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 23 Sep 2025 09:58:32 -0400 (EDT) Received: by rock.qyliss.net (Postfix, from userid 1000) id 9F062156884C; Tue, 23 Sep 2025 15:58:21 +0200 (CEST) From: Alyssa Ross To: Demi Marie Obenour Subject: Re: [PATCH v4 2/5] tools: add xdp-forwarder In-Reply-To: <20250923132012.28013-3-yureka@cyberchaos.dev> References: <20250923132012.28013-1-yureka@cyberchaos.dev> <20250923132012.28013-3-yureka@cyberchaos.dev> Date: Tue, 23 Sep 2025 15:58:17 +0200 Message-ID: <87zfaluv7q.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Message-ID-Hash: LAALPS7CXEHMXTAV35HLUM6DSCOULZJ2 X-Message-ID-Hash: LAALPS7CXEHMXTAV35HLUM6DSCOULZJ2 X-MailFrom: hi@alyssa.is X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Yureka Lilian , devel@spectrum-os.org X-Mailman-Version: 3.3.9 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --=-=-= Content-Type: text/plain Yureka Lilian writes: > The xdp-forwarder's purpose is implementing the functionality needed > within the net-vm (a VM running the Linux drivers for any physical > interfaces on the spectrum system). > > In the future, the net-vm will load the included XDP programs on the > passed-through physical interfaces as well as the downstream virtio > interface going into the router (recognized by its special MAC address). > > The net-vm needs to multiplex between the physical interfaces, as there > might be several interfaces in the same IOMMU-group. > > For this, the XDP program loaded on the physical interfaces > (`prog_physical.o`) applies a VLAN tag corresponding to the interface id > and redirects the packets to the router interface (identified by the > `router_iface` bpf map). In the other direction the XDP program loaded on > the router interface (`prog_router.o`) removes one layer of VLAN tagging > and redirects the packets to the interface read from the VLAN tag. > > The helper program `set_router_iface` is used to update the `router_iface` > bpf map to point to the interface passed as argument to the program. > > Co-authored-by: Demi Marie Obenour > Signed-off-by: Yureka Lilian Demi: are you able to give a Signed-off-by for your part in this? (I'm referring to the kernel documentation[1] for best practices with this stuff, and it says to get Signed-off-by from every author for a patch. No need to worry about it being pedantic on what order the tags come in etc. though, or the fact that the kernel uses Co-developed-by rather than Co-authored-by like everybody else.) [1]: https://kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEH9wgcxqlHM/ARR3h+dvtSFmyccAFAmjSp3oACgkQ+dvtSFmy ccAY8Q//VpNSMWa0eOC35KTb8b1YYQ7n65dfhESVFQ7ZsZAQlwOWQM73MJh6lPJN kUFERXx5Wq1glbztFlJZrwIjGDOstTK5tlDke0yvBk2B0V7CZxLu7bY4UPEAHC+z GwEQXWADdqh303WpGSuEW3fdhQaY4ksfkeVscoO45WsxaRiCsN5pUEJHcPplM2Wn G+k8Zn91qPEi3f64UbgCp6recKRl1LmSOvCezSUWhHJ7wu60N9RiHCw6pHCTwZ1I ELqEW1nXgiVsmW5VAx162UZJjgPghab85FD1mbJX5Mk+Awtdp0xxn23ELc/1yC5B NqUk0UBw9nSwk5QfX4qVyg5R0bGchDPGHOMm6qYSR387FL0W6tznW9nGq+0Cau9o VjL8Vwidr2pYjWThZ8ZVxBoN/xc43EWrKi8rM4AC10k0N7Y0/UNXdepwdtL/XjCH xgOGxZnmirfCOr726PF0Xtbz5Sjmmy/Lysi+u3A7KtKPUiJeYZ/bbd8oWbKP42qF IzFNteCvl3E2NIsUI4Wp8jvqeTHyUVZrFiJtjixdBvaRiaLyKbNBs70Qd3Q68Xv1 C2T7dizNFllN+hr5UXJVBFTHk1nDha/jUm94el55k8GIbH33+9211GK9rnj09j68 AJzyx7L7nU0GmGHoPZPSabVamF04Hgfi1m1bxnOKAo1vUaIRcEA= =wsoM -----END PGP SIGNATURE----- --=-=-=--