From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id B890A10BB9; Sun, 31 Aug 2025 11:02:05 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id B4DDD10B3B; Sun, 31 Aug 2025 11:02:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DMARC_MISSING,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 Received: from fhigh-a8-smtp.messagingengine.com (fhigh-a8-smtp.messagingengine.com [103.168.172.159]) by atuin.qyliss.net (Postfix) with ESMTPS id E5AD110B39 for ; Sun, 31 Aug 2025 11:02:01 +0000 (UTC) Received: from phl-compute-12.internal (phl-compute-12.internal [10.202.2.52]) by mailfhigh.phl.internal (Postfix) with ESMTP id 3942D140004A; Sun, 31 Aug 2025 07:02:01 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-12.internal (MEProxy); Sun, 31 Aug 2025 07:02:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h=cc :content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1756638121; x=1756724521; bh=0UHMyK0Zfr fAqp1C6k0ZtKYDfYCymTdH0M6giBP2Xy0=; b=CjgzxSd69WVzNa7yZ5OofDOiFl E0alu26Poq/8ubWynSz+Vjlk7LxcGSz1sEUhlsuL7aY4PAnomxopZKbX7xjG+KeO 6+miYOxrHSNm+zbvf6u69zAfEoHXUoFjM2DGYcJKZIK5PYFsyDIRjPpGBteruk10 Si/tNT72wbIfvP4bflPa+wjBhjnUoWQtpnOKS5aJxH3vcJ565hR141oOhWByFkjH 4ecChD8Jhe1Ft3OrNSCEiivhZuGat6X9xbuiBD7yrsTzPPEbRZl03manzSLIntUb TvbyuldvqVL2G432MnSD1/sCDZwUYEOZFbes1gIEJD9rsdFLaTE7oTj8nmog== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1756638121; x=1756724521; bh=0UHMyK0ZfrfAqp1C6k0ZtKYDfYCymTdH0M6 giBP2Xy0=; b=CFyKlAse6sq6gtaaIx2iwTWHR4fvZ1m58yIJ4BXwyd2huyN5ysV PrthjwfTqpeNLGj4YZ56fe0wob0bdgfHnSlOuYum00yNxrnF7mahiyq8Tof9PK+0 S5KVvZHWr+mjh38mmXzqUh0t2vAll4JKakAwEsG9/GeJsOmJ4ZpCvd0d7/z9K8aT +EJwplivBFqZIzW+WxHTacdnJPCgAPerRDnYwjsEKBDx9da/A5BVv+M3lG8QTJ81 5B12Hup7q7MA4j2K8K1IQk7nflJs0aY3Ai2O8vKHQmpoyA7XmYwNlgbOHI8qYzwx kZIa86cVYFzZ76y4NkTUL+Mt/jF9JQjZBbA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdefgddukeeluddtucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhephffvufgjfhffkfggtgesghdtreertddttdenucfhrhhomheptehlhihsshgrucft ohhsshcuoehhihesrghlhihsshgrrdhisheqnecuggftrfgrthhtvghrnhepvdeuvdeivd ehhfeikedtvddvhefgheffleevueeigffgtdffffeujedujeejkeejnecuvehluhhsthgv rhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhephhhisegrlhihshhsrgdrih hspdhnsggprhgtphhtthhopedvpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopegu vghmihhosggvnhhouhhrsehgmhgrihhlrdgtohhmpdhrtghpthhtohepuggvvhgvlhessh hpvggtthhruhhmqdhoshdrohhrgh X-ME-Proxy: Feedback-ID: i12284293:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 31 Aug 2025 07:02:00 -0400 (EDT) Received: by mbp.qyliss.net (Postfix, from userid 1000) id 92CF8150FA9A; Sun, 31 Aug 2025 13:01:49 +0200 (CEST) From: Alyssa Ross To: Demi Marie Obenour , Spectrum OS Development Subject: Re: 'make clean' followed by 'make' in the same Nix shell doesn't work In-Reply-To: <2d817673-7b5a-425b-9b81-38b7ac9e0edc@gmail.com> References: <5d8998cb-0280-452a-8c98-959f472f3ddc@gmail.com> <87frefdvng.fsf@alyssa.is> <35c65948-8987-4367-9b65-5022c297f3f3@gmail.com> <87bjottvfz.fsf@alyssa.is> <2d817673-7b5a-425b-9b81-38b7ac9e0edc@gmail.com> Date: Sun, 31 Aug 2025 13:01:48 +0200 Message-ID: <87zfbfyctf.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Message-ID-Hash: UVSNEBSHBEJUOW43LW45LAUQF27KYDZO X-Message-ID-Hash: UVSNEBSHBEJUOW43LW45LAUQF27KYDZO X-MailFrom: hi@alyssa.is X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Demi Marie Obenour writes: > On 8/5/25 15:33, Alyssa Ross wrote: >> Demi Marie Obenour writes: >>=20 >>> On 7/29/25 08:33, Alyssa Ross wrote: >>>> Demi Marie Obenour writes: >>>> >>>>> The following command fails to rebuild the image: >>>>> >>>>> $ nix-shell --run 'make clean && make run-qemu' >>>>> >>>>> The following command succeeds: >>>>> >>>>> $ nix-shell --pure --run 'make clean' && nix-shell --pure --run 'make= run-qemu' >>>>> >>>>> Interactive Nix shells exhibit the same problems, and adding >>>>> --pure to the first invocation does not help. >>>> >>>> Works for me on 560fd87 in img/app. What were you testing? Logs? >>> >>> I think the problem only arises when there is a dependency that >>> default.nix knows about but the makefile doesn't. nix-shell >>> appears to import default.nix directly, so >>> >>> $ nix-build default.nix >>> >>> inside a Nix shell does not update various paths (like the path >>> to the kernel) that the makefile needs. >>> >>> I think it would be better for the makefile to import the >>> variables from Nix if possible. >>=20 >> Yeah, that's not how it works. You need to exit and re-enter the shell. >> nix-build will not update your shell environment, and that's where Make >> variables come from. > > Ack. I think it is best to recommend (perhaps in the docs?) that one run > `nix-shell --pure --run 'make THINGS'`, which avoids all of these problem= s. > Providing a that did that would be ideal and should be fairly straightfor= ward. > Using an interactive shell can be an optimization, but it can also result= in > silently broken builds for at least the reason you mentioned, so I think = it > is best to discourage it except in the repository root. From=20what I can tell, that's already the case in the documentation, with the exception of the one about Jekyll, which I'll fix. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRV/neXydHjZma5XLJbRZGEIw/wogUCaLQrnAAKCRBbRZGEIw/w osBPAQDXtfOPr5kVNqIX0FiKnPiuId13ztBtU6DfrMksdmhRZAD+NnfoSQGFi0cl sdLVdWp/uJcI2Xg7lBzOPsAVUdrvdgg= =JlLH -----END PGP SIGNATURE----- --=-=-=--