From: Alyssa Ross <hi@alyssa.is>
To: Dom Rodriguez <shymega@shymega.org.uk>
Cc: devel@spectrum-os.org
Subject: Re: [PATCH v1] crosvm: Rename `--vhost-user-gpu` flag in checks
Date: Mon, 11 Nov 2024 11:46:57 +0100 [thread overview]
Message-ID: <87zfm6caji.fsf@alyssa.is> (raw)
In-Reply-To: <20241111012846.3137729-1-shymega@shymega.org.uk>
[-- Attachment #1: Type: text/plain, Size: 1014 bytes --]
Dom Rodriguez <shymega@shymega.org.uk> writes:
> Following on from c9052a4, Alyssa quite rightly pointed out the
> remaining `--vhost-user-gpu` invocation in the release checks (Wayland).
>
> Same principle as c9052a4, just one more replacement to the crosvm flag.
>
> Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk>
> ---
> release/checks/wayland/default.nix | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks!
I had to edit the commit message a bit, because c9052a4 is not a commit
I have — I'm guessing it was your local version? The hash will change
when I apply a patch because the committer will change, trailers will be
added, etc.
While I was there I also changed the subject to conform to the normal
Spectrum convention of prefixing commits with the name of the component
they're changing ("release/checks/wayland" in this case), which I forgot
about on the last one. :) (For single commits that make changes across
the tree, I just don't use a prefix.)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]
next prev parent reply other threads:[~2024-11-11 10:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-11 1:28 [PATCH v1] crosvm: Rename `--vhost-user-gpu` flag in checks Dom Rodriguez
2024-11-11 10:42 ` Alyssa Ross
2024-11-11 10:46 ` Alyssa Ross [this message]
2024-11-12 22:19 ` Dom Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zfm6caji.fsf@alyssa.is \
--to=hi@alyssa.is \
--cc=devel@spectrum-os.org \
--cc=shymega@shymega.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://spectrum-os.org/git/crosvm
https://spectrum-os.org/git/doc
https://spectrum-os.org/git/mktuntap
https://spectrum-os.org/git/nixpkgs
https://spectrum-os.org/git/spectrum
https://spectrum-os.org/git/ucspi-vsock
https://spectrum-os.org/git/www
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).