From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-4.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.6 Received: by atuin.qyliss.net (Postfix, from userid 496) id 6BEBE331CA; Thu, 12 Aug 2021 09:24:28 +0000 (UTC) Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 702AA33208; Thu, 12 Aug 2021 09:24:12 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 496) id 6BD4B33200; Thu, 12 Aug 2021 09:24:10 +0000 (UTC) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by atuin.qyliss.net (Postfix) with ESMTPS id 946A03317F for ; Thu, 12 Aug 2021 09:24:05 +0000 (UTC) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id EFD213200931; Thu, 12 Aug 2021 05:24:03 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 12 Aug 2021 05:24:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm3; bh=vgCcZGf1exgbPs+cEvAkvWLPXl tPSHPtkZvM+54R8Cc=; b=JfgpARRzpAeBG9yzi3dsDC60FnQvIX+Q7j38pttdJT 3fFepFiK67CW+S11D4RQ4mEE1pDDLGOR5gphITd5DYk6H55G1ngBsjA5SSJHhhuh PpLnLHyPySuzwbx5Ym2ELR3dsxDkx4PfGO6sCO0p83MSdfsFOursSQTGu3Mh8jsB /Hy06o/vp7ePxVgd6tdbVDCAnP481I7vMmMc+H6pPhQNU8m7P26ixSR6ckGxRWiH ZQoInnL6KY7NkyhU+9R6R5BFOFZWvO44FTESGPCJDdlAXN/VfAZEQVs9Qh/NUMkF 3gy0n0ZRZ5FXrqPsmZKUB0cKKDDgIokOG7BJcKkvsNgg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=vgCcZG f1exgbPs+cEvAkvWLPXltPSHPtkZvM+54R8Cc=; b=Cm0x/V+XU2DikA5F3aoxQc kl5ncT8/uCjArvB9YsA8BBhIXUxgI6No/0P9+DHhzbxBoHmxhw2yFq5bBlXY8g5q N+ISgE1E3G8hdnL1EOk0PPanW7UG1MynUDoef287UdxL9Cyrk9ncnNtEG/142WyI cc7fRDIxpjzR9UNIlPdxTS5hGQOs0Nkv30jkCGEpM8+RjJcf2MUC+TVp4x30HHdt +F2PP4UgfCywKwUAaHyDFG6yQLOEgFIVhCw/tRyoLCb5/jt/EoHFi9xYXE9tTFTg itqp6vg1tgFzSfmdWpwXe4K1yn/HsUeP+AT5Am+0chuNyCTyh05Oxq9qcah3dMsw == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrkeefgddufecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvufgjfhffkfggtgesghdtreertd dttdenucfhrhhomheptehlhihsshgrucftohhsshcuoehhihesrghlhihsshgrrdhisheq necuggftrfgrthhtvghrnhepvdeuvdeivdehhfeikedtvddvhefgheffleevueeigffgtd ffffeujedujeejkeejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghi lhhfrhhomhephhhisegrlhihshhsrgdrihhs X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 12 Aug 2021 05:24:01 -0400 (EDT) Received: by x220.qyliss.net (Postfix, from userid 1000) id 5476AB60; Thu, 12 Aug 2021 09:23:59 +0000 (UTC) From: Alyssa Ross To: sternenseemann Subject: Re: [PATCH nixpkgs] spectrumPackages: update execline backtick uses In-Reply-To: References: <20210808170439.1372425-1-hi@alyssa.is> Date: Thu, 12 Aug 2021 09:23:55 +0000 Message-ID: <87zgtnm2xg.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Message-ID-Hash: 33OMWEZXFC67VAITWDK3KSZ6HJYLYY66 X-Message-ID-Hash: 33OMWEZXFC67VAITWDK3KSZ6HJYLYY66 X-MailFrom: hi@alyssa.is X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: devel@spectrum-os.org X-Mailman-Version: 3.3.4 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable sternenseemann writes: > On 8/8/21 7:04 PM, Alyssa Ross wrote: >> execline 2.8.0.0 changed how backtick's options work: >>=20 >> * -i (exit with the program's error code on failure) and -n (chomp off >> a trailing newline from the captured output) are now the defaults. >> * -E has been introduced, which does importas automatically. >>=20 >> -E is fantastic, because we followed every single use of backtick with >> importas. >>=20 >> Even we didn't have -n before, it's okay that chomping will now be >> enabled from the default, because in all those cases, there won't be a >> trailing newline anyway. >> --- >> .../linux/spectrum/testhost/default.nix | 14 ++++---------- >> pkgs/os-specific/linux/spectrum/vm/app/default.nix | 3 +-- >> pkgs/os-specific/linux/spectrum/vm/net/default.nix | 6 ++---- >> 3 files changed, 7 insertions(+), 16 deletions(-) >>=20 >> base-commit: d2e147bedf251976ed99b94b6c905d6761f7a892 >> -- >> 2.32.0 > > Looks good and quite straightforward. All substitutions seem correct. > > Reviewed-by: sterni Thanks so much for the review! Committed as 769e648d243223613d008276bcac18a164302ba8. :) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEH9wgcxqlHM/ARR3h+dvtSFmyccAFAmEU6K0ACgkQ+dvtSFmy ccAvHQ/+JryusVNTMl0EDMDF4kCWRmSeBEndsxrSfnDwA2W4lsCUI4Km/1iGu+S4 W/KjTqtl+zNcdOtFVwJqgiJIcd4kwologaMTMZPt8nkJsOORkLTaD1DUjqFeC56c 8QFZKFOpNMmK9tdHhQ2YpWxRzCs6qPYhevkqmLApQr3FbgqJ1POAkET4SGWAF45y PtrUMg1KZbW7ekNwpvtVGzYsbBZBuYVQ93dp57BsCJbheNiQrzq1jMXC2nPyJCsc Wp1/Xd9P/zt5pyAumkRCQ0anE4rga9ZTMoSE32O/Xa3p0zTSUSD4qLsZQYIFOU01 BImCx52aw/nmzOL8v+6AukhZcH/y+VLbn5tVdXYvfZ7QPO11oygP6tfbE0yAGb2M Tay68WV/p+8S1lKZXALQPHh5Gp/IGnYMkz5Y+m1EeoKVZxHV66Cp3F7tvwOTd3M8 RWhZLhFJhGLeVjEA+nXk0CcR388YDJW0b9/vBBbSCZXk+RtCvFn+qyfBeH3ooLu6 8tSMRXH+ugemAfG8bP0QWQ4r58GtE4HxfuU17UyvSzhnnfSgbL1RIz85sa8Ljuia GKBXIWb9XFTPT4+K7+NVzwgN8Y8Q3sdNO4AacUo2+XbPNe6uQxhN2mUJwW1YNmns bDmDTwqsiPXU21QFb3CcRxUkSFrCWIwe+sfcwypbtLKQOsQn/gY= =7gWx -----END PGP SIGNATURE----- --=-=-=--