Re: [PATCH] host/rootfs: create groups assumed by udev

[Demi Marie Obenour <demiobenour@gmail.com>]

[-- Attachment #1.1.1: Type: text/plain, Size: 1365 bytes --]

On 12/4/25 10:04, Alyssa Ross wrote:
> We don't really care about these groups, but if they don't exist, udev
> will also not apply the "other" modes from rules, leaving
> e.g. /dev/kvm root-only when it should be globally read/write.
> 
> tty is set to 5, conforming with the systemd convention.
> 
> Link: https://systemd.io/UIDS-GIDS/
> Signed-off-by: Alyssa Ross <hi@alyssa.is>
> ---
> Demi, this should avoid the need to add a udev rule for /dev/kvm.
> 
>  host/rootfs/image/etc/group | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/host/rootfs/image/etc/group b/host/rootfs/image/etc/group
> index 18acc30..e3ade46 100644
> --- a/host/rootfs/image/etc/group
> +++ b/host/rootfs/image/etc/group
> @@ -1 +1,15 @@
>  root:x:0:root
> +clock:x:1:
> +dialout:x:2:
> +kmem:x:3:
> +input:x:4:
> +tty:x:5:
> +video:x:6:
> +render:x:7:
> +sgx:x:8:

Do we even need this?  SGX needs userspace tools that Spectrum
doesn't have.  I presume that the need for this will go away once
Spectrum's host is built without SGX.

> +audio:x:9:
> +lp:x:10:
> +disk:x:11:
> +cdrom:x:12:
> +tape:x:13:
> +kvm:x:14:
> 
> base-commit: a13d3403c1ddbb8dbbbdb05416350b2846162ed1

With or without the above change:

Acked-by: Demi Marie Obenour <demiobenour@gmail.com>
-- 
Sincerely,
Demi Marie Obenour (she/her/hers)

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 7253 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]