From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 995BA87E0; Sat, 25 Jul 2026 06:11:23 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id B65AA881C; Sat, 25 Jul 2026 06:11:21 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-0.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DMARC_PASS,FREEMAIL_FROM,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=4.0.1 Received: from mail-yx1-xb12f.google.com (mail-yx1-xb12f.google.com [IPv6:2607:f8b0:4864:20::b12f]) by atuin.qyliss.net (Postfix) with ESMTPS id 87BF4881A for ; Sat, 25 Jul 2026 06:11:20 +0000 (UTC) Received: by mail-yx1-xb12f.google.com with SMTP id 956f58d0204a3-664e3ed58bcso2032410d50.1 for ; Fri, 24 Jul 2026 23:11:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784959874; x=1785564674; darn=spectrum-os.org; h=content-type:autocrypt:in-reply-to:content-language:references:cc :to:subject:from:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to:content-type; bh=2o1Ea/xp0jeOgqgExmNIv3HjDbgeAXd/zSeQupHQTaY=; b=LmoPkjL2MtZx1n+C6/YOCD6l5/Oiv1f4usfQvoZFZmUAxtlnQtegPnfStzcL9Rlo8g SCZS8sUG6AscG50nhva0Xr9l0CxEAuy5MRrT1UGX/FYD3yS8G9Ly9w7eX6RAioRmb8jT pMmiFYgWHalZNXbHR0FQzauyGLM8KrDhxgvYVad7MFNdmIl9kk2xltdRSYgGI3a0DTeW uzhgTrBUQ/ngttknawH2nuFW6MR+Wl9sSBGrx7+qiIQO26fRfvRU9+D37qmV3gq7/Fr4 jZY/1DJCHBi+OcDMtio+0L5BpwQiP3FId6yQdNV0sEekghLTgIHx3m0xz0i+EweodQ5N SOXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784959874; x=1785564674; h=content-type:autocrypt:in-reply-to:content-language:references:cc :to:subject:from:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=2o1Ea/xp0jeOgqgExmNIv3HjDbgeAXd/zSeQupHQTaY=; b=RlvdoTlvA8sGepklDVcVTOVZh0EHvOa2Hq+ekZIq6erYdfl4pqvJEePKWCxPZghJjb DbcbgVbBTofEIGsEzxJVV28HtMaIXiSmcSHQFNxPBWN0ko4kSKyF3+J+cc+6IGq/R4s6 B5WoFPX+fPrJpQnMFwQPyPQI2Wd7JPccXlGf7a6lGH+EmlSFV64TIGZ4dhCX1xYnVaXR udVb8vTLqSP+buRP/j9+n0Z1ppEubwlBTMDPQfRy27PasjtM/OZ98B2d7NGvow/HOpGe ChAF/7zS6YBY4ghw2sETRuRbRF2lUnjIBngsXwMWa8vpuQ2oZeu+3sVr0pD/3bME0HAT DyiQ== X-Gm-Message-State: AOJu0YyYn/UPEr6eLTEFnW6lmt4VRcwuGVkrWOCbFbX8bYlfZdQzJGKK 8RnwrCGJc/vBG4/CKzBbG9UKFu5FK38XU4O+0X3wjHnREGoKoZlvtcSc X-Gm-Gg: AR+sD10WodFbSIii8/IweoN/FmkyMthQr2jozGueLKs8fegMbMH629YlyfGLF2q4WKO UN3SjxHevs2J1lvIrx3gWXAjE7i9zVwIDzYcqJFukaCNFU/BLzs6wnrwMd/zQLeZqONq1KPbJGS ygJShOQkZynyD4UJqitNg4REIQLn3q2w2Ufvw5hva69Jr/giC/tRBAZ1TvAzMuPw55xu4qOjfnE whkebAygDPHTbPzBwz4CLnU7TO3o/qJTI2/Iw7b8iFm7Hlf2ucMqONKopQnZ0Q1IZYBYckZBzs3 nKRZQryXFPkPMJkjlByMOz2MhHSRxQWyTwSKlnRXpYPl5ezVGQ9ey68hlZ192ykDVbF3VZiU2v+ csCLk1+Pa018qx4QK2v7QHzFTHFvWpZTguNgxei3UOh4yAUSx5eyF/IINCDgwuwuFqT8+in9lXi RV7LHz X-Received: by 2002:a53:e319:0:b0:667:538a:ddeb with SMTP id 956f58d0204a3-668c7b7c534mr246107d50.31.1784959873995; Fri, 24 Jul 2026 23:11:13 -0700 (PDT) Received: from [10.138.10.6] ([185.98.168.14]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-668c6d3024dsm472450d50.4.2026.07.24.23.11.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Jul 2026 23:11:11 -0700 (PDT) Message-ID: <92ab45ab-a124-4edc-b5ea-d35621ce0e53@gmail.com> Date: Sat, 25 Jul 2026 02:11:07 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Demi Marie Obenour Subject: Re: Potential improvements to mount-flatpak To: Alyssa Ross References: <1bebc170-25cc-4c25-8b93-eef50e0e2685@gmail.com> <87zezjtp46.fsf@alyssa.is> Content-Language: en-US In-Reply-To: <87zezjtp46.fsf@alyssa.is> Autocrypt: addr=demiobenour@gmail.com; keydata= xsFNBFp+A0oBEADffj6anl9/BHhUSxGTICeVl2tob7hPDdhHNgPR4C8xlYt5q49yB+l2nipd aq+4Gk6FZfqC825TKl7eRpUjMriwle4r3R0ydSIGcy4M6eb0IcxmuPYfbWpr/si88QKgyGSV Z7GeNW1UnzTdhYHuFlk8dBSmB1fzhEYEk0RcJqg4AKoq6/3/UorR+FaSuVwT7rqzGrTlscnT DlPWgRzrQ3jssesI7sZLm82E3pJSgaUoCdCOlL7MMPCJwI8JpPlBedRpe9tfVyfu3euTPLPx wcV3L/cfWPGSL4PofBtB8NUU6QwYiQ9Hzx4xOyn67zW73/G0Q2vPPRst8LBDqlxLjbtx/WLR 6h3nBc3eyuZ+q62HS1pJ5EvUT1vjyJ1ySrqtUXWQ4XlZyoEFUfpJxJoN0A9HCxmHGVckzTRl 5FMWo8TCniHynNXsBtDQbabt7aNEOaAJdE7to0AH3T/Bvwzcp0ZJtBk0EM6YeMLtotUut7h2 Bkg1b//r6bTBswMBXVJ5H44Qf0+eKeUg7whSC9qpYOzzrm7+0r9F5u3qF8ZTx55TJc2g656C 9a1P1MYVysLvkLvS4H+crmxA/i08Tc1h+x9RRvqba4lSzZ6/Tmt60DPM5Sc4R0nSm9BBff0N m0bSNRS8InXdO1Aq3362QKX2NOwcL5YaStwODNyZUqF7izjK4QARAQABzTxEZW1pIE1hcmll IE9iZW5vdXIgKGxvdmVyIG9mIGNvZGluZykgPGRlbWlvYmVub3VyQGdtYWlsLmNvbT7CwXgE EwECACIFAlp+A0oCGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJELKItV//nCLBhr8Q AK/xrb4wyi71xII2hkFBpT59ObLN+32FQT7R3lbZRjVFjc6yMUjOb1H/hJVxx+yo5gsSj5LS 9AwggioUSrcUKldfA/PKKai2mzTlUDxTcF3vKx6iMXKA6AqwAw4B57ZEJoMM6egm57TV19kz PMc879NV2nc6+elaKl+/kbVeD3qvBuEwsTe2Do3HAAdrfUG/j9erwIk6gha/Hp9yZlCnPTX+ VK+xifQqt8RtMqS5R/S8z0msJMI/ajNU03kFjOpqrYziv6OZLJ5cuKb3bZU5aoaRQRDzkFIR 6aqtFLTohTo20QywXwRa39uFaOT/0YMpNyel0kdOszFOykTEGI2u+kja35g9TkH90kkBTG+a EWttIht0Hy6YFmwjcAxisSakBuHnHuMSOiyRQLu43ej2+mDWgItLZ48Mu0C3IG1seeQDjEYP tqvyZ6bGkf2Vj+L6wLoLLIhRZxQOedqArIk/Sb2SzQYuxN44IDRt+3ZcDqsPppoKcxSyd1Ny 2tpvjYJXlfKmOYLhTWs8nwlAlSHX/c/jz/ywwf7eSvGknToo1Y0VpRtoxMaKW1nvH0OeCSVJ itfRP7YbiRVc2aNqWPCSgtqHAuVraBRbAFLKh9d2rKFB3BmynTUpc1BQLJP8+D5oNyb8Ts4x Xd3iV/uD8JLGJfYZIR7oGWFLP4uZ3tkneDfYzsFNBFp+A0oBEAC9ynZI9LU+uJkMeEJeJyQ/ 8VFkCJQPQZEsIGzOTlPnwvVna0AS86n2Z+rK7R/usYs5iJCZ55/JISWd8xD57ue0eB47bcJv VqGlObI2DEG8TwaW0O0duRhDgzMEL4t1KdRAepIESBEA/iPpI4gfUbVEIEQuqdqQyO4GAe+M kD0Hy5JH/0qgFmbaSegNTdQg5iqYjRZ3ttiswalql1/iSyv1WYeC1OAs+2BLOAT2NEggSiVO txEfgewsQtCWi8H1SoirakIfo45Hz0tk/Ad9ZWh2PvOGt97Ka85o4TLJxgJJqGEnqcFUZnJJ riwoaRIS8N2C8/nEM53jb1sH0gYddMU3QxY7dYNLIUrRKQeNkF30dK7V6JRH7pleRlf+wQcN fRAIUrNlatj9TxwivQrKnC9aIFFHEy/0mAgtrQShcMRmMgVlRoOA5B8RTulRLCmkafvwuhs6 dCxN0GNAORIVVFxjx9Vn7OqYPgwiofZ6SbEl0hgPyWBQvE85klFLZLoj7p+joDY1XNQztmfA rnJ9x+YV4igjWImINAZSlmEcYtd+xy3Li/8oeYDAqrsnrOjb+WvGhCykJk4urBog2LNtcyCj kTs7F+WeXGUo0NDhbd3Z6AyFfqeF7uJ3D5hlpX2nI9no/ugPrrTVoVZAgrrnNz0iZG2DVx46 x913pVKHl5mlYQARAQABwsFfBBgBAgAJBQJafgNKAhsMAAoJELKItV//nCLBwNIP/AiIHE8b oIqReFQyaMzxq6lE4YZCZNj65B/nkDOvodSiwfwjjVVE2V3iEzxMHbgyTCGA67+Bo/d5aQGj gn0TPtsGzelyQHipaUzEyrsceUGWYoKXYyVWKEfyh0cDfnd9diAm3VeNqchtcMpoehETH8fr RHnJdBcjf112PzQSdKC6kqU0Q196c4Vp5HDOQfNiDnTf7gZSj0BraHOByy9LEDCLhQiCmr+2 E0rW4tBtDAn2HkT9uf32ZGqJCn1O+2uVfFhGu6vPE5qkqrbSE8TG+03H8ecU2q50zgHWPdHM OBvy3EhzfAh2VmOSTcRK+tSUe/u3wdLRDPwv/DTzGI36Kgky9MsDC5gpIwNbOJP2G/q1wT1o Gkw4IXfWv2ufWiXqJ+k7HEi2N1sree7Dy9KBCqb+ca1vFhYPDJfhP75I/VnzHVssZ/rYZ9+5 1yDoUABoNdJNSGUYl+Yh9Pw9pE3Kt4EFzUlFZWbE4xKL/NPno+z4J9aWemLLszcYz/u3XnbO vUSQHSrmfOzX3cV4yfmjM5lewgSstoxGyTx2M8enslgdXhPthZlDnTnOT+C+OTsh8+m5tos8 HQjaPM01MKBiAqdPgksm1wu2DrrwUi6ChRVTUBcj6+/9IJ81H2P2gJk3Ls3AVIxIffLoY34E +MYSfkEjBz0E8CLOcAw7JIwAaeBT Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------0jJAxZdynGVorARTUo0KRIJk" Message-ID-Hash: DMG3X4DYUAX2PLOQ4P7EUGKKKZHBXRIF X-Message-ID-Hash: DMG3X4DYUAX2PLOQ4P7EUGKKKZHBXRIF X-MailFrom: demiobenour@gmail.com X-Mailman-Rule-Hits: member-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; emergency CC: Spectrum OS Development X-Mailman-Version: 3.3.10 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------0jJAxZdynGVorARTUo0KRIJk Content-Type: multipart/mixed; boundary="------------h1R4wdXbRDNEGtib091nDqEi"; protected-headers="v1"; hp="clear" Message-ID: <92ab45ab-a124-4edc-b5ea-d35621ce0e53@gmail.com> Date: Sat, 25 Jul 2026 02:11:07 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Demi Marie Obenour Subject: Re: Potential improvements to mount-flatpak To: Alyssa Ross Cc: Spectrum OS Development References: <1bebc170-25cc-4c25-8b93-eef50e0e2685@gmail.com> <87zezjtp46.fsf@alyssa.is> Content-Language: en-US In-Reply-To: <87zezjtp46.fsf@alyssa.is> Autocrypt: addr=demiobenour@gmail.com; keydata= xsFNBFp+A0oBEADffj6anl9/BHhUSxGTICeVl2tob7hPDdhHNgPR4C8xlYt5q49yB+l2nipd aq+4Gk6FZfqC825TKl7eRpUjMriwle4r3R0ydSIGcy4M6eb0IcxmuPYfbWpr/si88QKgyGSV Z7GeNW1UnzTdhYHuFlk8dBSmB1fzhEYEk0RcJqg4AKoq6/3/UorR+FaSuVwT7rqzGrTlscnT DlPWgRzrQ3jssesI7sZLm82E3pJSgaUoCdCOlL7MMPCJwI8JpPlBedRpe9tfVyfu3euTPLPx wcV3L/cfWPGSL4PofBtB8NUU6QwYiQ9Hzx4xOyn67zW73/G0Q2vPPRst8LBDqlxLjbtx/WLR 6h3nBc3eyuZ+q62HS1pJ5EvUT1vjyJ1ySrqtUXWQ4XlZyoEFUfpJxJoN0A9HCxmHGVckzTRl 5FMWo8TCniHynNXsBtDQbabt7aNEOaAJdE7to0AH3T/Bvwzcp0ZJtBk0EM6YeMLtotUut7h2 Bkg1b//r6bTBswMBXVJ5H44Qf0+eKeUg7whSC9qpYOzzrm7+0r9F5u3qF8ZTx55TJc2g656C 9a1P1MYVysLvkLvS4H+crmxA/i08Tc1h+x9RRvqba4lSzZ6/Tmt60DPM5Sc4R0nSm9BBff0N m0bSNRS8InXdO1Aq3362QKX2NOwcL5YaStwODNyZUqF7izjK4QARAQABzTxEZW1pIE1hcmll IE9iZW5vdXIgKGxvdmVyIG9mIGNvZGluZykgPGRlbWlvYmVub3VyQGdtYWlsLmNvbT7CwXgE EwECACIFAlp+A0oCGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJELKItV//nCLBhr8Q AK/xrb4wyi71xII2hkFBpT59ObLN+32FQT7R3lbZRjVFjc6yMUjOb1H/hJVxx+yo5gsSj5LS 9AwggioUSrcUKldfA/PKKai2mzTlUDxTcF3vKx6iMXKA6AqwAw4B57ZEJoMM6egm57TV19kz PMc879NV2nc6+elaKl+/kbVeD3qvBuEwsTe2Do3HAAdrfUG/j9erwIk6gha/Hp9yZlCnPTX+ VK+xifQqt8RtMqS5R/S8z0msJMI/ajNU03kFjOpqrYziv6OZLJ5cuKb3bZU5aoaRQRDzkFIR 6aqtFLTohTo20QywXwRa39uFaOT/0YMpNyel0kdOszFOykTEGI2u+kja35g9TkH90kkBTG+a EWttIht0Hy6YFmwjcAxisSakBuHnHuMSOiyRQLu43ej2+mDWgItLZ48Mu0C3IG1seeQDjEYP tqvyZ6bGkf2Vj+L6wLoLLIhRZxQOedqArIk/Sb2SzQYuxN44IDRt+3ZcDqsPppoKcxSyd1Ny 2tpvjYJXlfKmOYLhTWs8nwlAlSHX/c/jz/ywwf7eSvGknToo1Y0VpRtoxMaKW1nvH0OeCSVJ itfRP7YbiRVc2aNqWPCSgtqHAuVraBRbAFLKh9d2rKFB3BmynTUpc1BQLJP8+D5oNyb8Ts4x Xd3iV/uD8JLGJfYZIR7oGWFLP4uZ3tkneDfYzsFNBFp+A0oBEAC9ynZI9LU+uJkMeEJeJyQ/ 8VFkCJQPQZEsIGzOTlPnwvVna0AS86n2Z+rK7R/usYs5iJCZ55/JISWd8xD57ue0eB47bcJv VqGlObI2DEG8TwaW0O0duRhDgzMEL4t1KdRAepIESBEA/iPpI4gfUbVEIEQuqdqQyO4GAe+M kD0Hy5JH/0qgFmbaSegNTdQg5iqYjRZ3ttiswalql1/iSyv1WYeC1OAs+2BLOAT2NEggSiVO txEfgewsQtCWi8H1SoirakIfo45Hz0tk/Ad9ZWh2PvOGt97Ka85o4TLJxgJJqGEnqcFUZnJJ riwoaRIS8N2C8/nEM53jb1sH0gYddMU3QxY7dYNLIUrRKQeNkF30dK7V6JRH7pleRlf+wQcN fRAIUrNlatj9TxwivQrKnC9aIFFHEy/0mAgtrQShcMRmMgVlRoOA5B8RTulRLCmkafvwuhs6 dCxN0GNAORIVVFxjx9Vn7OqYPgwiofZ6SbEl0hgPyWBQvE85klFLZLoj7p+joDY1XNQztmfA rnJ9x+YV4igjWImINAZSlmEcYtd+xy3Li/8oeYDAqrsnrOjb+WvGhCykJk4urBog2LNtcyCj kTs7F+WeXGUo0NDhbd3Z6AyFfqeF7uJ3D5hlpX2nI9no/ugPrrTVoVZAgrrnNz0iZG2DVx46 x913pVKHl5mlYQARAQABwsFfBBgBAgAJBQJafgNKAhsMAAoJELKItV//nCLBwNIP/AiIHE8b oIqReFQyaMzxq6lE4YZCZNj65B/nkDOvodSiwfwjjVVE2V3iEzxMHbgyTCGA67+Bo/d5aQGj gn0TPtsGzelyQHipaUzEyrsceUGWYoKXYyVWKEfyh0cDfnd9diAm3VeNqchtcMpoehETH8fr RHnJdBcjf112PzQSdKC6kqU0Q196c4Vp5HDOQfNiDnTf7gZSj0BraHOByy9LEDCLhQiCmr+2 E0rW4tBtDAn2HkT9uf32ZGqJCn1O+2uVfFhGu6vPE5qkqrbSE8TG+03H8ecU2q50zgHWPdHM OBvy3EhzfAh2VmOSTcRK+tSUe/u3wdLRDPwv/DTzGI36Kgky9MsDC5gpIwNbOJP2G/q1wT1o Gkw4IXfWv2ufWiXqJ+k7HEi2N1sree7Dy9KBCqb+ca1vFhYPDJfhP75I/VnzHVssZ/rYZ9+5 1yDoUABoNdJNSGUYl+Yh9Pw9pE3Kt4EFzUlFZWbE4xKL/NPno+z4J9aWemLLszcYz/u3XnbO vUSQHSrmfOzX3cV4yfmjM5lewgSstoxGyTx2M8enslgdXhPthZlDnTnOT+C+OTsh8+m5tos8 HQjaPM01MKBiAqdPgksm1wu2DrrwUi6ChRVTUBcj6+/9IJ81H2P2gJk3Ls3AVIxIffLoY34E +MYSfkEjBz0E8CLOcAw7JIwAaeBT --------------h1R4wdXbRDNEGtib091nDqEi Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 7/22/26 04:17, Alyssa Ross wrote: > Demi Marie Obenour writes: >=20 >> I looked at the mount-flatpak codebase and noticed some potential >> improvements for the future: >> >> - The code uses std::fs::write to write to files in the target >> directory. This is safe because the VM isn't running, but it might >> be better to use libpathrs. >=20 > I think it's fine. Makes sense. >> - The code doesn't validate the user-provided app ID, resulting in >> worse error messages than otherwise possible. App IDs are always >> D-Bus well-known names, so there is no risk of the rules changing >> in future versions of Flatpak. >=20 > Even though Flatpak 2 won't use D-Bus? I think I forgot that. Is there a document with the list of Flatpak 2 changes anywhere? >> - Passing something that isn't a flatpak repository as a parameter >> will result in a confusing "no such file or directory" error. >=20 > Could check that if it's cheap, since this is user-facing. I would not= > spend much time on it though, since ultimately this should not be the > interface people use. Makes sense. >> - Various checks for corrupt repositories could be added, such as: >> - Wrong number of slashes in "current" symlink. >> - Wrong number of slashes in runtime path. >> - Bad "active" symlink. >=20 > I'm not sure I see the value? Does normal Flatpak do these checks? > I don't think we need to check everything that could possibly go wrong > if it wouldn't be a security concern. I don't see any reason either. There is a trick one can do to improve worst-case runtime, and that is to not use RESOLVE_BENEATH or RESOLVE_IN_ROOT. Instead, one uses RESOLVE_NO_SYMLINKS | RESOLVE_NO_MAGICLINKS and checks that the path has no ".." components and is not absolute. My understanding is that RESOLVE_BENEATH and RESOLVE_IN_ROOT require heavyweight kernel-side checks to guard against race conditions, and these can produce false positives. The other approach doesn't require these checks and so is more reliable. libpathrs resolves this with an ugly retry loop. It's up to you whether this change is worth making. >> - The code that resolves the "active" symlink is duplicated. >=20 > I think there's already a patch sitting at the bottom of my inbox for > you from this. >=20 >> - The target mount point is not made "noexec". >=20 > Sounds like a good improvement. Yup, although all of this is in a separate mount namespace and I think only virtiofsd runs in that namespace. >> - mount_setattr() is called on a directory FD. I suspect this >> changes parameters of the source mount. It might be better to use >> open_tree_attr() with OPEN_TREE_CLONE instead. >=20 > Well, does it change the source mount or doesn't it? If there's a bug,= > fix it; if there isn't, don't. (I do think you are probably right thou= gh.) There's no actual bug. It was opened with open_tree() with OPEN_TREE_CLO= NE. --=20 Sincerely, Demi Marie Obenour (she/her/hers) --------------h1R4wdXbRDNEGtib091nDqEi-- --------------0jJAxZdynGVorARTUo0KRIJk Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEopQtqVJW1aeuo9/sszaHOrMp8lMFAmpkU3wACgkQszaHOrMp 8lMqdg//VPStDeCy2ppumg6ZZwqVNFq5JrufSOEn+qryzZqnEB3FHJN9jCuEfv0O qPA0wW1as5bBrJigBpC0+sjYZiD0N+wo1SpEp+yNrauHu/4ipdlpngUR/6w/WDZ5 ki2lQtBxlnqHeWqhzLQ7FiYQyH+ANpW6Mt8IOYtXOWzJ0MQugpx2aEY5vkbgQcNE vTSctNdVubFgxfOoHP3Xm7wrOg1zUwimykv9b26cWrOzQ01ZchzlCY2TuyR333Oz UMPRzlME8lJsnwAWrk0K/TP/Oi1ViHvBuyEi1P4BykAeA02fJ87NXITZzAPYCI4Q Uh/esd7pdPzab1j6DRutKGxUjAARLcefNdNyT5tXX+tG60L6ByBLeSNoNqHwKqMj kIXAfW39VAg/GBw7CkBXtEVHpbKSkYoJVQo1cotCjAL5QqKID8Wtnz9HLHFbhZcV EErzo717LAT1LkOE6dgJ90sEf6n87z2vF8xubIbSoWty7JhWlol+oUbK/2hp42+w 1jtipwr502W9Jzh5zlWiFx3A9J287SrN4hQSVQzd+i/myIzg9lo1EZA8JumDdYh1 dSGuGoNx/oOcSjPWoNWwxn7lOJYZSe3vqypxOWxExP1cjAxPvMFsctsmxM+6Iadf /cKeeH3NASwoDRhxKll6CMd4tHSe+pGub7n9HuM4uL5K1Y5lHKo= =WlTg -----END PGP SIGNATURE----- --------------0jJAxZdynGVorARTUo0KRIJk--