patches and low-level development discussion
 help / color / mirror / code / Atom feed
From: Demi Marie Obenour <demiobenour@gmail.com>
To: Alyssa Ross <hi@alyssa.is>
Cc: Spectrum OS Development <devel@spectrum-os.org>
Subject: Re: [PATCH v6 2/2] Move UKI creation to a separate derivation
Date: Fri, 28 Nov 2025 14:27:09 -0500	[thread overview]
Message-ID: <96bb2025-f0ec-4c0d-af7b-2ddd866c3db0@gmail.com> (raw)
In-Reply-To: <87h5ueph6n.fsf@alyssa.is>


[-- Attachment #1.1.1: Type: text/plain, Size: 1597 bytes --]

On 11/28/25 05:47, Alyssa Ross wrote:
> Demi Marie Obenour <demiobenour@gmail.com> writes:
> 
>> It will be used by the update code later.
>>
>> No functional change intended, other than a trivial shell script
>> refactoring.
>>
>> Signed-off-by: Demi Marie Obenour <demiobenour@gmail.com>
>> ---
>> I kept release/live/default.nix using the UKI's systemd because the old
>> code did it that way.  Changing this would be better in a separate
>> commit.
> 
> Yep, makes sense.
> 
>> Changes since v5:
>>
>> - Create a temporary symlink named build/spectrum.efi and then run
>>   $(MCOPY) -i $@ build/spectrum.efi ::/EFI/Linux, rather than copying
>>   the file with its original name.  The latter results in an unbootable
>>   image.  I do not know the reason.
> 
> If I just mcopy -i $@ $(EFI_IMAGE) ::/EFI/Linux/spectrum.efi (explicitly
> specifying the destination file name), then it works.  It doesn't  is something like
> "/nix/store/3yqb8mfv6skp43yp2r7sn098zrj0hrjf-spectrum-efi".  

I distinctly remember it *not* working for me, but I might have used the wrong
destination name.  Perhaps I used Spectrum.efi (wrong case)?

> This could be avoided by installing EFI_IMAGE to a subdirectory, so the
> file name didn't get a hash prepended to it by Nix.  Happy to just go
> ahead with changing this and applying my style comments from last
> time[1] if you agree.
> 
> [1]: https://spectrum-os.org/lists/archives/spectrum-devel/877bve2skh.fsf@alyssa.is/

That would be great and an even better solution.
-- 
Sincerely,
Demi Marie Obenour (she/her/hers)

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 7253 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2025-11-28 19:27 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-05 22:33 [PATCH 0/2] Move verity and EFI creation to separate Nix derivations Demi Marie Obenour
2025-11-05 22:33 ` [PATCH 1/2] Create Nix derivation for building verity images Demi Marie Obenour
2025-11-06 10:20   ` Alyssa Ross
2025-11-06 10:55     ` Demi Marie Obenour
2025-11-06 11:44       ` Alyssa Ross
2025-11-07 19:24         ` Demi Marie Obenour
2025-11-13 11:32           ` Alyssa Ross
2025-11-05 22:33 ` [PATCH 2/2] Move UKI creation to a separate derivation Demi Marie Obenour
2025-11-08  4:47 ` [PATCH v2 0/2] Move verity and EFI creation to separate Nix derivations Demi Marie Obenour
2025-11-08  4:47   ` [PATCH v2 1/2] Build verity images in rootfs Nix derivation Demi Marie Obenour
2025-11-08  4:47   ` [PATCH v2 2/2] Move UKI creation to a separate derivation Demi Marie Obenour
2025-11-12  0:59   ` [PATCH v3 0/2] Move verity and EFI creation to separate Nix derivations Demi Marie Obenour
2025-11-12  0:59     ` [PATCH v3 1/2] Build verity images in rootfs Nix derivation Demi Marie Obenour
2025-11-13 11:46       ` Alyssa Ross
2025-11-13 22:33         ` Demi Marie Obenour
2025-11-14 11:53           ` Alyssa Ross
2025-11-12  0:59     ` [PATCH v3 2/2] Move UKI creation to a separate derivation Demi Marie Obenour
2025-11-13 11:57       ` Alyssa Ross
2025-11-13 22:42         ` Demi Marie Obenour
2025-11-14 11:58           ` Alyssa Ross
2025-11-19  8:15     ` [PATCH v4 0/2] Move verity and EFI creation to separate Nix derivations Demi Marie Obenour
2025-11-19  8:15       ` [PATCH v4 1/2] Build verity images in rootfs Nix derivation Demi Marie Obenour
2025-11-25 12:27         ` Alyssa Ross
2025-11-25 12:31           ` Alyssa Ross
2025-11-19  8:15       ` [PATCH v4 2/2] Move UKI creation to a separate derivation Demi Marie Obenour
2025-11-22  1:21       ` [PATCH v5 0/2] Move verity and EFI creation to separate Nix derivations Demi Marie Obenour
2025-11-22  1:21         ` [PATCH v5 1/2] Build verity images in rootfs Nix derivation Demi Marie Obenour
2025-11-25 12:34           ` Alyssa Ross
2025-11-22  1:21         ` [PATCH v5 2/2] Move UKI creation to a separate derivation Demi Marie Obenour
2025-11-25 12:41           ` Alyssa Ross
2025-11-26 19:10         ` [PATCH v6 0/2] Move verity and EFI creation to separate Nix derivations Demi Marie Obenour
2025-11-26 19:10           ` [PATCH v6 1/2] Build verity images in rootfs Nix derivation Demi Marie Obenour
2025-11-27 19:23             ` Alyssa Ross
2025-11-26 19:10           ` [PATCH v6 2/2] Move UKI creation to a separate derivation Demi Marie Obenour
2025-11-28 10:47             ` Alyssa Ross
2025-11-28 19:27               ` Demi Marie Obenour [this message]
2025-11-28 11:02             ` Alyssa Ross
2025-11-28 19:25               ` Demi Marie Obenour
2025-11-28 20:12             ` Alyssa Ross
2025-11-26 18:58       ` [PATCH v5 0/2] Move verity and EFI creation to separate Nix derivations Demi Marie Obenour
2025-11-26 18:58         ` [PATCH v5 1/2] Build verity images in rootfs Nix derivation Demi Marie Obenour
2025-11-26 18:58         ` [PATCH v5 2/2] Move UKI creation to a separate derivation Demi Marie Obenour

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=96bb2025-f0ec-4c0d-af7b-2ddd866c3db0@gmail.com \
    --to=demiobenour@gmail.com \
    --cc=devel@spectrum-os.org \
    --cc=hi@alyssa.is \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://spectrum-os.org/git/crosvm
	https://spectrum-os.org/git/doc
	https://spectrum-os.org/git/mktuntap
	https://spectrum-os.org/git/nixpkgs
	https://spectrum-os.org/git/spectrum
	https://spectrum-os.org/git/ucspi-vsock
	https://spectrum-os.org/git/www

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).