From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id E0E4024520; Thu, 05 Jun 2025 14:12:06 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id 7533B24504; Thu, 05 Jun 2025 14:12:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DMARC_PASS,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 Received: from fout-a4-smtp.messagingengine.com (fout-a4-smtp.messagingengine.com [103.168.172.147]) by atuin.qyliss.net (Postfix) with ESMTPS id 11A5724502 for ; Thu, 05 Jun 2025 14:12:01 +0000 (UTC) Received: from phl-compute-03.internal (phl-compute-03.phl.internal [10.202.2.43]) by mailfout.phl.internal (Postfix) with ESMTP id 91CDC13802B4; Thu, 5 Jun 2025 10:11:59 -0400 (EDT) Received: from phl-imap-07 ([10.202.2.97]) by phl-compute-03.internal (MEProxy); Thu, 05 Jun 2025 10:11:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=puckipedia.com; h=cc:cc:content-transfer-encoding:content-type:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:subject:subject:to:to; s=fm2; t=1749132719; x=1749219119; bh=5wVW/LYFVW8vWmBu+2Pkw6+TG5msnhPJ EiUAdUluGOs=; b=KhbdKF+zbTwOLa3umEfgK+5kBUgeVP+FPm8o/tFEfidDYFtJ Mr9Xvbc2BsdO7Zq66QrvtVx3JCWx4Rd8mPOo3rTOnH/87+p4XmTdZjuX95dmIus8 n6iKGFPfQDmVizZ0fs2B5Kb0lLfvGkLxWl/cvGEFae0OJOG7+AquWOQpegxyGidO V6ChxIQbnvjiV9Q0jaE6DOkVeMfzeo4Ibel/jfhJvJW0kma7uM56RAIgIIsxgp2I jOZ7YYV+ETazEK5jUPWEoPN4p9Yw1Jfzums1jStXLY8vh7eKjsdqvDY81ir7dg3/ hb9ProXgPUsxpLoXjLpTrc32wxovrRgsZvHw3Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1749132719; x= 1749219119; bh=5wVW/LYFVW8vWmBu+2Pkw6+TG5msnhPJEiUAdUluGOs=; b=H nLUAjqj3c5aZXQ2E1QWFDtYnldVzJLd5uwMl8/FBCL6WvmlO0inzVGxVSWLwvcXl S1ZNUY426jn2ucJnx7RKUJ1m6cCgx4VNldZwaaYDcIlv4I86Ff9oGrBFTrkLFBBM RXY8t9KrbMOvIn+/d5bgN1JptvqtwZtYnl3q2lOwfoW0ipWWW8JPhUKvzIWfJfy8 9XO3XgaFpEDa7K9JmpvE1b+HIBwwEMTElXOiiu7yw1kaw8AApd3ZPEDWlUjwVlvp Q+WS/cyqajlk0GTLsZrVQOSMmYO6J+vA2k+C9FABwERxlsOYde4XrhEfr3nku516 FJnnLgZoICdmh265HCD3A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddugdefjeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucenucfjughrpefoggffhf fvvefkjghfufgtgfesthejredtredttdenucfhrhhomhepfdfruhgtkhcuofgvvghrsghu rhhgfdcuoehpuhgtkhesphhutghkihhpvgguihgrrdgtohhmqeenucggtffrrghtthgvrh hnpeeiieekjeethfetieethedvgfeujeelveefvdfghfduleduieevteduffelledvueen ucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehpuhgtkh esphhutghkihhpvgguihgrrdgtohhmpdhnsggprhgtphhtthhopeefpdhmohguvgepshhm thhpohhuthdprhgtphhtthhopehhihesrghlhihsshgrrdhishdprhgtphhtthhopeguvg hvvghlsehsphgvtghtrhhumhdqohhsrdhorhhgpdhrtghpthhtohephihukhgrseihuhhk rgdruggvvh X-ME-Proxy: Feedback-ID: ie69944d9:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id DD58B1EA0061; Thu, 5 Jun 2025 10:11:58 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface MIME-Version: 1.0 X-ThreadId: Tba971348b905d990 Date: Thu, 05 Jun 2025 16:11:17 +0200 From: "Puck Meerburg" To: "Alyssa Ross" , devel@spectrum-os.org Message-Id: <9807fedc-2f29-4955-b5f1-fb35dc7c9509@app.fastmail.com> In-Reply-To: <20250605120819.7145-1-hi@alyssa.is> References: <20250605120819.7145-1-hi@alyssa.is> Subject: Re: [PATCH] vm: link /sbin to /usr/bin Content-Type: text/plain Content-Transfer-Encoding: 7bit Message-ID-Hash: H7VSXSCJEVE6JW7OOTER4OVKJBOMZTPM X-Message-ID-Hash: H7VSXSCJEVE6JW7OOTER4OVKJBOMZTPM X-MailFrom: puck@puckipedia.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; header-match-devel.spectrum-os.org-2; header-match-devel.spectrum-os.org-3; header-match-devel.spectrum-os.org-4; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Yureka X-Mailman-Version: 3.3.9 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 5 Jun 2025, at 14:08, Alyssa Ross wrote: > This is necessary because the kernel tries to load modules by running > /sbin/modprobe. Shouldn't it be possible to set /proc/sys/kernel/modprobe instead? > This should fix Intel wireless cards in netvm. It's > then important to disable Busybox init because /sbin/init takes > precedence over our /etc/init. > > Signed-off-by: Alyssa Ross > --- > img/app/Makefile | 2 +- > img/app/default.nix | 1 + > img/app/sbin | 1 + > vm/sys/net/Makefile | 2 +- > vm/sys/net/default.nix | 1 + > vm/sys/net/sbin | 1 + > 6 files changed, 6 insertions(+), 2 deletions(-) > create mode 120000 img/app/sbin > create mode 120000 vm/sys/net/sbin > > diff --git a/img/app/Makefile b/img/app/Makefile > index 5ea023e..c827fd3 100644 > --- a/img/app/Makefile > +++ b/img/app/Makefile > @@ -60,7 +60,7 @@ VM_FIFOS = > etc/s6-linux-init/run-image/service/s6-linux-init-shutdownd/fifo > > # These are separate because they need to be included, but putting > # them as make dependencies would confuse make. > -VM_LINKS = bin etc/ssl/certs/ca-certificates.crt > +VM_LINKS = bin etc/ssl/certs/ca-certificates.crt sbin > > VM_BUILD_FILES = build/etc/s6-rc > > diff --git a/img/app/default.nix b/img/app/default.nix > index 6e423f6..a196205 100644 > --- a/img/app/default.nix > +++ b/img/app/default.nix > @@ -24,6 +24,7 @@ let > CONFIG_FEATURE_IP_ADDRESS y > CONFIG_FEATURE_IP_LINK y > CONFIG_FEATURE_IP_ROUTE y > + CONFIG_INIT n > CONFIG_IP y > ''; > }) > diff --git a/img/app/sbin b/img/app/sbin > new file mode 120000 > index 0000000..1e881ed > --- /dev/null > +++ b/img/app/sbin > @@ -0,0 +1 @@ > +usr/bin > \ No newline at end of file > diff --git a/vm/sys/net/Makefile b/vm/sys/net/Makefile > index 35da669..436ca6e 100644 > --- a/vm/sys/net/Makefile > +++ b/vm/sys/net/Makefile > @@ -43,7 +43,7 @@ VM_DIRS = dev etc/s6-linux-init/env run proc sys > var/lib/connman > > # These are separate because they need to be included, but putting > # them as make dependencies would confuse make. > -VM_LINKS = bin lib var/run > +VM_LINKS = bin lib sbin var/run > > VM_BUILD_FILES = build/etc/s6-rc > > diff --git a/vm/sys/net/default.nix b/vm/sys/net/default.nix > index 69f9564..b5873eb 100644 > --- a/vm/sys/net/default.nix > +++ b/vm/sys/net/default.nix > @@ -22,6 +22,7 @@ let > (busybox.override { > extraConfig = '' > CONFIG_DEPMOD n > + CONFIG_INIT n > CONFIG_INSMOD n > CONFIG_LSMOD n > CONFIG_MODINFO n > diff --git a/vm/sys/net/sbin b/vm/sys/net/sbin > new file mode 120000 > index 0000000..1e881ed > --- /dev/null > +++ b/vm/sys/net/sbin > @@ -0,0 +1 @@ > +usr/bin > \ No newline at end of file > > base-commit: b5dab0eea25e24531ac856985b8f79ef38c06366 > -- > 2.49.0