From: "impaqt" <impaqt@vendek.net>
To: "Alyssa Ross" <hi@alyssa.is>, <devel@spectrum-os.org>
Subject: Re: [PATCH doc v2] Document crosvm memfd server
Date: Wed, 27 May 2020 17:40:43 -0700 [thread overview]
Message-ID: <C31Y0KD58S7F.1X8LFPQRPJXVM@jupiter> (raw)
In-Reply-To: <20200527232709.22211-1-hi@alyssa.is>
Looks good. One minor nitpick, take it or leave it:
> +Spectrum's crosvm has been augmented with a feature called the "`memfd
> +server`", (currently only on the
> +https://spectrum-os.org/git/crosvm/log/?h=interguest[interguest]
> +branch). This is a small server that listens on a Unix stream socket.
This should be either a comma or parenthesis, not both.
This is just a personal preference of mine, but one I wish were
more widely adopted: when writing markdown I only wrap the "proper
nouns" in `code blocks` for consistency, e.g. "`memfd` server" not
"`memfd server`". But this isn't a hill I'm prepared to die on.
Reviewed-by: impaqt <impaqt@vendek.net>
^^^ Is this what you meant by a tag?
next prev parent reply other threads:[~2020-05-28 0:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 17:37 [PATCH doc] Document crosvm memfd server Alyssa Ross
2020-05-27 0:13 ` impaqt
2020-05-27 23:27 ` [PATCH doc v2] " Alyssa Ross
2020-05-28 0:40 ` impaqt [this message]
2020-05-29 18:12 ` Alyssa Ross
2020-05-29 18:49 ` Cole Helbling
2020-05-29 18:59 ` Alyssa Ross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C31Y0KD58S7F.1X8LFPQRPJXVM@jupiter \
--to=impaqt@vendek.net \
--cc=devel@spectrum-os.org \
--cc=hi@alyssa.is \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://spectrum-os.org/git/crosvm
https://spectrum-os.org/git/doc
https://spectrum-os.org/git/mktuntap
https://spectrum-os.org/git/nixpkgs
https://spectrum-os.org/git/spectrum
https://spectrum-os.org/git/ucspi-vsock
https://spectrum-os.org/git/www
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).