From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HTML_MESSAGE,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 1B6E75EA47; Thu, 8 Sep 2022 11:40:29 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 496) id 8A7075E9DF; Thu, 8 Sep 2022 11:40:26 +0000 (UTC) Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by atuin.qyliss.net (Postfix) with ESMTPS id 26CC75EA2E for ; Thu, 8 Sep 2022 11:40:23 +0000 (UTC) Received: by mail-ed1-x529.google.com with SMTP id m1so23898872edb.7 for ; Thu, 08 Sep 2022 04:40:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=unikie.com; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=70tDoDjEBWvxErTYu2Qbq6lT27kuCDXTFCi1tYINGBE=; b=Ue1JWRsmNuteRsKb6IKDgi4D8oXaMLUNum+saHxpEtea4ltNvmovmXrg4oakiHbLFW n9dn7ATTl3+Nf2Ea/Jg1QUqIwAcW/rnP7Vk7y8ze7fEN4CYRIT90RFIE2Wu0siLJExML a62YR2zw7qmgVX/TgfcxV0GqIXHSqpaolXWFMMSSQnEKbWtuKOM5J/RcbCyqGXiWjepS usYTTfDeLUibKez8yq5mXJntvLyJXHaRZPMUyccjCW/Ct0SGXjZWWEoU20ugsyPPC6J3 CMESd0gsRMpveoDZoZI77ZVfPJAMSE7kfUhKB6shEo23runwDZvnRzs7qf2ELThqL7N3 GV8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=70tDoDjEBWvxErTYu2Qbq6lT27kuCDXTFCi1tYINGBE=; b=frgHegfuDgxyguV7F1ZvYhDE1bEAqbZlASTH2y9jtK/VT+cnaQccvOYkw2HRQqqt01 guA8GA2O/PeOC4wKBkw91VMxdWixBQA9GHgbc3BxPJQXdJ9IQYVvHWHeWcCEMu/Ax+zs VOOfxd9azKV7BzW8TmEhnSj2KxT7UG1kp46HWPmnTwwFNInS1kRoEatiNmckem+Enafv 8g6SgE074L602BRPq4s37PoxGGv/Gb2gK04imQoL08amfuTPLLeRq8fE/EYsO7FhIRgz v9qGAXn9+HNGcvq2as0Ysr6rIHP1UFUAZtpnPIYqY9jS6a60aOcJicz+6E7tt0R6gBGw 3ajw== X-Gm-Message-State: ACgBeo1aSmoBuEPcIk76r2mNipPCHSMMJMvK7A9mL+XwYjjGNROe+648 oBbtbx3Nc5YlING3ky0Q10EqYICy+WHo1dv314dPFg== X-Google-Smtp-Source: AA6agR5uT6nT5KvxBNXJQDboRARymN98t7Da4emxVHJZNnzBeGJ2osvUI0EeEmKnLttGv5hTo0O5Yu0o5xUSvsEVsWw= X-Received: by 2002:a05:6402:2694:b0:450:d537:f6d6 with SMTP id w20-20020a056402269400b00450d537f6d6mr1122270edd.344.1662637222469; Thu, 08 Sep 2022 04:40:22 -0700 (PDT) MIME-Version: 1.0 References: <20220831093727.282797-1-hi@alyssa.is> <2ff7084f-a7e3-b6da-21cd-cf65392ce834@unikie.com> <87fsh5c60x.fsf@alyssa.is> In-Reply-To: <87fsh5c60x.fsf@alyssa.is> From: =?UTF-8?Q?Jos=C3=A9_Pekkarinen?= Date: Thu, 8 Sep 2022 14:39:46 +0300 Message-ID: Subject: Re: [PATCH 1/4] Introduce a build configuration file To: Alyssa Ross Content-Type: multipart/alternative; boundary="000000000000093ef705e828e5e9" Message-ID-Hash: 74U6FVFXAWVBX6XWMB346WI3ZNLUTMOT X-Message-ID-Hash: 74U6FVFXAWVBX6XWMB346WI3ZNLUTMOT X-MailFrom: jose.pekkarinen@unikie.com X-Mailman-Rule-Hits: header-match-devel.spectrum-os.org-0 X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1 CC: Ville Ilvonen , devel@spectrum-os.org, Ivan Nikolaenko X-Mailman-Version: 3.3.5 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --000000000000093ef705e828e5e9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Sep 6, 2022 at 10:32 AM Alyssa Ross wrote: > Ville Ilvonen writes: > > > On 8/31/22 12:37, Alyssa Ross wrote: > >> By default, a file called "config.nix" in the root of the Spectrum > >> repository will be read if it exists. That file should contain an > >> attribute set. Currently, only a "pkgs" key is supported, which > >> allows specifying a custom package set that will be used throughout > >> the Spectrum Nix files. This will allow us to provide configuartion > >> options for people who want to build Spectrum in ways that are > >> probably not suitable for upstreaming. > > > > >> For example, using the "pkgs" config option I'm introducing here, it > >> would be possible to use an overlay to patch individual components, > >> like so: > >> > >> { > >> pkgs =3D import { > >> overlays =3D [ > >> (final: super: { > >> weston =3D super.weston.overrideAttrs ({ patches ? [], ..= . > }: { > >> patches =3D patches ++ [ > >> path/to/weston.patch > >> ]; > >> }); > >> }) > >> ]; > >> }; > >> } > >> > >> Signed-off-by: Alyssa Ross > Tested-by: Jos=C3=A9 Pekkarinen >> --- > > > > Appreciate it as this makes it more clean to implement device specifics= . > > Would you like to see the device specific configs in tree or out of > > tree? One option would be to set the default config and support in tree > > configs of devices people could choose from. Even if not fully supporte= d > > by upstream, they could be useful as examples. If both are possible, > > criteria for guiding in-tree and out-of-tree configs could be also > useful. > > I'm not sure yet. Let's maybe revisit once we have generic ARM support > in-tree, and see how it feels then? > > > Thanks, > > > > -Ville > > > > Reviewed-by: Ville Ilvonen > > Thanks for the review. :) > --=20 Jos=C3=A9. --000000000000093ef705e828e5e9 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Tue, Sep 6, 2022 at 10:32 AM Alyss= a Ross <hi@alyssa.is> wrote:
<= /div>
Ville Ilvonen <ville.ilvonen@u= nikie.com> writes:

> On 8/31/22 12:37, Alyssa Ross wrote:
>> By default, a file called "config.nix" in the root of th= e Spectrum
>> repository will be read if it exists.=C2=A0 That file should conta= in an
>> attribute set.=C2=A0 Currently, only a "pkgs" key is sup= ported, which
>> allows specifying a custom package set that will be used throughou= t
>> the Spectrum Nix files.=C2=A0 This will allow us to provide config= uartion
>> options for people who want to build Spectrum in ways that are
>> probably not suitable for upstreaming.
>=C2=A0 >
>> For example, using the "pkgs" config option I'm intr= oducing here, it
>> would be possible to use an overlay to patch individual components= ,
>> like so:
>>
>>=C2=A0 =C2=A0 =C2=A0 {
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 pkgs =3D import <nixpkgs> {
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 overlays =3D [
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (final: super: {
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 weston =3D super.w= eston.overrideAttrs ({ patches ? [], ... }: {
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 patches =3D= patches ++ [
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 path= /to/weston.patch
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ];
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 });
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 })
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ];
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 };
>>=C2=A0 =C2=A0 =C2=A0 }
>>
>> Signed-off-by: Alyssa Ross <hi@alyssa.is>
=C2=A0
Tested= -by: Jos=C3=A9 Pekkarinen <jose.pekkarinen@unikie.com>=C2=A0

>> ---
>
> Appreciate it as this makes it more clean to implement device specific= s.
> Would you like to see the device specific configs in tree or out of > tree? One option would be to set the default config and support in tre= e
> configs of devices people could choose from. Even if not fully support= ed
> by upstream, they could be useful as examples. If both are possible, <= br> > criteria for guiding in-tree and out-of-tree configs could be also use= ful.

I'm not sure yet.=C2=A0 Let's maybe revisit once we have generic AR= M support
in-tree, and see how it feels then?

> Thanks,
>
> -Ville
>
> Reviewed-by: Ville Ilvonen <ville.ilvonen@unikie.com>

Thanks for the review. :)


--
Jos=C3=A9.
<= /div> --000000000000093ef705e828e5e9--