From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HTML_MESSAGE,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id DBFE55EAE9; Thu, 8 Sep 2022 11:41:58 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 496) id BAB635EAE4; Thu, 8 Sep 2022 11:41:56 +0000 (UTC) Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by atuin.qyliss.net (Postfix) with ESMTPS id DCC4B5EAE3 for ; Thu, 8 Sep 2022 11:41:54 +0000 (UTC) Received: by mail-ej1-x636.google.com with SMTP id lz22so16536468ejb.3 for ; Thu, 08 Sep 2022 04:41:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=unikie.com; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=ktAQpNlKswiSsQrrhuWgcmXfwZu/RIv+p1hThZEu28E=; b=AhtDV/OtzkQlAxlsqHFQZX91VryOmn9Vw2ibuirykQxbdmoSIi4UTkP3isev5UrEaq qOLudS2kEUQG/Sw0zubqXbl+3MnLgZySsKPUQdTSUrjHiWfriAfATwYQxCQHDG00aG3E xPLyMLBnbzO+XFR2RVopugq7CwKuoJ8KC09Vy8EyjVLczw9ldrEjyJPeVNcOYW8Jpp1g 2dwYd0mRBxgZBuSpNRJYu7Ye3V3Uy3WNqwH+74rmYhXKjl3mDYRDR6JYUP2xoES2UjV3 k1L8soRsvGo5Ly3ebvv6t6iUdwZyWF0Wniv7i/vWsvLj5mq8rQhUCVvV9HEflVosjQYk oYIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=ktAQpNlKswiSsQrrhuWgcmXfwZu/RIv+p1hThZEu28E=; b=wOwSugRYwj3YjuyomtPGIofBNhGyK/8Mi5kFTCSfa7CSbc9H9NO6LpAq8Gwz2P8S+Q z3Y9uhbamqJhtp4xjQtvX4zF8yLKyGVoKKPerSVq9MuY9u4ihdmk+ZKsDtisSytSINoh wlhzK/5aB5ih+uI0EqMeazINHAPyauJkztX4wzhXbBRvS+Qs+Guc1iKBo5EsWXlt4GZj L3vJS4iCt/WZVB5FJACVAJI2cfDuQGlLSza7ivjWnus8BFGi7RS7n5TzG7efX2Gh2yfp XMPlI9RkjEr96QVdeQK2O6ti3O7YDy/XRpWWUTSPOQXPcdph4Lf0TyzNlyQtAXMfIADn DlFg== X-Gm-Message-State: ACgBeo1rVcUVxROG0YQdc9yZsY4jDQUYvA51uV08irIBlWuBd2ItBgxs u+7h9phWvxs0G67YUF82SFvCN4KxL5eATa7MxTJwmQ== X-Google-Smtp-Source: AA6agR6SQzPPeMnVpa+M0Xpz3dF6hhH84e6K83W6hBhShW3i8z7+Bk1M8OFZh+47yjihdkJp8R4xQaeeMAShCw4vrBY= X-Received: by 2002:a17:907:a0c6:b0:73d:bf46:f06b with SMTP id hw6-20020a170907a0c600b0073dbf46f06bmr5787981ejc.127.1662637314419; Thu, 08 Sep 2022 04:41:54 -0700 (PDT) MIME-Version: 1.0 References: <20220901104629.863380-1-hi@alyssa.is> <20220901104629.863380-2-hi@alyssa.is> In-Reply-To: <20220901104629.863380-2-hi@alyssa.is> From: =?UTF-8?Q?Jos=C3=A9_Pekkarinen?= Date: Thu, 8 Sep 2022 14:41:18 +0300 Message-ID: Subject: Re: [PATCH 2/2] host/rootfs: remove kernel override To: Alyssa Ross Content-Type: multipart/alternative; boundary="00000000000084498c05e828eaf5" Message-ID-Hash: VYDAQKHZPWEHOMDNLLDZUZEP4AL36RDX X-Message-ID-Hash: VYDAQKHZPWEHOMDNLLDZUZEP4AL36RDX X-MailFrom: jose.pekkarinen@unikie.com X-Mailman-Rule-Hits: header-match-devel.spectrum-os.org-0 X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1 CC: devel@spectrum-os.org X-Mailman-Version: 3.3.5 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --00000000000084498c05e828eaf5 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Sep 1, 2022 at 1:47 PM Alyssa Ross wrote: > These drivers should be loaded by the initramfs if required =E2=80=94 mos= t > Spectrum installs won't need the virtio drivers on the host, and > overriding the kernel means more stuff we can't reuse from > cache.nixos.org. > > We'll probably want to build in the driver for whatever filesystem we > end up using for the root file system eventually, since it will always > be required, but that should be done as part of a more systematic > effort to optimise our kernel configuration. > > Signed-off-by: Alyssa Ross > Tested-by: Jos=C3=A9 Pekkarinen > --- > host/rootfs/default.nix | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) > > diff --git a/host/rootfs/default.nix b/host/rootfs/default.nix > index e5f316f..a651a20 100644 > --- a/host/rootfs/default.nix > +++ b/host/rootfs/default.nix > @@ -65,14 +65,7 @@ let > imports =3D [ (modulesPath + "/profiles/all-hardware.nix") ]; > }); > > - kernel =3D pkgs.linux_latest.override { > - structuredExtraConfig =3D with lib.kernel; { > - VIRTIO =3D yes; > - VIRTIO_PCI =3D yes; > - VIRTIO_BLK =3D yes; > - EXT4_FS =3D yes; > - }; > - }; > + kernel =3D pkgs.linux_latest; > > packagesSysroot =3D runCommand "packages-sysroot" { > nativeBuildInputs =3D [ xorg.lndir ]; > -- > 2.37.1 > > --=20 Jos=C3=A9. --00000000000084498c05e828eaf5 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Thu, Sep 1, 2022 at 1:47 PM Alyssa= Ross <hi@alyssa.is> wrote:
These drivers should = be loaded by the initramfs if required =E2=80=94 most
Spectrum installs won't need the virtio drivers on the host, and
overriding the kernel means more stuff we can't reuse from
cac= he.nixos.org.

We'll probably want to build in the driver for whatever filesystem we end up using for the root file system eventually, since it will always
be required, but that should be done as part of a more systematic
effort to optimise our kernel configuration.

Signed-off-by: Alyssa Ross <hi@alyssa.is>
= =C2=A0
Tested-by: Jos=C3=A9 Pekkarinen <jose.pekkarinen@unikie.com>=C2= =A0
=C2=A0
---
=C2=A0host/rootfs/default.nix | 9 +--------
=C2=A01 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/host/rootfs/default.nix b/host/rootfs/default.nix
index e5f316f..a651a20 100644
--- a/host/rootfs/default.nix
+++ b/host/rootfs/default.nix
@@ -65,14 +65,7 @@ let
=C2=A0 =C2=A0 =C2=A0imports =3D [ (modulesPath + "/profiles/all-hardwa= re.nix") ];
=C2=A0 =C2=A0});

-=C2=A0 kernel =3D pkgs.linux_latest.override {
-=C2=A0 =C2=A0 structuredExtraConfig =3D with lib.kernel; {
-=C2=A0 =C2=A0 =C2=A0 VIRTIO =3D yes;
-=C2=A0 =C2=A0 =C2=A0 VIRTIO_PCI =3D yes;
-=C2=A0 =C2=A0 =C2=A0 VIRTIO_BLK =3D yes;
-=C2=A0 =C2=A0 =C2=A0 EXT4_FS =3D yes;
-=C2=A0 =C2=A0 };
-=C2=A0 };
+=C2=A0 kernel =3D pkgs.linux_latest;

=C2=A0 =C2=A0packagesSysroot =3D runCommand "packages-sysroot" {<= br> =C2=A0 =C2=A0 =C2=A0nativeBuildInputs =3D [ xorg.lndir ];
--
2.37.1



--
Jos=C3=A9.
<= /div> --00000000000084498c05e828eaf5--