From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 6E175C7EE; Wed, 11 May 2022 09:08:07 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 496) id A65E5C7E3; Wed, 11 May 2022 09:08:04 +0000 (UTC) Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) by atuin.qyliss.net (Postfix) with ESMTPS id AF180C855 for ; Wed, 11 May 2022 09:08:01 +0000 (UTC) Received: by mail-lj1-x22a.google.com with SMTP id q130so1745130ljb.5 for ; Wed, 11 May 2022 02:08:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=unikie.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=T6uU9nUZhRzI1L3+u2OBYYqQOy+ol2MFgqMKv/mQM+Y=; b=O5ieizK83r37STscUXdbaK00G2Vkp2DNQ0eCWkXYO+Pxu441GC6WJ0woKZoy5bIvud 8kD1TuKeUKz5Kc3tAFXem+9obEvsXO/faXvddMeJWlEjctrNRp0N5lAMU153eFvxqk/v +n7gbSjNWtxlCuLiqLjE5+CxrUzytLPmvPtBcwH60VRxvup+Cy8ObeJGO+qWYsAxCtg8 ov8L4w/8F+yNHRdd2BQbSZ2SmBbktvNvRyR+I8mA19R2mXlpp1r8hXkIatfjuDsyZcxm 2AVZjasFXElVq7yQqRQTWnm9HVBauuPoWZ4qZ9eEO7ZtiR6WnixJp6PPlyqjaU8kOYek eJ6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=T6uU9nUZhRzI1L3+u2OBYYqQOy+ol2MFgqMKv/mQM+Y=; b=dEUSjFFPk8m3l3BEqeruWhppCVfz2TkPAD5v8oPxKE/Ta4ugtdevISwPkYvTTo48gN yxu9MQpExqbZZQc8bjCjLSmcmksJukIpJ5rhOQPQr4iyScJlGLNaOUYN/E6c7F7bMDtM djSHhtsUpiZXT5cbDie13M+qLvGdQPE0clRlkckg8dSwNc2+zuiC8RSX5QWAskFThPQN QoddW0tFEq+Bcii9WvWzpfgJSc5t+KEaCgj3tmWEhGnD+e5diFZ6j45oxN6S1TA57A3w zpJWLYJfXlC4hHTKyP0k9/HrMbbpCxNnROdvuSnq/9xrd+sH+0cWrZw/yFK0dETBnEuE XuLA== X-Gm-Message-State: AOAM5309VrX+xScCRGvDVKm5Q89z3AOjUL6I4om6khWNAvgxPzqMjjJ+ 5gCrLkIt372bmiCdCigAn+4jj/O8QgruI2VoAA6ye3LojLo= X-Google-Smtp-Source: ABdhPJxvAltmbjfiYXYW7BtUORbiKHM8PNgYfuvPHmHatRFGPLdDuwNJPCMqWv0mfszoBnmWuxzfrYi77N/LERYlpaw= X-Received: by 2002:a2e:80d5:0:b0:24f:616:1990 with SMTP id r21-20020a2e80d5000000b0024f06161990mr16046565ljg.17.1652260079881; Wed, 11 May 2022 02:07:59 -0700 (PDT) MIME-Version: 1.0 References: <20220424080020.32216-1-hi@alyssa.is> In-Reply-To: <20220424080020.32216-1-hi@alyssa.is> From: Ville Ilvonen Date: Wed, 11 May 2022 12:07:49 +0300 Message-ID: Subject: Re: [PATCH] host/rootfs: fix Weston hotplugging To: Alyssa Ross Content-Type: text/plain; charset="UTF-8" Message-ID-Hash: KTUWCVK2XCOUT7KUN4LDUFM67TQBXQ3R X-Message-ID-Hash: KTUWCVK2XCOUT7KUN4LDUFM67TQBXQ3R X-MailFrom: ville.ilvonen@unikie.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-devel.spectrum-os.org-0; header-match-devel.spectrum-os.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: devel@spectrum-os.org X-Mailman-Version: 3.3.5 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Sun, Apr 24, 2022 at 11:02 AM Alyssa Ross wrote: > > On the Spectrum host, the kernel delivers uevents to mdevd. By > default, if mdevd doesn't have a handler for an event, it won't do > anything, and other processes that might be interested in the uevent > hear about it. This means that Weston isn't notified about input > device hotplugs. (And USB devices can appear after init has started, > so any USB device counts as hotplugging even if it's attached before > boot or even built in to the computer.) > > To fix this, we configure mdevd to rebroadcast events it doesn't > handle on Netlink group 4. These events will then be picked up by > Weston via libudev-zero, which listens on group 4 for hotplug events. > > Reported-by: Ville Ilvonen > Fixes: 372bacd ("etc/s6-rc: add weston service") > --- > Ville, does this fix the internal keyboard and mouse on your ThinkPad T560? It does. Thanks a lot. -Ville > > host/rootfs/etc/s6-rc/mdevd/run | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/host/rootfs/etc/s6-rc/mdevd/run b/host/rootfs/etc/s6-rc/mdevd/run > index f838d2d..c4615c8 100644 > --- a/host/rootfs/etc/s6-rc/mdevd/run > +++ b/host/rootfs/etc/s6-rc/mdevd/run > @@ -2,4 +2,4 @@ > # SPDX-License-Identifier: EUPL-1.2 > # SPDX-FileCopyrightText: 2020-2022 Alyssa Ross > > -mdevd -D3 -b134217728 > +mdevd -D3 -O4 -b134217728 > > base-commit: 402c7fd0637e834f97b0ea1a2abb89c417e7469d > -- > 2.35.1 >