From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.3 (2019-12-06) on atuin X-Spam-Level: X-Spam-Status: No, score=0.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FORGED_SPF_HELO,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS autolearn=no autolearn_force=no version=3.4.3 Received: by atuin.qyliss.net (Postfix, from userid 496) id BEB8022C96; Sat, 30 May 2020 23:55:17 +0000 (UTC) Received: from [127.0.1.1] (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 35D6622BFD; Sat, 30 May 2020 23:55:11 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 496) id 4E60622C69; Sat, 30 May 2020 23:55:09 +0000 (UTC) Received: from NAM04-CO1-obe.outbound.protection.outlook.com (mail-oln040092010082.outbound.protection.outlook.com [40.92.10.82]) by atuin.qyliss.net (Postfix) with ESMTPS id 03A5922C68 for ; Sat, 30 May 2020 23:55:04 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cxsGiOHGHkhF0urQVrpFZoswQx6ecVRvEjmcruYL5Mw/sOVaO7EbfBVyY27NMHIyrllcsa6uqKqlXkjphNLbPXEG8mkKrIo3paJpbC8f3xkytiku1ukiWpASBgmQ/fjsXSRkOiFtDkm5DlPBcBKkOUwyyvnbGoE3H3X8F+6Ni8IFlXDsPRqc4cONSn+jNjT9a6roTxe1ziK2MxGos/lyYkoICw+nw3op/2xBOCRM+hhGoXrWSSdMZwofuTMHEk7V2wsKnQ5EQBGR0oChbYz8OT52xOun2x5Id+uCOOJgC0d2X2ca+7ZJ1hAPKurHplVLDVTsb7a+SU9uESHbFzAKKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HszIW/BqevxJmtYaaUymwcV7RFnNerp0lK6DgA40+9A=; b=R8GvDeM2yGnJ/Pg+NG/aUch977KTiMYY7OY/4WrpQ/ZU3jbIS0nG6ArKhAQMcex+Ut18M5oDDrJw7qWDeBgkLjy9cLAH8kDOSvq2A8yh3jQuCOpMAQFyBVAe+Zq/kNrbUonf9qhFjtsrQZ9MXwiMbFE25N3o89GOaidz7VTwOWv5q/LXYWD8yH7MJdQyZyyNOgnzy+R8aBK1TBnk80lLG8EnbTQUmt8ntbZMcb+yfob/Y70SzBTV7kwPSRSFhnrAWaHU6EpujW0DHt7GOZ6LkWAHPSmPG5Al8/YLp6rhOJaPmNZbwziXYtjaBZSSwWKKVnpzlLZQwPeRSpYlPWyOwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=outlook.com; dmarc=pass action=none header.from=outlook.com; dkim=pass header.d=outlook.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HszIW/BqevxJmtYaaUymwcV7RFnNerp0lK6DgA40+9A=; b=IMPqcvq5vmWSvm9yI+ABW8ATKXAIRqIIftbqDZhmCKguhjGnWDquEBhgmsRVcAoKusUqGVmro4jZ/LIZm/wX4W0wgQZJLGbIhP4G4p0Z9bx+mjqZCf6OVMjXu2SLqC+u5Q5XmTLl48Z/PJM0tDKPhKAOhSSJYNckslgkIotsmubm99Oea0gJKv8d/woImOzuARbRQL+TtvUBTCr8X3LjKvQap6CkfO8fijLzUtOsMrOljnPn8Rz7Sjzt9rtcxIpg30ysIl9/Clpc7VeRjCTjEIZf7zxLEh2LAmGGVIhzkrCHG6SWH+f/gMuCy82GcUWVxY2aVA1AxOwy7aq/G7Pt9Q== Received: from SN1NAM04FT047.eop-NAM04.prod.protection.outlook.com (10.152.88.60) by SN1NAM04HT202.eop-NAM04.prod.protection.outlook.com (10.152.89.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3021.23; Sat, 30 May 2020 23:55:01 +0000 Received: from CH2PR14MB3579.namprd14.prod.outlook.com (2a01:111:e400:7e4c::46) by SN1NAM04FT047.mail.protection.outlook.com (2a01:111:e400:7e4c::481) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3021.23 via Frontend Transport; Sat, 30 May 2020 23:55:01 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:95771154F83A97CBC4C7493C31EA2B89B1DB819F2B5DEEC567D7BE4F765B2CE5;UpperCasedChecksum:0409D317734CFE434F1B69B0167163BB015ACDC76712684FBBA5A5B5F78E0054;SizeAsReceived:8658;Count:47 Received: from CH2PR14MB3579.namprd14.prod.outlook.com ([fe80::2948:142c:3047:102c]) by CH2PR14MB3579.namprd14.prod.outlook.com ([fe80::2948:142c:3047:102c%5]) with mapi id 15.20.3045.022; Sat, 30 May 2020 23:55:01 +0000 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 In-Reply-To: <20200530190028.6388-1-hi@alyssa.is> Date: Sat, 30 May 2020 16:47:11 -0700 Subject: Re: [PATCH 1/2] chromiumOSPackages: improve update.py repo compat From: "Cole Helbling" To: "Alyssa Ross" , Message-ID: X-ClientProxiedBy: BYAPR06CA0018.namprd06.prod.outlook.com (2603:10b6:a03:d4::31) To CH2PR14MB3579.namprd14.prod.outlook.com (2603:10b6:610:62::18) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost (67.187.170.40) by BYAPR06CA0018.namprd06.prod.outlook.com (2603:10b6:a03:d4::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3045.19 via Frontend Transport; Sat, 30 May 2020 23:55:00 +0000 X-Microsoft-Original-Message-ID: X-TMN: [q0m2u0ckAS5lZCzVflQGlLXmijqcVZPO] X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 47 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: dd2633b5-2863-458d-ce67-08d804f4ddb8 X-MS-Exchange-SLBlob-MailProps: =?utf-8?B?YXBnbzVEMHVNT0h1OXU2QUt5YWEwNUJ4ZHBMWXo2ZndpOWhZSUpiNHU1RnVF?= =?utf-8?B?U0UvTVdEVEsxQmF2eXdUbEQ0OGpNQldoazBkUzlNMFdwU2xZdG43TFRtMktm?= =?utf-8?B?Uzdya2taRlkwRk1QeWFTQmtmWFlJQ1gxaXRFR2t5YVRPNzF1UUNGSVkxYlVu?= =?utf-8?B?Wlp4Nzl4YUF2eDBTMFl3WjhFQXF0Q0lMTTBWWU82MGkvQ2FKbTFYdGVNbi9m?= =?utf-8?B?ZXR0UzcxRkhNMm5QUGZEYXBiem9CRXVtcXdOb0o4andabGkvMjB6UnNtVS9s?= =?utf-8?B?QkQ0a0FkVHNwS1MzMFgzRWY5WlpXcTQzcUlwbXB5MDBoTmZFcnBtOC93UFF6?= =?utf-8?B?a0ozUmxFUVVxUk5XeEdpZnRWSStjU2xIM1VsZnNHVVpqS1diZERBTEJKR3FI?= =?utf-8?B?QTNYMEtxeWF1d0duaEc3eWpHaU1uSTdGaFdXSXNtNFR6L3V3RERlMkVMeUdX?= =?utf-8?B?R2lzQWo3bkF0T0RhWDZXcTYwNUhRV1J0RlBKZVNYc0tXdVFsZlpyT1pybTFr?= =?utf-8?B?aytUS043SE4wOU4xa2IyWjYyRnpaNlFzUVR1OWlVbU1EQlh1d2svRDQrL1BB?= =?utf-8?B?U3Y0NFZWeHpvRVJjcFJlcXI4b003aXZDTmVCVnN4UGtoK0JDOE1FdzU5OVR3?= =?utf-8?B?WEZwSmtkUkV5V1l5THFWSTJQcEFhN1RuUkx1UVdHYnJ2cmQzUFg4VFN5aUt3?= =?utf-8?B?Zm04N3JDMml4KzJiUUVTVDVHMm5UbVpmRUs5Z282RHp1TVNMNFFpOFl1dGQ2?= =?utf-8?B?M0taRk5kYUpUaFQrUE9xMmZwa2lWQ3E4Zms0VWk2TjlTOXM2QWFOREZFT2JE?= =?utf-8?B?Q0JjUHloNnZxWGZCZ2luK1BKcmxueGdqUUZFOHpVQTZENnNEazJLNjMrNWN4?= =?utf-8?B?czEzSzVwS2lreFRrT0RXS2JSZXhWTTYxSU44amdib29Jd2lRZXI0U3hIOVNt?= =?utf-8?B?SDc4M3VGY014d0NIZlR1L01STnNtc1hKbFlxcFltTkx0RktBaElCWHVrZm80?= =?utf-8?B?dXlqSHZ4NjQzOCtPSG5UZzZ0elhCZ1diN3NQWUNGZmxpMFFrQmx5Qks2NnNT?= =?utf-8?B?QzZNTStiek5jSkduT0U3d3o0QTlHMFo3WDdPRkIvK2YveENwODdFRXphRzZy?= =?utf-8?B?QTg0TGlQMm5abnpFS1ZJLzMyZjhIc0UzbTN3bEhSbDE4RHQxeitiMUhMMnJ5?= =?utf-8?B?Q25LYXRhMmNnQklVdVF4L0RKOUJFWHVxL29KamhwK0VMNjdNbngxR3MrY0Vx?= =?utf-8?B?RVJVajhGUi9Ia2hWV1dMaWJwY0lmRzAvOE9QZTBnWnJCM25UUUVodmdZaXgy?= =?utf-8?B?V0ZEaWZhcHQ2cDVQcGZkdGxmRHBOS3hBPT0=?= X-MS-TrafficTypeDiagnostic: SN1NAM04HT202: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: S46dkR1ifUlpxzNuiOgihvhu/N1JU7Pbo+1qI8dGWtp9oR8lG+86EZnbHENEG1Iqe4LlnecT91a8uP8xxI8zvZ803es7Qu4sN0INpfEDtSVFebEQQRg1PcnnL5hpo3LSW+XAm4O0EZ8JYXuIdsaewm9kqkDaqpMqpZGmHv++gRnKnmAkqIHSK2od1y6OkPS16On7wWZ+CbIHz8zEHj8Ckh33BR8D/nWvHEfkYwLgdzzRIPWg1VoBQP4DZy38IVER X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:0;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR14MB3579.namprd14.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:;DIR:OUT;SFP:1901; X-MS-Exchange-AntiSpam-MessageData: 1qDIbWH344kQwmHCLvPJT89e/6s++wXuy8SJkgZPXsNKBv0nQjlr3Yauyuad6M6AohgtZVxncgrEIS+9UJEtpS5j6zMcxNWq4pCPM4wNYl4ScUiAi/313c19dQwYW36NvNpAxv9uApTzz29C+dKRlQ== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dd2633b5-2863-458d-ce67-08d804f4ddb8 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2020 23:55:01.5056 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1NAM04HT202 Message-ID-Hash: MJ65G2LRSH5KD2T2TTKUEMYK7JVM4NPG X-Message-ID-Hash: MJ65G2LRSH5KD2T2TTKUEMYK7JVM4NPG X-MailFrom: cole.e.helbling@outlook.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Cole Helbling , Alyssa Ross X-Mailman-Version: 3.3.0 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: On Sat May 30, 2020 at 7:00 PM, Alyssa Ross wrote: > These changes make chromiumOSPackages.updateScript better understand > the Repo manifest format[1]. > > It now properly distinguishes between paths in the Chromium OS source > tree and paths on the git servers, which are usually not the same. > For example, chromiumos-overlay is located in the source tree at > src/third_party/chromiumos-overlay, but on chromium.googlesource.com > it's located at chromiumos/overlays/chromiumos-overlays. Components > are now keyed by their location in the Chromium OS source tree (and > packages have all been updated for this change.) > > Additionally, it now understands Repo remotes. This means that it is > now possible to use a Chromium OS component like Minijail, which is > hosted on android.googlesource.com rather than > chromiumos.googlesource.com. This was not previously possible. > > [1]: > https://gerrit.googlesource.com/git-repo/+/HEAD/docs/manifest-format.md > --- > .../linux/chromium-os/common-mk/default.nix | 2 +- > .../linux/chromium-os/crosvm/default.nix | 4 +- > .../os-specific/linux/chromium-os/default.nix | 2 +- > .../linux/chromium-os/libqmi/default.nix | 2 +- > .../linux/chromium-os/minigbm/default.nix | 2 +- > .../linux/chromium-os/modem-manager/next.nix | 2 +- > .../linux/chromium-os/modp_b64/default.nix | 2 +- > pkgs/os-specific/linux/chromium-os/update.py | 56 ++++++++++++------- > .../linux/chromium-os/upstream-info.json | 40 ++++++------- > pkgs/os-specific/linux/kernel/linux-cros.nix | 2 +- > 10 files changed, 64 insertions(+), 50 deletions(-) Hopefully this means next time I can fulfill my promise of helping out... Fingers crossed Google doesn't change/break anything between now and then. Reviewed-by: Cole Helbling