From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.3 (2019-12-06) on atuin X-Spam-Level: X-Spam-Status: No, score=0.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FORGED_SPF_HELO,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS autolearn=no autolearn_force=no version=3.4.3 Received: by atuin.qyliss.net (Postfix, from userid 496) id DFCAA21EDA; Fri, 29 May 2020 18:51:43 +0000 (UTC) Received: from [127.0.1.1] (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 4E74321F32; Fri, 29 May 2020 18:51:38 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 496) id C262521EB9; Fri, 29 May 2020 18:51:36 +0000 (UTC) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11olkn2109.outbound.protection.outlook.com [40.92.20.109]) by atuin.qyliss.net (Postfix) with ESMTPS id E312D21EB7 for ; Fri, 29 May 2020 18:51:33 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VzrN6wWOOR0HnTOEny3TlNdBZmF9BNXFUdI8mJ8mJ7OVSXrKPBt2AEcWECEwvdkDufDl6bJKdmlCy+kudPfGkHZkH+XY82VBRbMKU/ZbkRMsCbWajalw76Q0pRN8K4nbf8gt+PX6QGZ5NohckROMmv+9dXp9yoxsFqzOdnk/88VM+CCg4zJ33xXrIl53rU4+PpHJ7K2crLIPOAVc2s29ler9lFs5DZEeWSF9mF/Fd84R7TyxL3RCuqPgBuFu1WuYVkX+k7B8kyTxkoPZTd6P8ec7vaSYslkC/tYhyd+Y4kBONksBOktPMJkSOHdF1j95DSFnkMAZVQLP9MF28fVaVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cGTvznTPvNX3EKmjNKiLkgNol6oOWLbWMsxAUqlSJvM=; b=JKYtS8/CZmtG5AvOLSppxwPtQfMNwIV+o1+sbd7/mj1Yswn/SMzk/2FXPT+cqV4LRRATR1LpqBl1/UC7B5fBoWqpR+ygQXaxbPy93Zmyy/aOj1KlRohGXbaspmpiYEzXgxtJkHsUaVxEkvMUmzpjlwpUh2+GU2b8q+1ZPlUxxOBktELJ7Zelu0EsiqoaUyeN9LEjvcOjagWdZX+/PpNGUcGHyt0lM2r0mCxKgHL9FQp8xLiT8zBk++f+lgraaZbECqvvOzZ9S8sVMgnVdMJjfdmfhCEAg/maOJsO0B+xZ3Oas2/CDdjPTnoIFOomM22Cz+YyLnPxFhmD+UHgkBNmUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=outlook.com; dmarc=pass action=none header.from=outlook.com; dkim=pass header.d=outlook.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cGTvznTPvNX3EKmjNKiLkgNol6oOWLbWMsxAUqlSJvM=; b=MD7vlE5LsrfFdi+yNcQAQCYO5IfuG4TtiXWQKBs4exmhmZmEzcPNSmoLfyVex+lRk02oPmSsTAL7mWI+Tgb6wovY2qswnh4PaDrADM4BORQxbauNm8eVZ7hIDTI9o3vMYWHMQhf3KzNkuryEKy8xAfpM+vj08vlAlkmb4lOZ7JwELQmPeBTgN80yW7IzYo8lePWaPreHoWQoenrTkqiDFqyGbaqwLMTKOskPpRK9tSKOZhgRcPKJtwxFDqCvpsaYH/iAHaHSUU+mFflCbbkcWjtI4EcSIJiimWnwfYWYuLvoZM1shhftbvEh48fUrmozz6DQaO4+Odbv7TLfVBLbig== Received: from BN8NAM11FT049.eop-nam11.prod.protection.outlook.com (2a01:111:e400:fc4b::4f) by BN8NAM11HT008.eop-nam11.prod.protection.outlook.com (2a01:111:e400:fc4b::202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3021.23; Fri, 29 May 2020 18:51:31 +0000 Received: from CH2PR14MB3579.namprd14.prod.outlook.com (2a01:111:e400:fc4b::50) by BN8NAM11FT049.mail.protection.outlook.com (2a01:111:e400:fc4b::413) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3021.23 via Frontend Transport; Fri, 29 May 2020 18:51:31 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:82C64572A14A38AF6C101D55F3C141574FDBE93B8ADF4FFFBF4AF51DB28FF082;UpperCasedChecksum:73384468FD1485DB45634B992AC2E2614E04D3F5041ACF58765AC73FAA316149;SizeAsReceived:8678;Count:47 Received: from CH2PR14MB3579.namprd14.prod.outlook.com ([fe80::2948:142c:3047:102c]) by CH2PR14MB3579.namprd14.prod.outlook.com ([fe80::2948:142c:3047:102c%5]) with mapi id 15.20.3045.018; Fri, 29 May 2020 18:51:31 +0000 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 In-Reply-To: <20200527232709.22211-1-hi@alyssa.is> Date: Fri, 29 May 2020 11:49:25 -0700 Subject: Re: [PATCH doc v2] Document crosvm memfd server From: "Cole Helbling" To: "Alyssa Ross" , Message-ID: X-ClientProxiedBy: BY5PR20CA0030.namprd20.prod.outlook.com (2603:10b6:a03:1f4::43) To CH2PR14MB3579.namprd14.prod.outlook.com (2603:10b6:610:62::18) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost (67.187.170.40) by BY5PR20CA0030.namprd20.prod.outlook.com (2603:10b6:a03:1f4::43) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3045.19 via Frontend Transport; Fri, 29 May 2020 18:51:30 +0000 X-Microsoft-Original-Message-ID: X-TMN: [Fv4zeq/lIMLZqbuTDSOq6/NwBtzx2h75] X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 47 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: c5483219-d85d-491e-81b9-08d804014d70 X-MS-Exchange-SLBlob-MailProps: gjx25WM8ZNWDLNYE12708/BbGTepinvywLZ8Ie04waAB+95UJbDq+hYdCPNsx3rQeOjBP3VW20aEV04HyvUvU46pbzBJ2bfRwCFOURsP5iwxd9jxUiQJR8D1fJ1ulv0AITkoG5FEsNd5izAP4ThwReb/v2i5HwdWBNZ2lfzsArNk9m1wAxprDhPlNPDXo/QTCgBld/dnxZlgFgqBLDfBJmR57xsev7WnTZQqvCCxfmr38AG8rQzyg5wL/9+yRTzc3fhoNIGs+r34d6KWOCB0sB2aLs0C1TsXUJfXwxnx7b+W8Q57TEsbn+6AhrbnJd1RPEf1L9MWIjI8uWBXrcMVR7qW1BYxzQylo2u4p8rk6LecHv+wvN3olKPOlsIFfiEzue76qHTvXmKvu/M0DKxntlJoE71YOH3QohRW5iz6YzZF5Epwff+WxOAXkXLYyao6fUFxIcDz8xeTn5dgSyr5t7vNdM7p+aJuTnx1c/hLvJxPDMzq0zylxUoaN5SiTsCLBA8VS5EZZP88EPRJ0+pJiHo+VXLl3e79zjENJjZevv/wxiwKk41CILDdWjuduvJB7LOUXfjxtPNs1MwN+480hcXknLNJoKXimXN5W97Kn5vOoiErzjGNEZ1e1iUaEEWlS7uC4FmQaL7pkLl6mY9uLg+jN65UrkeT9tEj6mprC5unWNL/zNaq9706wPZPfWTm9fJATe1QhotiCLyAq0Hyoz3QtmfS8nQuOW2TBPq+cGo= X-MS-TrafficTypeDiagnostic: BN8NAM11HT008: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /AY/Ff6My4YQ1hyOc1a9KcabLzaUWb2S+WEI2e2rxa3kOb6nY/bZbc9A0GnOMlnFFdQQgxuK4WmQ/Ahv8PKtPhsZtKmfbHrZZjFFE/SOQRkbID7jEIEXMaV8LOteR5xHVjaMczdjoblcUBnLqFpD1sFQFoPnD0DwkhsEk4sYfs8nkymV8EPrJNXrsUaqCQvRba5xtPEtT0K6mVT1S7bNFg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:0;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR14MB3579.namprd14.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:;DIR:OUT;SFP:1901; X-MS-Exchange-AntiSpam-MessageData: dRGZ30Dj0y+Psf64o8cZclOwsxa6roRX/QUbJHtNHpS5Z7WOeG1VKY7o36Lt9VZshLuGKOOEwfC03omKPWkEP0wijRhYWuc/Kgit6FsuCZGHUNpirUSBO8AQCqShprHEAwSB/ZKvu7QR3Vsc9vb/Mw== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c5483219-d85d-491e-81b9-08d804014d70 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2020 18:51:31.7146 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8NAM11HT008 Message-ID-Hash: Q3NK24GSYL7TWZDRUEPFZJ7HHKUQG3MD X-Message-ID-Hash: Q3NK24GSYL7TWZDRUEPFZJ7HHKUQG3MD X-MailFrom: cole.e.helbling@outlook.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Alyssa Ross , impaqt , Cole@atuin.qyliss.net X-Mailman-Version: 3.3.0 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: On Wed May 27, 2020 at 11:27 PM, Alyssa Ross wrote: > --- > Thanks for the comments. Should be addressed now. > > Please take a(nother) look. If you think it looks good, I'd > appreciate a Reviewed-by tag from you. :) > > (Last bit is just something nice for me to put in the git log, > e.g. Reviewed-by: Alyssa Ross , and means that you had a > look and don't see anything wrong with the changes. By convention > those should be sent by the reviewer rather than just made up by > me. :)) > > developer-manual.adoc | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) LGTM. Sorry for the late response! Reviewed-by: Cole Helbling