patches and low-level development discussion
 help / color / mirror / code / Atom feed
From: Vadim Likholetov <vadim.likholetov@unikie.com>
To: Alyssa Ross <hi@alyssa.is>
Cc: devel@spectrum-os.org
Subject: Re: [PATCH] Patches to waypipe package to enable static build with the cost of fancy feature
Date: Wed, 30 Nov 2022 15:06:40 +0200	[thread overview]
Message-ID: <F87BAD0F-C2FD-48FE-8AE2-37F73ADDC26A@unikie.com> (raw)
In-Reply-To: <20221130113241.2ljoxhxn5oqvsfqk@x220>

I think that’s not bad idea — lets’ push it upstream.

> On 30 Nov 2022, at 13:32, Alyssa Ross <hi@alyssa.is> wrote:
> 
> On Wed, Nov 30, 2022 at 09:14:09AM +0200, vadim likholetov wrote:
>> Signed-off-by: vadim likholetov <vadim.likholetov@unikie.com>
>> ---
>> .../applications/networking/remote/waypipe/default.nix | 10 +++++++++-
>> 1 file changed, 9 insertions(+), 1 deletion(-)
> 
> Having pkgsStatic.waypipe work in Nixpkgs would be cool (even without
> acceleration), if you're interested in pushing this upstream.  It would
> have to conditionally disable the problematic dependencies so that there
> was no change in the dynamically linked case, of course.
> 
>> diff --git a/pkgs/applications/networking/remote/waypipe/default.nix b/pkgs/applications/networking/remote/waypipe/default.nix
>> index ec94d504b9d..bcc3770ecf7 100644
>> --- a/pkgs/applications/networking/remote/waypipe/default.nix
>> +++ b/pkgs/applications/networking/remote/waypipe/default.nix
>> @@ -20,7 +20,15 @@ stdenv.mkDerivation rec {
>>   nativeBuildInputs = [ meson ninja pkg-config scdoc ];
>>   buildInputs = [
>>     # Optional dependencies:
>> -    mesa lz4 zstd ffmpeg libva
>> +    # mesa lz4 zstd ffmpeg libva # TODO: one day recompile with acceleration
>> +    lz4 zstd
>> +  ];
>> +
>> +  mesonFlags = [
>> +  "-Dwith_video=disabled"
>> +  "-Dwith_systemtap=false"
>> +  "-Dwith_vaapi=disabled"
>> +  "-Dwith_dmabuf=disabled"
>>   ];
>> 
>>   meta = with lib; {
>> --
>> 2.36.2
>> 
>> 



  reply	other threads:[~2022-11-30 13:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-30  7:14 [PATCH] Patches to waypipe package to enable static build with the cost of fancy feature vadim likholetov
2022-11-30 11:32 ` Alyssa Ross
2022-11-30 13:06   ` Vadim Likholetov [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-11-29 23:01 vadim likholetov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=F87BAD0F-C2FD-48FE-8AE2-37F73ADDC26A@unikie.com \
    --to=vadim.likholetov@unikie.com \
    --cc=devel@spectrum-os.org \
    --cc=hi@alyssa.is \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://spectrum-os.org/git/crosvm
	https://spectrum-os.org/git/doc
	https://spectrum-os.org/git/mktuntap
	https://spectrum-os.org/git/nixpkgs
	https://spectrum-os.org/git/spectrum
	https://spectrum-os.org/git/ucspi-vsock
	https://spectrum-os.org/git/www

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).