From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FORGED_SPF_HELO,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2, SPF_HELO_PASS autolearn=no autolearn_force=no version=3.4.5 Received: by atuin.qyliss.net (Postfix, from userid 496) id 0EBB223D37; Tue, 18 May 2021 15:46:17 +0000 (UTC) Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id D5C5A23D81; Tue, 18 May 2021 15:46:02 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 496) id 507F023D0C; Tue, 18 May 2021 15:46:00 +0000 (UTC) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12olkn2094.outbound.protection.outlook.com [40.92.23.94]) by atuin.qyliss.net (Postfix) with ESMTPS id C97BC23D0B for ; Tue, 18 May 2021 15:45:56 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PLRg3Y475wsc2c99NPQGhNQCiTDeYyffY36XW4aU2pHb5BQDiub1ommwpbxlyulCz5wE6nFCE+VSPLWu7olzQjWvZQUjDSKqZ50w75k0aT183in/M+DgJo3/FhBDaEno2Ivj27c5hpOKlcvLt1Qa4Xnp7aK7JJ2hmWC8f5+rddDgLEqiimnIjL7w5mBurubHoDZ0jGQ/ZuVFhIzzDZCd86OD75GVmr64a4+agjpoEYpQJPjaCSIyphAwBxnzqC9n1UbQ5I1Iv67v8KRtbvpqpcxikcXAmMDFosXqyveUNI9IA6YnExd4W2PslPE0IuuvY4269IPeJba9ZA2PsZpyZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KmU/+mjAx47145jH2lh3UtQv5hgx65wLGsX/Mw56OUo=; b=KWxHYMFISOMXMSHy12ZOe0XVCoofaUxkyRtjZanoyF0SbQV5zPzB54Q4LwHnmI+zNDKxeqKdqZE9zjluLkLOwCGz42M5t5WOlt951Ym2gY8CJDJ7AyAm70QCjHnNJZ8lGbHX6wZil+D9llhAcQGKgMq5WGDfYbGWFI/zGiEg0m6gGWTgJHxOq1M5Wqehgj/JKF4U5rQzYjyXyGXW7yiHRSclICmRAv50DpiiBnKh1cf9/pGnZIeRLHxSnFTis0HXVPNKtYalt3wTkPsC1u3oQYn0Mg920BrQAXSeZRgu6cMYbubHbhZ4tz/ZihLJra33VpeAYmDKKKucxpgpwlnexg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KmU/+mjAx47145jH2lh3UtQv5hgx65wLGsX/Mw56OUo=; b=GKnRRkFLuZt4CNS/wV9ooXRwXLYcxNdeAtxq++/9kVzSZc8ROHvHzxLc5DNEM2YBBqKztoD7fPtczXuMir4G8TeGeJ0fLDAPd4gqqQqwnpUHIb8mWmsw9Oq//U9+a65/nZNVTeMaXqWBZwPtnXPZC38hX9KqZJxaosDRRWJyMn63F1n/Hhpd7WhGVaW1V1nheTrzrKpa0sBZX4YN2n/y/pX7tF/w7ONJRztiNLgSD1PM4HywsS5Z1PznCVmGhQDh1qym3U9JGmn2j3MCU4aw75DX4qRhMHPaI0QQeEzWHiV0wr5dj+dqqpCepGiTSLsYEZHbKVgDl1JEkmWRR3jXZA== Received: from DM6NAM12FT051.eop-nam12.prod.protection.outlook.com (2a01:111:e400:fc64::41) by DM6NAM12HT007.eop-nam12.prod.protection.outlook.com (2a01:111:e400:fc64::98) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.11; Tue, 18 May 2021 15:45:53 +0000 Received: from SJ0PR03MB5581.namprd03.prod.outlook.com (2a01:111:e400:fc64::4f) by DM6NAM12FT051.mail.protection.outlook.com (2a01:111:e400:fc64::105) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.11 via Frontend Transport; Tue, 18 May 2021 15:45:53 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:8B966F2493FAAC96FB62E679827F7AB010EE60C7AF343C4D1869EE14210B531E;UpperCasedChecksum:557768BDB955CA4BCBD149FC148630524EEA6DD358FE2543075FF922829207B4;SizeAsReceived:8454;Count:45 Received: from SJ0PR03MB5581.namprd03.prod.outlook.com ([fe80::2437:eb29:a6eb:76fa]) by SJ0PR03MB5581.namprd03.prod.outlook.com ([fe80::2437:eb29:a6eb:76fa%5]) with mapi id 15.20.4129.032; Tue, 18 May 2021 15:45:53 +0000 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Subject: Re: [PATCH crosvm v2] crosvm: support setting guest MAC from tap-fd From: "Cole Helbling" To: "Alyssa Ross" Date: Tue, 18 May 2021 08:43:58 -0700 Message-ID: In-Reply-To: <87wnrwtp4b.fsf@alyssa.is> X-TMN: [M7eCdSD2Kuq6fQhn8kSm8ax6R5LCcxvf] X-ClientProxiedBy: SJ0PR03CA0276.namprd03.prod.outlook.com (2603:10b6:a03:39e::11) To SJ0PR03MB5581.namprd03.prod.outlook.com (2603:10b6:a03:27b::20) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost (73.48.197.220) by SJ0PR03CA0276.namprd03.prod.outlook.com (2603:10b6:a03:39e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25 via Frontend Transport; Tue, 18 May 2021 15:45:53 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 45 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 54d1a0d1-ff56-4239-18fe-08d91a1404f8 X-MS-TrafficTypeDiagnostic: DM6NAM12HT007: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /wZCyVNDmPRdN4nejnvLqn6zOUr1sHu+L+ToK9rQme2FshOLf2sFyN97Ep+45MniTcNolkRnZV/vJn00mybkbuQnZXI1Kf3a+REQ2IjuP7kRMl897Hs/DRJQN1b2NHCx7N1E6jXjvXHEZxdXa5N7znuoMK68rcHCUGT2M1oy2zJok4G/wtb1tj5EdDdZc+2uV9BzkFhfXLTgwEje2YIEhMnUTSHYzes7Ek1EWM8eoJKoKKoOHF/Bge+f7Kx66SaDJGNq9jNeUrEk8RTtr7a3R2C0BdutivHitelQw3gv/eFyCFATqUipu/h6v3N87/zhYSWPhx5sfmuXJE2omlDcLndk+9N+F0ph6aEWQ3WfvnZjQ7gJ6CZM/J1OVG4bxYwvZmJI3P2GXzMKb1qDY71McEkz+4vcoSZ4oxqhKaOPwpjhaFxTuW4n8QDaaELwq91JxD9NWa+0OTTT/jWNm0u6RA== X-MS-Exchange-AntiSpam-MessageData: dxaqlWclF9/8VDQUyMspnnBhYK8MxA+M6jbymceLkmqKIlRrMI/8Z1sw6w0swJQ/YZPWeo1zi7mozr38BolAik3PXG9DxmaEHu6/lDtviGDtUDyXyQ4Eoy4vqsIbvhBIxxZYC+YIc+K+DEprp3x2EA== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 54d1a0d1-ff56-4239-18fe-08d91a1404f8 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2021 15:45:53.7151 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: DM6NAM12FT051.eop-nam12.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6NAM12HT007 Message-ID-Hash: TPRUEHQLUX5GVD5PI62VN5UGPJEWJPE7 X-Message-ID-Hash: TPRUEHQLUX5GVD5PI62VN5UGPJEWJPE7 X-MailFrom: cole.e.helbling@outlook.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: devel@spectrum-os.org X-Mailman-Version: 3.3.4 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue May 18, 2021 at 1:36 AM PDT, Alyssa Ross wrote: > "Cole Helbling" writes: > > Is there a better Error variant for this? `TooManyArguments` seems not- > > completely-accurate when specifying an already-in-use FD. > > Here are all the variants. Do you think there's a better one? > > https://chromium.googlesource.com/chromiumos/platform/crosvm/+/f35d2c43ff= 19520855cffee761dc8899c5a439a1/src/argument.rs#49 > > The only other one I can see that might be applicable would be > InvalidValue... Yeah, I think InvalidValue would be a better choice (IMHO). The user hasn't provided too many arguments; they just provided a invalid TAP FD because it= 's already in use.