From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FORGED_SPF_HELO,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2, SPF_HELO_PASS autolearn=no autolearn_force=no version=3.4.5 Received: by atuin.qyliss.net (Postfix, from userid 496) id 1ABEB1C212; Sun, 30 May 2021 02:21:02 +0000 (UTC) Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 12AC11C1FE; Sun, 30 May 2021 02:20:53 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 496) id 84EEF1C1ED; Sun, 30 May 2021 02:20:50 +0000 (UTC) Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam08olkn2028.outbound.protection.outlook.com [40.92.45.28]) by atuin.qyliss.net (Postfix) with ESMTPS id 0E7801C1E8 for ; Sun, 30 May 2021 02:20:46 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Bwfee8Cz0LnDtQNhXIEM5xOAYOitjq6M+zjHrr509QcaRCXOy3/u5/cEUzPbvlkxGpiO4C3c9losjoO3PCu/JkF2djQj2IUIXG1XG6CMqf9VGXGdROoriy0+T+Ze1sHEdiZ2m33zvMyxMEbXv8dci6/80T1e4hH/u5TZfvvBGJQH0yNbDLTx5XXJqvfRf6bIe13+xuiypLrPcieikwOpRJO0vAMxtQfYv8fmWCSGXzBbcy/JDz5LbiNOEUlmxpkQfkPpUFpUEA35cDQPpiX5v6AzRTNhOzprtcIAPWsdSmc6CjPSSppQ8JQf+Go8qih6R6viEBc3QpejkbTyYfVKgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/R+73YjINPktr1AtjaloWMqBMR1NhrWRxPQC2GnE7Mc=; b=NN53EShFMENrPZwyvCSbBJYnRprZ2itS48aW3qqqHWS7dFvuSI5YLwDdYGJLa3/iyhatIPL2+oLhcCfMJakp6RV9k/Cgacva+b3l7EhX/wHOkq+caVHyEkR41SkxxOkV7Zg3HDZu8iCUHacKUmiCdyaHi/aAvQVwdFCPjDmmbma73b34on8ZtnqdCRCxgeoqigBUQS90oUgp20mlHbRh/VSypkPFtG7kZEcNM5yXs9Gbh/g+G7s006fnwG5fl48QVIlEcg9V5lswmb+Z8LzPCboKXEwUkp7yzDJLJUJow5eInsQZstLdfi+xNGYelL8VJ6lz2mn12Qm+jtXUR1cKmA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/R+73YjINPktr1AtjaloWMqBMR1NhrWRxPQC2GnE7Mc=; b=bO9rsrWtibgUKIZtobbI8ZvgnsvkXLS+PC22KQ+zvtM0Gm3c3gXlPm2cRHWiYTBt13rCdeWqSc9dGuqrAY6LBcrdUdipHBuOqPB1i1waTTRlIwtP7XJSsoQ1xuyOqr0QxwAsWtzoMTDrOxRQb46KfP7IomUSDGYTnkxTkhy0Ck9i/OndYvR57+3CdJ5EMj/9Z7flIDO4DlveHzPwZu0noZzo/TcQtApk4T32jPWFMYgyXz7SwALAg0kns1iEMTqtn7wG2vJHuE/EAalm2JQ7mffLqI2JXJUyw0BApy9NFLSIT2uFdWq2jnx9YW48QoHac4SusOG8U5TcUx9kvkb6pw== Received: from BN8NAM04FT048.eop-NAM04.prod.protection.outlook.com (2a01:111:e400:7e85::53) by BN8NAM04HT089.eop-NAM04.prod.protection.outlook.com (2a01:111:e400:7e85::175) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.30; Sun, 30 May 2021 02:20:44 +0000 Received: from SJ0PR03MB5581.namprd03.prod.outlook.com (2a01:111:e400:7e85::49) by BN8NAM04FT048.mail.protection.outlook.com (2a01:111:e400:7e85::350) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.30 via Frontend Transport; Sun, 30 May 2021 02:20:44 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:30559F5A46FB9A803C3A1B6A2F769786373F0D32AF7C86A872D22FB9CCFA4C40;UpperCasedChecksum:A3D1AA9E708F325C6D51E4F9F6B651410BAC3C014FFC26F3563165FBFCC17EA9;SizeAsReceived:8454;Count:45 Received: from SJ0PR03MB5581.namprd03.prod.outlook.com ([fe80::2437:eb29:a6eb:76fa]) by SJ0PR03MB5581.namprd03.prod.outlook.com ([fe80::2437:eb29:a6eb:76fa%5]) with mapi id 15.20.4173.029; Sun, 30 May 2021 02:20:43 +0000 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Subject: Re: [PATCH crosvm v2] crosvm: support setting guest MAC from tap-fd From: "Cole Helbling" To: "Alyssa Ross" Date: Sat, 29 May 2021 19:20:19 -0700 Message-ID: In-Reply-To: <87h7ilr5sw.fsf@alyssa.is> X-TMN: [gOGJl+EtdQ7fOidub2z9yYnCccDhk0bS] X-ClientProxiedBy: BY3PR03CA0026.namprd03.prod.outlook.com (2603:10b6:a03:39a::31) To SJ0PR03MB5581.namprd03.prod.outlook.com (2603:10b6:a03:27b::20) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost (73.48.197.220) by BY3PR03CA0026.namprd03.prod.outlook.com (2603:10b6:a03:39a::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4173.20 via Frontend Transport; Sun, 30 May 2021 02:20:42 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 45 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 3c34b4dd-3038-4af5-af11-08d923118697 X-MS-TrafficTypeDiagnostic: BN8NAM04HT089: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: i21LplEuxkg+Q+hpcoOK+fJqAmpa5Sgw7sZq7KpBriEP6GYWGEM+gpMSO4aEkRStWBVaH+jkCppihzhcuLxT/mgtSPIbh2vbVy29FLIJNKozMLalhu8Tf/5CckJMrujGA3a23I4pMIdHatsy71nx81FvE4uBfHMUOb/bMVOtrfDrFvzMZHDGjIf/C+LB9+jDYcSQDuheiby2bdgCM6ywFZpq5gaFJ6nkn+VF2s/X8n+Na01w4k0B1YMXs0b2bbsjIQ76zgiExUnSh+0xNxzWfxpx+u6iwWRJlzmDhN5KgHpfY9WHonIuJhjZRxYAWQUncDKthm91Fv98Nhgmo+CP1iKcqRHZrYS1BvRt9W5UfRK2VUov1uv5obF+Hxv6Ua01Ymmuf8puJ1zDR2ubGidPr8CsHjnUwvB9W8c8Hs0z1ld2Ymghegc+F8jrJ2q3No9AIPuAI4wr6aNwEhRnfNJy3g== X-MS-Exchange-AntiSpam-MessageData: 8EaC5vJztXH21Qi/JsuSOt9/zSErLqex2cgzXqeUla/IbrF1eFb8btaNK8ZVd/ZFqXEqsFFCKMgAkSfWf2wWpEmGp4SHnUccCyIVBF1f9K3P4FC/tCtKiw0kDXYTj+190ZBNOTlgbF5Ix0HHcKnoZw== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3c34b4dd-3038-4af5-af11-08d923118697 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2021 02:20:43.8558 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: BN8NAM04FT048.eop-NAM04.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8NAM04HT089 Message-ID-Hash: W3J7LC2VZZM3CAL3ZRNMD3LZUFVIH26H X-Message-ID-Hash: W3J7LC2VZZM3CAL3ZRNMD3LZUFVIH26H X-MailFrom: cole.e.helbling@outlook.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: devel@spectrum-os.org X-Mailman-Version: 3.3.4 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Sat May 29, 2021 at 7:08 AM PDT, Alyssa Ross wrote: > "Cole Helbling" writes: > > > On Tue May 18, 2021 at 1:36 AM PDT, Alyssa Ross wrote: > >> "Cole Helbling" writes: > >> > Is there a better Error variant for this? `TooManyArguments` seems n= ot- > >> > completely-accurate when specifying an already-in-use FD. > >> > >> Here are all the variants. Do you think there's a better one? > >> > >> https://chromium.googlesource.com/chromiumos/platform/crosvm/+/f35d2c4= 3ff19520855cffee761dc8899c5a439a1/src/argument.rs#49 > >> > >> The only other one I can see that might be applicable would be > >> InvalidValue... > > > > Yeah, I think InvalidValue would be a better choice (IMHO). The user ha= sn't > > provided too many arguments; they just provided a invalid TAP FD becaus= e it's > > already in use. > > Hmm, I agree with you, but I just went to make this change, and noticed > that everywhere else in the file, they use TooManyArguments for this > sort of case. e.g. "wayland socket name already used". So I think it's > probably best to stick with TooManyArguments for consistency (and that's > probably why I did it like that in the first place, although I don't > remember). OK, that's fair. Reviewed-by: Cole Helbling