Re: [PATCH ucspi-vsock 7/7] Extract vsockserver-socketbinder and vsockserverd

Cole Helbling
2021-03-21T02:55:37Z

On Sat Mar 20, 2021 at 1:24 PM PDT, Alyssa Ross wrote:
> On Thu, Mar 18, 2021 at 08:39:31PM -0700, Cole Helbling wrote:
> > > + if (listen(fd ,40) == -1)
> >
> > Minor formatting nit (comma, then space); but also, what is `40`
> > representative of? Should this be `#define`d, or otherwise assigned to
> > some descriptive name?
>
> Looks like the next thing I should do after this is set up clang-tidy or
> something. ;)
>
> It's the backlog parameter, i.e. the minimum[1] number of connections
> the kernel should allow to queue up before it starts rejecting them.
>
> Would the following additional diff make you happy? :)
> (I won't bother resending the whole patch with it applied; for the
> purposes of reviewing just pretend this is part of the patch I sent.)

Yep, looks good to me! Though if I'm being greedy, maybe add the above
explanation as a comment above the new variable? ("It's the backlog
[...]")

Entire series looks good as well:

Reviewed-by: Cole Helbling <cole.e.helbling@outlook.com>