From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FORGED_SPF_HELO,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2, SPF_HELO_PASS autolearn=no autolearn_force=no version=3.4.4 Received: by atuin.qyliss.net (Postfix, from userid 496) id 01BCB6E65; Thu, 18 Mar 2021 06:56:40 +0000 (UTC) Received: from [127.0.0.1] (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id EB4466DDE; Thu, 18 Mar 2021 06:56:28 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 496) id 6636E6E2E; Thu, 18 Mar 2021 06:56:27 +0000 (UTC) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12olkn2078.outbound.protection.outlook.com [40.92.21.78]) by atuin.qyliss.net (Postfix) with ESMTPS id 475C06E2D for ; Thu, 18 Mar 2021 06:56:25 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mU9aVeCq1onNhjIvUNXB58qyUMTBepBxyGXkCtM479N398yeWNhCocZQHu87mEE6d/9zUfdbixPZBJgy92epmsW30x5nT50VdDTvY/uFO5m/kg+72Kj80hFT13gVY+mrnkX/Lh08SrnA8YaWKZ0i29B496ymUrACjVCFr7Sqq2OZCAHiLeJ3gIjaQXJ2JyR6Oov7gv6ccxeb+vyK3XMvWM7nwdm/seOhDZ0eNvTbfJgCvmQAknmSGeqO+vqUOfZG68aQNGevSafM4NfHwuClNuFG8+4IqPuEl58HjlOgKcIlmpY6NHNIMq2GXc93YZIHWJQ9mZE+bF9QGbWFv6rV2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3zPiTwii2lpSKt6OTAPfMYUKU16fA/Fk1ZBHQQaJ9Rs=; b=EeKz2KvRZ9PmLByqQ2sHdZWko1rSEPUsvZhcnT3q9hQ5OuL6cJK4IWUF1i8VtSa1Ez5b78iSa3sazvn2siOIZy3XwJIzFmBgzpcNHZihFoGcNfKvb5iH4EyYb3ZvHBX7gwkHRAZ3y0Z94YswP5GcmXGqvthEHlGnUgYMFClqbpexnRM00ZOpAmnsWbrJXdpCdoC23aHROzzKOEACulcdnaeSQB//GNHLZpX9o5U2Jxoltw2XUlsbgu6XhSQoDWd6bRqIRa1mU+HG8N+WP9lq07baCv2d937DovI1YeSB/80NEVl9g5bjP6O4doIOqrnLLwaN9uDBwv+/xce+JkqYYg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3zPiTwii2lpSKt6OTAPfMYUKU16fA/Fk1ZBHQQaJ9Rs=; b=EYMd7D3F5Riurm4CzvsXn5ARvbwi7w5YYhTcC1D1vFG/koCsoavqrITVvsmnWAkjJLIrf0cMVMzfY20h3Msq7Im3ve2qcJngPnnMA5/Ghc3NNL+DQEZkxev+QFcZuLUJxxLGy1Bx0RwUo4qMzYNSe+gxllt7KKjDfDft416suIl1Bd5DITjI/tVAAUPNICCxm1e9stC7i1VxJjAB18mX6vLECSG1R/KbDB+P76r7KbJJvq7s8QHpU4nwHhXscuqHsqhnTpK9Y6OtGsFFVp5WLi14GzU9/PJcigi/4P3KTXJVsXHZrDBMJjysWcPLQDeavZhhs3OUzBP84Ky4dgMBmg== Received: from MW2NAM12FT035.eop-nam12.prod.protection.outlook.com (2a01:111:e400:fc65::53) by MW2NAM12HT007.eop-nam12.prod.protection.outlook.com (2a01:111:e400:fc65::328) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.9; Thu, 18 Mar 2021 06:56:23 +0000 Received: from SJ0PR03MB5581.namprd03.prod.outlook.com (2a01:111:e400:fc65::41) by MW2NAM12FT035.mail.protection.outlook.com (2a01:111:e400:fc65::274) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.9 via Frontend Transport; Thu, 18 Mar 2021 06:56:23 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:41A25A944D21C5379A19C906ADA258261D44A2A3643437383FDF8EE64CBC5375;UpperCasedChecksum:789D01DF9FB4F6C6CCE439A19C8DF22CDF0A79027FF4CB7D820E5FC482660FA0;SizeAsReceived:8460;Count:44 Received: from SJ0PR03MB5581.namprd03.prod.outlook.com ([fe80::ed0b:679f:905f:4c94]) by SJ0PR03MB5581.namprd03.prod.outlook.com ([fe80::ed0b:679f:905f:4c94%5]) with mapi id 15.20.3933.032; Thu, 18 Mar 2021 06:56:23 +0000 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Subject: Re: [PATCH ucspi-vsock] Factor out set_verbosity() From: "Cole Helbling" To: "Alyssa Ross" , Date: Wed, 17 Mar 2021 23:55:48 -0700 Message-ID: In-Reply-To: <20210318003530.13208-1-hi@alyssa.is> X-TMN: [WywBSrnOHVJ/2RO/ik95peXov2kfv0Rs] X-ClientProxiedBy: BY5PR03CA0021.namprd03.prod.outlook.com (2603:10b6:a03:1e0::31) To SJ0PR03MB5581.namprd03.prod.outlook.com (2603:10b6:a03:27b::20) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost (73.48.197.220) by BY5PR03CA0021.namprd03.prod.outlook.com (2603:10b6:a03:1e0::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18 via Frontend Transport; Thu, 18 Mar 2021 06:56:23 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 44 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 94ac85bf-f023-428c-a217-08d8e9daf143 X-MS-TrafficTypeDiagnostic: MW2NAM12HT007: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zydgGU53GhbqakLotj0B8S9h0rUjs85eRWewqyjWomy/uCWdAUAeP0dME29b4f8fU75Mo3x3V8xaAT3WzJ457oy40MRw0q9uor78p3WGImW1chQofKEGvYIwzYL5qiHxKarT8l2JvWFvxc9nFprVsyXW9erPH6HjPGGzJ4M7GMMCWJUgZpsYw90D23SrIKuVA9BdnEM8CuClmJ2XMUhScWYq+ADoTCqxfUypZdalGKfKRJK8Wks3I7ZzMoBovbR7mEzZ0f+1hCo0ksA/V7nQlA0qUee6LBI09wCYj6DpOReXLBU4uQRr33fg0B+gUAxQxfeN7KdIDHP/ij1mmKxCBFqDIqvARBM1l16IvU68BppuN8ijTo/MhBkG+eVRBVZfLMidMWfF0uC6D5kD1fMl5w== X-MS-Exchange-AntiSpam-MessageData: NhnpIiKky7vXV/G/fbzi0kgAND2bKnghsUwMAAj9c9UOQCmhg+YL+BzYu6A0Oo4dPA4h0HZJtRc3nmj/Vwmhnh41G7oH6u+3JJESWNKN+SWKAejpTQBuNnc6Lt3h2E/qOkGuqK00bP+3LJt+5qg9yA== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 94ac85bf-f023-428c-a217-08d8e9daf143 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Mar 2021 06:56:23.4919 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: MW2NAM12FT035.eop-nam12.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2NAM12HT007 Message-ID-Hash: 5V7BJPR3WNCAJE2EEUGF3KZBMFP3CSYF X-Message-ID-Hash: 5V7BJPR3WNCAJE2EEUGF3KZBMFP3CSYF X-MailFrom: cole.e.helbling@outlook.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.3.1 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: On Wed Mar 17, 2021 at 5:35 PM PDT, Alyssa Ross wrote: > This will save some cognitive load when reading main functions. > --- > log.c | 20 +++++++++++++++++++- > log.h | 5 +++++ > vsockclient.c | 6 +----- > vsockserver.c | 6 +----- > 4 files changed, 26 insertions(+), 11 deletions(-) Yay, refactoring! Reviewed-by: Cole Helbling