From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FORGED_SPF_HELO,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2, SPF_HELO_PASS autolearn=no autolearn_force=no version=3.4.4 Received: by atuin.qyliss.net (Postfix, from userid 496) id 43B6BAE63; Sun, 21 Mar 2021 02:55:37 +0000 (UTC) Received: from [127.0.0.1] (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 66EE7AE84; Sun, 21 Mar 2021 02:55:28 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 496) id 43D08AE41; Sun, 21 Mar 2021 02:55:27 +0000 (UTC) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12olkn2034.outbound.protection.outlook.com [40.92.22.34]) by atuin.qyliss.net (Postfix) with ESMTPS id 06CC0AE3F for ; Sun, 21 Mar 2021 02:55:21 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KEyhVBBGAWPlSJc2lPdBjMd1ELzK54JzNcNskCGpmxhOlFEXrN93qPzsst9Y44UmSD8qOH6IcVbFo+Y6Hh9h8EzcraXTej6c8G69Ibr3UgaTh8DoQdnEejzJWtHl/1EvtkYdmq4YUm1IywU2wjfwqrsK5KXM0WUlucSFqUcrad+ky5kL2GXnWYxTSbE/IAXdS+sg8CGOPu4YagX6q5as3gaeQAFWyN1bsHm29gZgECqJLJuUicbWL/c7UXFVhsrJLtBPYWdYCD0BC8p8/mxIMwYlxton5jIgrhG5NuIQLI7OoTTG3SOgywdpvFaXgUNJpUpXlnX1ysMmSIFUzYmfbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RUj45YuEjcpbGKJVEXwXCWbmgD894PSkImVVKg+Gjsc=; b=VMsIhYf0eRBJ4hLJ+5T+4bpGpC+sM3skjF2Jnpb+e7ZYwWcR+VLGaRpuNhhGovwuErUELTTeRuppHhnCu1oHO6gKKNCKBLMLo3noniFUYRWiEyDIUbUagUUNlWAhmdN/CbO0FKMqN74gU7+rk2C4Z4+ExcQdr9eyd8QkLzSuymq0uFWYvrd2f/oh5CHjujwVFePyGPCfVlyFEbYdl5KeO5xGzLMc9swRb5OpEkvphDpHwNBp+OKvITPijZ5hPH9aj/x/BNDasD2eS9K5pOcao3RZFKCRqo+QPVlfIEDvJwdH1bC5dnQRZnDz5+0URlffZ9sxC722AhPygqy+D2MkLw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RUj45YuEjcpbGKJVEXwXCWbmgD894PSkImVVKg+Gjsc=; b=dtiRQrhqFec/Vg8Ycal/g50kDrnN3hr2OWOEqDRAwHTBROLVNSlzqIzHloHFs/JxdnqUIC4AA/58N4KcM+NH51e668/a0r52uZlikPt2I9IkKPYnsEoDIBu0MHQOsAG/GLNHWjpbn9BUNrA/91Y7XoaK96/fLyNitxHs4DofdIkkIWEPm/zTqW0NLQwRNKFgkPhETabyXf8LkJ+/q0VCO8BB3+An88KaagHckcJT0hjkKvWxJ/Fq3vaoh6Z3DBoO/6f99zC9qPWwQGkX7gCe6WZBrIyAjD4cDKpkwG/j4F7lJoYmESfLdzk26fu0G7reoBffcn5rcub5LqDpBwKtAA== Received: from BN8NAM12FT062.eop-nam12.prod.protection.outlook.com (2a01:111:e400:fc66::51) by BN8NAM12HT079.eop-nam12.prod.protection.outlook.com (2a01:111:e400:fc66::63) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.10; Sun, 21 Mar 2021 02:55:19 +0000 Received: from SJ0PR03MB5581.namprd03.prod.outlook.com (2a01:111:e400:fc66::51) by BN8NAM12FT062.mail.protection.outlook.com (2a01:111:e400:fc66::321) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.10 via Frontend Transport; Sun, 21 Mar 2021 02:55:19 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:5D4E002C46323062425C89110FC653EE62DD557E6B2C414AB1FD9772ACB5EEA5;UpperCasedChecksum:942874F9D6056F8CE55E366BBAEC39AC87F0CF33C1D9E1955E354DA508E046B6;SizeAsReceived:8488;Count:45 Received: from SJ0PR03MB5581.namprd03.prod.outlook.com ([fe80::ed0b:679f:905f:4c94]) by SJ0PR03MB5581.namprd03.prod.outlook.com ([fe80::ed0b:679f:905f:4c94%6]) with mapi id 15.20.3955.024; Sun, 21 Mar 2021 02:55:19 +0000 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Subject: Re: [PATCH ucspi-vsock 7/7] Extract vsockserver-socketbinder and vsockserverd From: "Cole Helbling" To: "Alyssa Ross" Date: Sat, 20 Mar 2021 19:52:00 -0700 Message-ID: In-Reply-To: <20210320202441.m4leazkzrgduofwz@eve.qyliss.net> X-TMN: [tCaaEDH53RJ9CvlC6gX9r5tZPKf38KHX] X-ClientProxiedBy: BY3PR03CA0018.namprd03.prod.outlook.com (2603:10b6:a03:39a::23) To SJ0PR03MB5581.namprd03.prod.outlook.com (2603:10b6:a03:27b::20) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost (73.48.197.220) by BY3PR03CA0018.namprd03.prod.outlook.com (2603:10b6:a03:39a::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18 via Frontend Transport; Sun, 21 Mar 2021 02:55:18 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 45 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: dc8a1f74-d45e-4145-8a62-08d8ec14c310 X-MS-TrafficTypeDiagnostic: BN8NAM12HT079: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: og52RJkLXVeD3cs18++/6rqm3dYITXiSgM2+wvf7Ac0rsbiNpCJoNvUhvIepA5vQEm+yqtVQ8FAy8ql1Oxw4jUcJnAARmAOCkiy+0NWwd7tM3lufQiMd0I9QgpDBgEwX9gr/vSsva9NytltyPAE4Q3ALW0RVBiQ6QMNM4jCtm4/EY1Eddmzo62yUgph3uEhT1oIWYZJppSD3P+snAErdZUHMzbfJV50x6Dg4KhS/p0fZg/F3oTmFdKabfMN2ov5/8yHW65koZUkZFyio1PriHRMnpnrMCjyNwpLG3/e4IbyQ3+3F6aSvrGyhBCvSrOwQzBZR4HbKyasDk/gFzq4GUuyNWAgFiCDD563e18d8TMWKCGm48dK5rV9ZfTG8wNjjx7WCGprbr/x0iWpIcpytmw== X-MS-Exchange-AntiSpam-MessageData: gJAUBLK017TrUhn1mEpej+J7930s7RUWSEps7mN8bCu5wKlDxsDuEG6+ZJzKNCRrgdUkqzTOJEu0Ru1xSZZQyoMjdH9wbxYrGX7F2B5uf3SeP3ZFkg9p2VsVQYg6A9M98O4tAO2syfZpv30qLy+45A== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dc8a1f74-d45e-4145-8a62-08d8ec14c310 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Mar 2021 02:55:19.3687 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: BN8NAM12FT062.eop-nam12.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8NAM12HT079 Message-ID-Hash: GKKM5376KSYWSTELYJ465G7IAFE3OZJ2 X-Message-ID-Hash: GKKM5376KSYWSTELYJ465G7IAFE3OZJ2 X-MailFrom: cole.e.helbling@outlook.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: devel@spectrum-os.org X-Mailman-Version: 3.3.1 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: On Sat Mar 20, 2021 at 1:24 PM PDT, Alyssa Ross wrote: > On Thu, Mar 18, 2021 at 08:39:31PM -0700, Cole Helbling wrote: > > > + if (listen(fd ,40) =3D=3D -1) > > > > Minor formatting nit (comma, then space); but also, what is `40` > > representative of? Should this be `#define`d, or otherwise assigned to > > some descriptive name? > > Looks like the next thing I should do after this is set up clang-tidy or > something. ;) > > It's the backlog parameter, i.e. the minimum[1] number of connections > the kernel should allow to queue up before it starts rejecting them. > > Would the following additional diff make you happy? :) > (I won't bother resending the whole patch with it applied; for the > purposes of reviewing just pretend this is part of the patch I sent.) Yep, looks good to me! Though if I'm being greedy, maybe add the above explanation as a comment above the new variable? ("It's the backlog [...]") Entire series looks good as well: Reviewed-by: Cole Helbling