From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FORGED_SPF_HELO,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2, SPF_HELO_PASS autolearn=no autolearn_force=no version=3.4.4 Received: by atuin.qyliss.net (Postfix, from userid 496) id 8CD56C74D; Mon, 22 Mar 2021 00:18:45 +0000 (UTC) Received: from [127.0.0.1] (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 477B4C711; Mon, 22 Mar 2021 00:18:36 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 496) id 50EEFC70A; Mon, 22 Mar 2021 00:18:34 +0000 (UTC) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11olkn2077.outbound.protection.outlook.com [40.92.19.77]) by atuin.qyliss.net (Postfix) with ESMTPS id 89337C708 for ; Mon, 22 Mar 2021 00:18:30 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kOehimZzKTe+PMXq9SrAyyPueO3z3n2FW7ofuv2z1rEi9ZMelbJWmc1ks7zsRwXVGdt5nLKoQUaQo5ZuMqtratsJLfm1BoBWL2ySuxlj0Abs+hIpumrGPZM55KMHp9XGJdvDWQgdVJK3jmEPUCpCevc9PJTvsY6e4Kdm6eXqPvsDDNr4gE0QodAy2ALV8HZMy8gb/aZNDa2V/LKzUXT7Q4FAD6m+XibRQYSz4/qOFtxZhKkol7UOnIWDLh5owsI07x8MTdkRbYwXnOu2BFj16w30i9d/7PQmqyNr/dJqOzA57ug2DKk5V4jAxP0LLf38LxroAU5FPiXtVPue5zR4Tw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MOFJQS2VTMoAQQnJGmVki+WgBgEOr6+k08aUcTfNTAA=; b=KkpiJ7rdgPeIgLOsM+IpAWcWNuWMkrW+b6c2ObUiCsAQC9Lgs9z7D7hMqPgmjbu4eQVXajgLHf3IjDu0P4TLbQC77p8+YRS9fKLZ22+ueqQT+qJbh92pNd1Mg02QYPaU9V9JsX9XIJZez0Z+Wcjp8Tumqjw1VPQqEf/ds0eesQRnp2TdnMS5UXzo8Ym8+XhcONJkVoH3AGeMIKNPxv+HXZp+kHDx0r/R+hNR+cKSs0ETHZIeu7VOT8FsgZ50FT17PDapM/F8JtpRR2iP0ZZq4ELYFdC06OX1QZqnVgK3UVLNymwYTkevdRxCuONIK+fod9DqqYdgk+4+a1Nl5lCQEw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MOFJQS2VTMoAQQnJGmVki+WgBgEOr6+k08aUcTfNTAA=; b=DtbIuZN8Od2yj1NMpyUgPHmQfzhad53o3Kl6iaolkBTY4RubFFiAnyJDqdaw2ILkD5QizGBaCRc73BSstxQUZ/Cf8B+PKqBvJGS3L24Dn9jUrr575HXMuRpDOufU/rTWH+GXQmiECHbuMmIej3ONVHgrb1WXIcvrSoBAh81BwG0wh5iWtQ3FWrj8nQD/R4xnMfaiGVoSQyyltO0mQYGSO26wtEkJhocWOtfoO45DJh2iGowb+MXGHx23bi73AUe1F7w4M03yGYh6T8Cjdmrn2VKjTDTIob+DuxZ6rDPRy3tJ1EYolC2ZbV0qPQeamoeB9/ZnzWpknBgRC2ySTFkXMg== Received: from CO1NAM11FT033.eop-nam11.prod.protection.outlook.com (2a01:111:e400:3861::43) by CO1NAM11HT175.eop-nam11.prod.protection.outlook.com (2a01:111:e400:3861::342) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18; Mon, 22 Mar 2021 00:18:28 +0000 Received: from SJ0PR03MB5581.namprd03.prod.outlook.com (2a01:111:e400:3861::50) by CO1NAM11FT033.mail.protection.outlook.com (2a01:111:e400:3861::247) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18 via Frontend Transport; Mon, 22 Mar 2021 00:18:27 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:98CFA155463A76B80DFB8B704B8DE4B8AE45402AB834CB86928C29A581C1DE87;UpperCasedChecksum:F8D2B2864FC6299737FFFFEF3ACA65BFB40F11F5D5A4BF0048BDE138137106D9;SizeAsReceived:8432;Count:44 Received: from SJ0PR03MB5581.namprd03.prod.outlook.com ([fe80::ed0b:679f:905f:4c94]) by SJ0PR03MB5581.namprd03.prod.outlook.com ([fe80::ed0b:679f:905f:4c94%6]) with mapi id 15.20.3955.024; Mon, 22 Mar 2021 00:18:27 +0000 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Subject: Re: [PATCH ucspi-vsock] Set up clang-format From: "Cole Helbling" To: "Alyssa Ross" , Date: Sun, 21 Mar 2021 17:15:19 -0700 Message-ID: In-Reply-To: <20210321193902.21087-1-hi@alyssa.is> X-TMN: [cH/ODmKudlBoII21lB0uc4vLIBgo/ZO0] X-ClientProxiedBy: BYAPR11CA0060.namprd11.prod.outlook.com (2603:10b6:a03:80::37) To SJ0PR03MB5581.namprd03.prod.outlook.com (2603:10b6:a03:27b::20) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost (73.48.197.220) by BYAPR11CA0060.namprd11.prod.outlook.com (2603:10b6:a03:80::37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18 via Frontend Transport; Mon, 22 Mar 2021 00:18:27 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 44 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 5f61fc9a-5cd5-41f8-9f60-08d8ecc803e9 X-MS-TrafficTypeDiagnostic: CO1NAM11HT175: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LO6jFTmrIRfTmWJqwiUYrYUHUPpLF+nr0gcLD3LJvy17cmFKN6ZeftZvwEChFcR8NNvrRZe0CV5ktOWMX6XClX0HW6jD5KfHUsNz6bu2Jr+fta9Omn8KrrIFYhb7ss/IiBMASkqOYVlbRhZGMux8TZaIlPJKucHkusf7OvRTvUyJ/Hbnj1Dq+ftRsUsspj8V7HsUuD5yljFjqC0kSBawJurPKhC5yR2wADttDdx2yeNiMLFukUkeRFTjiSI3GuWHgYphcj4BMwHktgKTj29QnPN6a3sj+lTqVb2kmpjrKMUE4hvgc8uor3PXOqHoZ8L8a0mDy0fzuT9ORsiy1ZXqPLPO9fE8u0U4l/xMevHwb0Sd82MSU+98+JdN2hZhycdTTxvLQu9Jx+pBtVyN53vNtA== X-MS-Exchange-AntiSpam-MessageData: JNXdByFmtPftGcCcrYtTO6XM6INYgh5Cxn7ny1yZJDLiM4O4qqcyu3npKmA+wXLquB8TsOVumhgea2Pd0sPs7wVVihn+ZFdxdWOuaJIXMGxhYGC2LdbuTiNrLtUCAfZ+KdyHCQ5hA3PEI8+rlgaL6g== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5f61fc9a-5cd5-41f8-9f60-08d8ecc803e9 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Mar 2021 00:18:27.8392 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT033.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1NAM11HT175 Message-ID-Hash: RA73KRNMCODRUIRIA4XR57W3PEORYNOV X-Message-ID-Hash: RA73KRNMCODRUIRIA4XR57W3PEORYNOV X-MailFrom: cole.e.helbling@outlook.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.3.1 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: On Sun Mar 21, 2021 at 12:39 PM PDT, Alyssa Ross wrote: > --- > I'm not entirely happy with the automatic formatting, but I think it's > worth it. > > .clang-format | 10 ++++++++++ > num.c | 2 +- > vsock.c | 4 ++-- > vsockclient.c | 5 +++-- > vsockserver-socketbinder.c | 8 ++++---- > vsockserver.c | 27 +++++++++++++++------------ > vsockserverd.c | 9 +++++---- > 7 files changed, 40 insertions(+), 25 deletions(-) > create mode 100644 .clang-format I wish every C / C++ repo used (something like) this, so I wouldn't have to guess on the code style. Major +1. Reviewed-by: Cole Helbling