From: "Cole Helbling" <cole.e.helbling@outlook.com>
To: "Alyssa Ross" <hi@alyssa.is>
Cc: devel@spectrum-os.org
Subject: Re: [PATCH ucspi-vsock] Makefile: stop repeating program list
Date: Thu, 18 Mar 2021 09:30:32 -0700 [thread overview]
Message-ID: <SJ0PR03MB5581848B0F7EF14ED27D5C6CB3699@SJ0PR03MB5581.namprd03.prod.outlook.com> (raw)
In-Reply-To: <87czvwobzq.fsf@alyssa.is>
On Thu Mar 18, 2021 at 5:57 AM PDT, Alyssa Ross wrote:
> >> Using a wildcard with rm -f means that if there are no object files to
> >> remove, rm will try to remove a non-existent file named '*.c', and
> >
> > Nit: do you mean '*.o'? ;)
>
> Oh, yes I do. I'll just fix that up locally without sending a new patch.
>
> >> then ignore the failure it gets by trying to do that. Which is fine.
> >> ---
> >> Makefile | 11 ++++++-----
> >> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> Look good otherwise? :)
Yes indeed!
Reviewed-by: Cole Helbling <cole.e.helbling@outlook.com>
next prev parent reply other threads:[~2021-03-18 16:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 0:36 [PATCH ucspi-vsock] Makefile: stop repeating program list Alyssa Ross
2021-03-18 6:57 ` Cole Helbling
2021-03-18 12:57 ` Alyssa Ross
2021-03-18 16:30 ` Cole Helbling [this message]
2021-03-18 19:06 ` Alyssa Ross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ0PR03MB5581848B0F7EF14ED27D5C6CB3699@SJ0PR03MB5581.namprd03.prod.outlook.com \
--to=cole.e.helbling@outlook.com \
--cc=devel@spectrum-os.org \
--cc=hi@alyssa.is \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://spectrum-os.org/git/crosvm
https://spectrum-os.org/git/doc
https://spectrum-os.org/git/mktuntap
https://spectrum-os.org/git/nixpkgs
https://spectrum-os.org/git/spectrum
https://spectrum-os.org/git/ucspi-vsock
https://spectrum-os.org/git/www
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).