From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FORGED_SPF_HELO,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2, SPF_HELO_PASS autolearn=no autolearn_force=no version=3.4.4 Received: by atuin.qyliss.net (Postfix, from userid 496) id B82C97B0B; Thu, 18 Mar 2021 16:31:10 +0000 (UTC) Received: from [127.0.0.1] (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id BB5FA7A32; Thu, 18 Mar 2021 16:31:00 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 496) id C9B1A7AEA; Thu, 18 Mar 2021 16:30:58 +0000 (UTC) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12olkn2081.outbound.protection.outlook.com [40.92.22.81]) by atuin.qyliss.net (Postfix) with ESMTPS id B81D27AE8 for ; Thu, 18 Mar 2021 16:30:54 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FrDY2J3C1PoTnklx3ANpt4mvlOan6eA74SSPSjlpYcgxhXrA9qvlPkShpC3jSIvOMuttADsfG5HSQWIxTMEaz5xLVP9iVcQ1Rrn6GMxEyAsiiNGVSE05HqPdeaaQct21y3fVFCFZuDJfCKhRc0WwGDlP+aDrREaKxwLpv12ww2II7Z0bGB/XDQ1kfpstnQIZPkW1/a2o5E+I2VRMAUrUFbA+Uq7cqyxaTSKFMPxRAQ1b0larVIUyAHcfQFMHkAif0UD4oic7mNi8bO/lFAE6E6uyJ6uBQo4O6KXKTJXqkxF82apEfjdVwzMV1ShQpwHB7dPMGN1W3ab5MR8yiUw+EQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w6cLXr1LYcaZq6g5d25MOpWisD5Py3jdVjAO+EVZp/g=; b=ddpA5KGwuk9adCwy2CXf1/RzfhFfx8XxE5PLLeNd1HZ8qF4AGmtACKZ0JLUsy+g49y0NH1WUKXmvsU6chi1MADch0x1mmvsGpbGxHqMLsgR6l7/Q0S3vyoOgViB3IwPohbQMveRF8jkJdHQv6c/oW5XzCry9P/Wohrtvl0HF6wzJGrg4rlpXwIiB+Hc1QnV/zNlMcckgn7GZEOTBxbM7MnPhdwpMTpiOJil1pQ8k4nrZXQmIGmr+C+HlblqPb36WjpjMm08xSSi+ysA5+PAMXnWc0EvvHiaY2vhIsjGP9WbJaN2k0iHlx0eZAbaOzamHHLCuk3kG0EAJYxCU00csoA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w6cLXr1LYcaZq6g5d25MOpWisD5Py3jdVjAO+EVZp/g=; b=OHKq5dFJLC65+YRPgh3ckPPF2KX/zV1lqqVcktnJEL3mCIIHMwHcyxo++8xT/Udy83Ndt41e4CPrvzie/Mz4y1mH+e2Dhz7iaVvqNlxqTLUk93eZTg7msbUqJyTepzoriaqwVBJDd9eQI+8L+px3ai6JjjsKQMEna1a5tb+9l8/flyD3qIsreMpFxgNUTBGmg6LCbLHEukZ5bzLV6ozRFjR1EwJGCnXWM125hxyUxE54Av5eHw6G73N0kHIJhTkl0KVUr5+Wt2qmSJI0kIAiJZBTQrhQGc1Dd1GABZgS8yH4IcyeVD0OQCO3nSiXgPDqkYQKwEnQTeeTNad87Sn9Og== Received: from DM6NAM12FT006.eop-nam12.prod.protection.outlook.com (2a01:111:e400:fc64::50) by DM6NAM12HT188.eop-nam12.prod.protection.outlook.com (2a01:111:e400:fc64::174) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.9; Thu, 18 Mar 2021 16:30:52 +0000 Received: from SJ0PR03MB5581.namprd03.prod.outlook.com (2a01:111:e400:fc64::51) by DM6NAM12FT006.mail.protection.outlook.com (2a01:111:e400:fc64::234) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.9 via Frontend Transport; Thu, 18 Mar 2021 16:30:52 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:A145397F20531852B845AC0C835BDC28A4134FDB56DEB410A93BF75BA84C6422;UpperCasedChecksum:FA536CE0D9E07F652CAC5307945B9C5A457F07E4C819F2494B9129F8003B9367;SizeAsReceived:8449;Count:45 Received: from SJ0PR03MB5581.namprd03.prod.outlook.com ([fe80::ed0b:679f:905f:4c94]) by SJ0PR03MB5581.namprd03.prod.outlook.com ([fe80::ed0b:679f:905f:4c94%5]) with mapi id 15.20.3933.032; Thu, 18 Mar 2021 16:30:52 +0000 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Subject: Re: [PATCH ucspi-vsock] Makefile: stop repeating program list From: "Cole Helbling" To: "Alyssa Ross" Date: Thu, 18 Mar 2021 09:30:32 -0700 Message-ID: In-Reply-To: <87czvwobzq.fsf@alyssa.is> X-TMN: [WKVu3b5W16ttIU8ABvTJOQ3JzbtENW9d] X-ClientProxiedBy: BY5PR04CA0010.namprd04.prod.outlook.com (2603:10b6:a03:1d0::20) To SJ0PR03MB5581.namprd03.prod.outlook.com (2603:10b6:a03:27b::20) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost (73.48.197.220) by BY5PR04CA0010.namprd04.prod.outlook.com (2603:10b6:a03:1d0::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18 via Frontend Transport; Thu, 18 Mar 2021 16:30:51 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 45 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 26524f02-ec47-4a27-8806-08d8ea2b3228 X-MS-TrafficTypeDiagnostic: DM6NAM12HT188: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GXSSQdmXTN7OV6HiS1AlfqQmveyi2ZBMjMfFC526GH+sgXSgftFxAS+uzSMH/P9D3Vavh+zf1eu92gxrakEw2h95fA7HUZl80RW6XtW9hesdT0/g20jAwT2phS1XGASJ+ZBWpP+zta7/7fixnowSc3M41Udsy4BLTpr3QHEDqak/qGjAxAWi7AgoL6vhm0Ana5nseR8hOI88J63Fm/WC5D9yJqhBkmWSHRv+p1hdbERTbkzIbXUdm+qk5scvngbxnSLc6pfaG73IYW0XKB2nmEU6/PohiwkCpZruDTWNOjZZiuln0nKpFMPcA+2UfsvdbeJIkk5TO8I3XGTKgmQMFE0fB2ZJk3ovcB36i5n16qZkHNTR2xxZOEV6Hr6FcV4FoKWpRMPbi5fmt4PSMVTcIA== X-MS-Exchange-AntiSpam-MessageData: wzCItxo4OV7tliA9yEmGzMmI0JjuBQfs34if10z/xUcq6wyjeHX/0AoSrBxGnVuT14/o9bOsiAxvJMMZA+8ekSoDeATYEznep8F7jqoLPICz20KbjFYy3M2vxeT8vQlu1rg6jL3VX1nqzQl5B123xg== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 26524f02-ec47-4a27-8806-08d8ea2b3228 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Mar 2021 16:30:52.0916 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: DM6NAM12FT006.eop-nam12.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6NAM12HT188 Message-ID-Hash: ZDTZYU7ZP657GM7DLCXHRIVAT5MLE32C X-Message-ID-Hash: ZDTZYU7ZP657GM7DLCXHRIVAT5MLE32C X-MailFrom: cole.e.helbling@outlook.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: devel@spectrum-os.org X-Mailman-Version: 3.3.1 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: On Thu Mar 18, 2021 at 5:57 AM PDT, Alyssa Ross wrote: > >> Using a wildcard with rm -f means that if there are no object files to > >> remove, rm will try to remove a non-existent file named '*.c', and > > > > Nit: do you mean '*.o'? ;) > > Oh, yes I do. I'll just fix that up locally without sending a new patch. > > >> then ignore the failure it gets by trying to do that. Which is fine. > >> --- > >> Makefile | 11 ++++++----- > >> 1 file changed, 6 insertions(+), 5 deletions(-) > > Look good otherwise? :) Yes indeed! Reviewed-by: Cole Helbling