From: "Cole Helbling" <cole.e.helbling@outlook.com>
To: "Alyssa Ross" <hi@alyssa.is>
Cc: devel@spectrum-os.org
Subject: Re: [PATCH nixpkgs v2] spectrumPackages.spectrum-vm: fix without Wayland
Date: Mon, 15 Mar 2021 18:15:37 -0700 [thread overview]
Message-ID: <SJ0PR03MB55818F5B13C0F819A7F180A2B36B9@SJ0PR03MB5581.namprd03.prod.outlook.com> (raw)
In-Reply-To: <20210316010910.ryhee36zgtoahdok@eve.qyliss.net>
On Mon Mar 15, 2021 at 6:09 PM PDT, Alyssa Ross wrote:
> The surrounding "set +e"/"set -e" was an earlier attempt to fix this,
> but I mixed -e up with -u. But as Cole points out, it's nicer to use
> parameter expansion here anyway.
>
> Thanks-to: Cole Helbling <cole.e.helbling@outlook.com>
> ---
> pkgs/os-specific/linux/spectrum/spectrum-vm/spectrum-vm.in | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
LGTM!
Reviewed-by: Cole Helbling <cole.e.helbling@outlook.com>
next prev parent reply other threads:[~2021-03-16 1:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-25 16:48 [PATCH nixpkgs] spectrumPackages.spectrum-vm: fix without Wayland Alyssa Ross
2020-08-25 17:26 ` Cole Helbling
2021-03-16 1:09 ` [PATCH nixpkgs v2] " Alyssa Ross
2021-03-16 1:15 ` Cole Helbling [this message]
2021-03-16 1:25 ` Alyssa Ross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ0PR03MB55818F5B13C0F819A7F180A2B36B9@SJ0PR03MB5581.namprd03.prod.outlook.com \
--to=cole.e.helbling@outlook.com \
--cc=devel@spectrum-os.org \
--cc=hi@alyssa.is \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://spectrum-os.org/git/crosvm
https://spectrum-os.org/git/doc
https://spectrum-os.org/git/mktuntap
https://spectrum-os.org/git/nixpkgs
https://spectrum-os.org/git/spectrum
https://spectrum-os.org/git/ucspi-vsock
https://spectrum-os.org/git/www
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).