From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FORGED_SPF_HELO,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2, SPF_HELO_PASS autolearn=no autolearn_force=no version=3.4.4 Received: by atuin.qyliss.net (Postfix, from userid 496) id BC57A4205; Tue, 16 Mar 2021 01:19:09 +0000 (UTC) Received: from [127.0.0.1] (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 2F5B541F2; Tue, 16 Mar 2021 01:18:58 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 496) id 76D2A41BD; Tue, 16 Mar 2021 01:18:56 +0000 (UTC) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10olkn2051.outbound.protection.outlook.com [40.92.42.51]) by atuin.qyliss.net (Postfix) with ESMTPS id 05E5441BC for ; Tue, 16 Mar 2021 01:18:51 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZRUnuYebtv8oYwj7BbTUs6TOqcSwBbRKKiP3BdHDpPvSpsZbXVxDxp3tjLR36j9dq/OnM48zhVjGd7yAGyPBUILIfCE6YQzuoxa36Kgd5Jih+0TocHBLUFhtxX5Um04luXslLrv+kDoTcVI1kOgLUQQs+ARvq5yyuXKeCTDHa+aK++IZ8K7gUw1Mh/FweiCptJ8yZ8EnkN++Yr/ngTh7NJUn/KOhm1pRwgHc3YWVZhs1ufGPQZ7I1DsOJmM80h0bOfhaGR1GNePdCwkgLG1bcGg0mmgYKOYYNdloks6qHat7HG8eK3IPGdMa8Vgxy2k9VC6JG4+Ee0F6QekxqeDx9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bLboM5D/pKCgJW4B+qhX9PLjCZPiOthCBP68qiZFhtM=; b=Kxfe2YM9bRGDDL2l6IrGF4ohPwoNIdyX2+ZJ0JbuSSkDrePGBlHPC8KWy13VQ2C6RMIlFg/cCy+LacNIc9DWvCFYaf3lhqCtlwyMEQh0L9SiT3LGKNa1rh/9IUSTcHZjxLBlxPxO4gtDWqQY1E4GH8wN7kgdnoZm9RJNIwacAUH0rJbV4SMrh9L9t6aBRA5c4VSW2XdykmnRUeBkuS6c0IF/L9iywh2hkrcAvZ/qydHa5I1ySJMOKRU6BuXl42pVF1Fg54Io50uzdh7+hNN0Espxx74xzxkHaQQ0TR4MvJIr0LrvtsrT1UNp3AEc2j/mKQxiqxRDAwl6o3ZeeqnPTw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bLboM5D/pKCgJW4B+qhX9PLjCZPiOthCBP68qiZFhtM=; b=HyHHWwpJ8X2xGaLttagIgECo4YxJLJABr7z4kmO/vomfT2ueZVHOI+Gg2EfXIx1o866epICop69DkseOLIRGWHuya/vRzOHjXn3/kVg8uxP+Lcc7TFP9CsxashefZjxRUJzZv68mFo7eo/31FIu0zu+uHi0kWZy2+lCNRHD2iHvIdmhY2h535iJvbwn6oMWgGDb9+gsbPzVtYqg3rFpCGtlOuBe7x7/IjXE32ZPe9k8lVPCWUcRB9sJAkjCreZvagR5Yer9vzQ8fJppj5fYrHdfiiAUehbO5J+OZog9IvNMXnAaTkeWgrzNzpqYsgfuPUdS0lSyJ+khD9kLyQVgyVQ== Received: from BN7NAM10FT045.eop-nam10.prod.protection.outlook.com (2a01:111:e400:7e8f::48) by BN7NAM10HT035.eop-nam10.prod.protection.outlook.com (2a01:111:e400:7e8f::396) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.31; Tue, 16 Mar 2021 01:18:49 +0000 Received: from SJ0PR03MB5581.namprd03.prod.outlook.com (2a01:111:e400:7e8f::47) by BN7NAM10FT045.mail.protection.outlook.com (2a01:111:e400:7e8f::337) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.31 via Frontend Transport; Tue, 16 Mar 2021 01:18:49 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:B4E72479C52FEEF43DFD0A1DD56921D235204B6DBFA8E1B84DD7E2D5FB96606A;UpperCasedChecksum:387F960070758DC4335769AAF9EC0D9C2BA51F1943C7B11B7E84329640C0FB44;SizeAsReceived:8479;Count:45 Received: from SJ0PR03MB5581.namprd03.prod.outlook.com ([fe80::ed0b:679f:905f:4c94]) by SJ0PR03MB5581.namprd03.prod.outlook.com ([fe80::ed0b:679f:905f:4c94%5]) with mapi id 15.20.3933.032; Tue, 16 Mar 2021 01:18:49 +0000 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 From: "Cole Helbling" To: "Alyssa Ross" Subject: Re: [PATCH nixpkgs v2] spectrumPackages.spectrum-vm: fix without Wayland Date: Mon, 15 Mar 2021 18:15:37 -0700 Message-ID: In-Reply-To: <20210316010910.ryhee36zgtoahdok@eve.qyliss.net> X-TMN: [2g+F3R9MNCs/nHOpsGJzJeM6DbTDlhnD] X-ClientProxiedBy: BYAPR04CA0026.namprd04.prod.outlook.com (2603:10b6:a03:40::39) To SJ0PR03MB5581.namprd03.prod.outlook.com (2603:10b6:a03:27b::20) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost (73.48.197.220) by BYAPR04CA0026.namprd04.prod.outlook.com (2603:10b6:a03:40::39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.32 via Frontend Transport; Tue, 16 Mar 2021 01:18:48 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 45 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: b15c17ae-c899-457f-bad5-08d8e8197401 X-MS-TrafficTypeDiagnostic: BN7NAM10HT035: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Se2mqV9v9NKP89hNggfcQAk/HEXDfDVQ5sIH4aI0Eq51xs5KgtB8DKKGgnJh/uIhLPDKL1mgxzPnaaZcC3r5UG8ukJDP+QDi8TdXibemaj80QHfERaD0++F9dXyYq1pZ8osagTj0eeE1Yx7t7wW4TJZ2DW0lmfOxskFDcxKfyxj/EtpawWgsaLHALj25kfky4eb7PLAhQfylQ+S+mSIXCG/5UdjHF4aSUaz7wm4XUCdo4zHQYAAWJtFcFLfvHwTip90HBOttAHsjEJ0BL5AtVQEJNlFDYnglYtFiUbCYZFKFeojwy2rC2Gd41x00jZ7BKCQhuNBZDBqKaMRW//Hzk9PQryYyFWtvwaMAwuzF8gpxwuXZDqGa0cDPuXxFGgeGRWk/UCYcAgHu/7HjwZfK7w== X-MS-Exchange-AntiSpam-MessageData: chSd8ze0IadpA0xZiNSYHIJr4N1zURbeOZP7evx1yTu66YTWtxWFFvalHugrvJqtkDQCyMVsiLveUoYSY94efXjpQobxkPBv+GmjUhP2NDWkDOov2ChWgawuvN/DgLegUzEyfdCrlHiI82qHlx26jQ== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b15c17ae-c899-457f-bad5-08d8e8197401 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2021 01:18:49.2754 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: BN7NAM10FT045.eop-nam10.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7NAM10HT035 Message-ID-Hash: DJZHNW3C4DSF2OAH2DMPEZLPJO5I25HW X-Message-ID-Hash: DJZHNW3C4DSF2OAH2DMPEZLPJO5I25HW X-MailFrom: cole.e.helbling@outlook.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: devel@spectrum-os.org X-Mailman-Version: 3.3.1 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: On Mon Mar 15, 2021 at 6:09 PM PDT, Alyssa Ross wrote: > The surrounding "set +e"/"set -e" was an earlier attempt to fix this, > but I mixed -e up with -u. But as Cole points out, it's nicer to use > parameter expansion here anyway. > > Thanks-to: Cole Helbling > --- > pkgs/os-specific/linux/spectrum/spectrum-vm/spectrum-vm.in | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) LGTM! Reviewed-by: Cole Helbling