From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FORGED_SPF_HELO,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2, SPF_HELO_PASS autolearn=no autolearn_force=no version=3.4.5 Received: by atuin.qyliss.net (Postfix, from userid 496) id 021D6BA29; Wed, 14 Apr 2021 18:55:51 +0000 (UTC) Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id BE081BA8F; Wed, 14 Apr 2021 18:55:44 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 496) id A344EBA08; Wed, 14 Apr 2021 18:55:42 +0000 (UTC) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12olkn2093.outbound.protection.outlook.com [40.92.21.93]) by atuin.qyliss.net (Postfix) with ESMTPS id A030CBA80 for ; Wed, 14 Apr 2021 18:55:39 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nobESiI5qkwWlCvixVOqXMtBZFDtWEWsb+8yiDyka8ic1p3WEJzqYpkWzErWzb6cyYbv0InJ4NcGxHRQqTXtD9eDdFTahoNu32JoBv5Xhv1NeYlCMhWR0TgaFGyHPcgnVn/lvAUt1HALJQotmywYEUPwngkpTbMlXXwE9ro0tTzUrNv96yPDTE6kB91L/iR/jKwvuCBSUtYBPPprUfO50EVKP++chCE2Dpd90XjHP+GvGt97kemjOhGoaJ+U2LUChB/KwUfG1ynRAzjt0d+Wh1zEmNx/muwDBYZZrfHg8yqj09J1UI+Nc54xIpRew2Zoa4GO6Ewj0QpjJOzSVYzICg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DLI3kDzi0pidPNKzS/Qb2r1u577buDLpnJaEqAI4UxE=; b=nG+dfeIGrr2OQF5tx3ACgg25Osndsk9d3PGUCzhfCQbXIkJH82yWKcj4R+jllFKKNJZuoxBhQhB81bU5WHNehCzIero50zeFbdMgZI9hW8/0O828MNLMKmtteiJqyrULRMgXgRkRGf1nX+k2wPmXumeHNTrnlhrppsmkP3reTP6vbcr4QC66rCbRwYWflKj74bwt/yCBTu55IytGrypeU9liZnZRxuFwkltDwBV/AgKt4BxWFyD1ftiHD3yWJsqeEXzDVAkwoHlLBDQD8qmaJSVwj7NnGYssPbk62B2TtZSdqS7aBP0Jjp1sKsexG4Tvz6X92epwJRWUZPB+tqbS0w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DLI3kDzi0pidPNKzS/Qb2r1u577buDLpnJaEqAI4UxE=; b=BK3LrPvAeAWsA+p971eE0jG/9iit4/UThY/bG3a3Ch2NbQptrCD1VzvOKR1XgHhSmD/Ut6g9Bi+hDu9RmU2n3jKzXpd3KOLObboKWiVvz0UW2krXXOQj7SY/QqFdFXy7NXeYvyf1W7MU8Zkkmo2JqLIwKtst9y7L8g2hpRaaCjOkBYR2O+dgL0/mOzwg6l5J20/Id2bGUofO5TccxlWOrMZ6GZUD70gm1V4iIjEGNgOkbpf0LAJLEySYdo5a8I7qPzGGxw+KvsbgOLO0tAVS3g6Xo5WD1IfphS3ZV5DzwTIp8IEYwAb5j83/Xel6XcMhu9EfdCSUur7F+ZNKF5Jm2g== Received: from BN8NAM12FT021.eop-nam12.prod.protection.outlook.com (2a01:111:e400:fc66::4b) by BN8NAM12HT183.eop-nam12.prod.protection.outlook.com (2a01:111:e400:fc66::64) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.6; Wed, 14 Apr 2021 18:55:37 +0000 Received: from SJ0PR03MB5581.namprd03.prod.outlook.com (2a01:111:e400:fc66::48) by BN8NAM12FT021.mail.protection.outlook.com (2a01:111:e400:fc66::391) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.6 via Frontend Transport; Wed, 14 Apr 2021 18:55:37 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:A0D56065B334DFEA97264A8E40027FA2A7D511EF5AE463304C344405C4B5FFE1;UpperCasedChecksum:8E05E1C50E0095BA46F63286462B5E539FB41095A639110C0938ED5C386D7365;SizeAsReceived:8458;Count:44 Received: from SJ0PR03MB5581.namprd03.prod.outlook.com ([fe80::2437:eb29:a6eb:76fa]) by SJ0PR03MB5581.namprd03.prod.outlook.com ([fe80::2437:eb29:a6eb:76fa%5]) with mapi id 15.20.4042.016; Wed, 14 Apr 2021 18:55:36 +0000 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Subject: Re: [PATCH crosvm] crosvm: support setting guest MAC from tap-fd From: "Cole Helbling" To: "Alyssa Ross" , Date: Wed, 14 Apr 2021 11:55:03 -0700 Message-ID: In-Reply-To: <20210409222026.13886-1-hi@alyssa.is> X-TMN: [42prraWhpA4FCUSdcXhfbz0jzyq0/R/+] X-ClientProxiedBy: BYAPR06CA0048.namprd06.prod.outlook.com (2603:10b6:a03:14b::25) To SJ0PR03MB5581.namprd03.prod.outlook.com (2603:10b6:a03:27b::20) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost (73.48.197.220) by BYAPR06CA0048.namprd06.prod.outlook.com (2603:10b6:a03:14b::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.16 via Frontend Transport; Wed, 14 Apr 2021 18:55:35 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 44 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 133a5d8f-e51b-4ba0-dccf-08d8ff76e37b X-MS-TrafficTypeDiagnostic: BN8NAM12HT183: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aBnxU3bvbcZgYs0VCunKBrfIQ8yup3VigGhQLYG1G0vxmT5HE3Su0AuN8DRQhKP8eEHhYDgML3lVxZ/3cGMcIui2hb6DWbn/hCmRGAU1Funk6cQVF6zIqtqTLWC1uhAi58nY6D+eBIBAxvF+LhUYEVV3L9823t9hgxj3qC5igR7aLvgpUIgy5C3sM5FGIGzgCAb+fDHmUEaV08mbk/PX8QXxw9+XqOcr5dqCXHUj7dw3Uxv7wKCdfNc+xpMcVVcIrM9C2cqgPnWr5uizwOvP00I+FZx4pLYY23ZNgn4Zuh+2ugJW7k8oc7AyWg/M64y5lu879rk7DYsHmK42dtD2FEKy9q8rbwQ030GdltR5q5gjRjgbNjVMopdrSXcFjVs6kU3ZjoMN+0B/yYyPV/VblY0wZcpi2RIlf6n1Slyc5/Y= X-MS-Exchange-AntiSpam-MessageData: lF4dQoIOyXM7y9xbKPqGYtkehGP4DMvUjMamuKCCWLmPbf93db2bJKpqMO0qVj4/xiSwirajYDnjvVSMDDgIoaYZYJ1kMvNzA65+IR30fHrsi2KktAr4+vdctDXrM+cjMH1VF5FXwm2gYM1VlrdcrQ== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 133a5d8f-e51b-4ba0-dccf-08d8ff76e37b X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2021 18:55:36.2775 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: BN8NAM12FT021.eop-nam12.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8NAM12HT183 Message-ID-Hash: P76UOYVWUWSRQRGYKKVTO5AZROZWCXGX X-Message-ID-Hash: P76UOYVWUWSRQRGYKKVTO5AZROZWCXGX X-MailFrom: cole.e.helbling@outlook.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.4 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri Apr 9, 2021 at 3:20 PM PDT, Alyssa Ross wrote: > This adds a mac=3D option to crosvm's --tap-fd option. The virtio-net > driver in the guest will read the desired MAC from virtio > configuration space. > > See the documentation for VIRTIO_NET_F_MAC in the Virtio spec[1]. > > [1]: https://docs.oasis-open.org/virtio/virtio/v1.1/virtio-v1.1.html > > --- > This will be important for host-based networking in Spectrum. > > devices/src/virtio/net.rs | 31 ++++++++++++++++--- > src/crosvm.rs | 8 +++-- > src/linux.rs | 20 +++++++----- > src/main.rs | 64 ++++++++++++++++++++++++++++++--------- > 4 files changed, 96 insertions(+), 27 deletions(-) Probably should have reviewed this one first... :P Oh well. Reviewed-by: Cole Helbling