From: "Cole Helbling" <cole.e.helbling@outlook.com>
To: "Alyssa Ross" <hi@alyssa.is>, <devel@spectrum-os.org>
Subject: Re: [PATCH nixpkgs] chromiumOSPackages.libqmi: don't enable doc twice
Date: Fri, 13 Aug 2021 08:58:02 -0700 [thread overview]
Message-ID: <SJ0PR03MB5581A1AFA03AE4D5A210EB35B3FA9@SJ0PR03MB5581.namprd03.prod.outlook.com> (raw)
In-Reply-To: <20210812093108.137327-1-hi@alyssa.is>
On Thu Aug 12, 2021 at 2:31 AM PDT, Alyssa Ross wrote:
> This is already enabled in the original derivation, so overriding it
> to add it here just means we end up passing the option twice.
> ---
> pkgs/os-specific/linux/chromium-os/libqmi/default.nix | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/pkgs/os-specific/linux/chromium-os/libqmi/default.nix b/pkgs/os-specific/linux/chromium-os/libqmi/default.nix
> index b96b5224b57..7328642d0b4 100644
> --- a/pkgs/os-specific/linux/chromium-os/libqmi/default.nix
> +++ b/pkgs/os-specific/linux/chromium-os/libqmi/default.nix
> @@ -15,7 +15,7 @@ libqmi.overrideAttrs (
>
> # ModemManager tests fail with QRTR in Chromium OS 91.
> # Will hopefully be fixed in CrOS 92.
> - configureFlags = configureFlags ++ [ "--enable-gtk-doc" "--disable-qrtr" ];
> + configureFlags = configureFlags ++ [ "--disable-qrtr" ];
>
> passthru = passthru // {
> updateScript = ../update.py;
> --
> 2.32.0
But what if we want twice the amount of documentation?
Joking aside, LGTM.
Reviewed-by: Cole Helbling <cole.e.helbling@outlook.com>
next prev parent reply other threads:[~2021-08-13 15:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-12 9:31 [PATCH nixpkgs] chromiumOSPackages.libqmi: don't enable doc twice Alyssa Ross
2021-08-13 15:58 ` Cole Helbling [this message]
2021-08-16 8:49 ` Alyssa Ross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ0PR03MB5581A1AFA03AE4D5A210EB35B3FA9@SJ0PR03MB5581.namprd03.prod.outlook.com \
--to=cole.e.helbling@outlook.com \
--cc=devel@spectrum-os.org \
--cc=hi@alyssa.is \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://spectrum-os.org/git/crosvm
https://spectrum-os.org/git/doc
https://spectrum-os.org/git/mktuntap
https://spectrum-os.org/git/nixpkgs
https://spectrum-os.org/git/spectrum
https://spectrum-os.org/git/ucspi-vsock
https://spectrum-os.org/git/www
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).