From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FORGED_SPF_HELO,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2, SPF_HELO_PASS autolearn=no autolearn_force=no version=3.4.6 Received: by atuin.qyliss.net (Postfix, from userid 496) id 778B93A917; Fri, 13 Aug 2021 15:59:21 +0000 (UTC) Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id F30723A8F1; Fri, 13 Aug 2021 15:59:13 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 496) id B475F3A877; Fri, 13 Aug 2021 15:59:11 +0000 (UTC) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11olkn2042.outbound.protection.outlook.com [40.92.19.42]) by atuin.qyliss.net (Postfix) with ESMTPS id E1CDD3A8D8 for ; Fri, 13 Aug 2021 15:59:08 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=in+fQdAuFbx/lAPREgj2S9/fJDoBEWShaik2oF7Z9mLf1PLX9Q4ZGrEY1cjZxUElInENlU8YnYFMVNw8epdzxSBBlngQTmJNPYwRH3d1SbGQXStTUO7/T7fPkwtvlZE9aJf2dOrOtMLamst5a8r05Ryra90g2Q493VT8rvENqXE2NFXyKwkAu+ffnIofXvWPmPNnZsxCzcNAMCY+nQJfCq3Amd4M4Ve0kjaMOyL26vrOvy9FmYKGqr7ChSasYHrUhmO4g+u+wCdlfKMCYOJ9o+1PSQi3k6FHob2kq2KFarSrEEDD2EE+ZMtsQw/TLYRD7SyOAlkvVKe1R3MCVEPFtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yF6XEfBv9/K7fwYmSJj/UkmPT3lmFfgREMfr2Pn7cZA=; b=nsJx5J4vPRQkPEqf41V8Ffxl7+4QCBrhcaUctFBb9Q7na+Ug5OFtzt3mzq3sNXMpam7ygZaI+lZfHYxsALr3OWmAR2IR+0fKzu3VziP1BN+ZXGHfaEwh0I9N41EHRLC6VqgGMTvCKzrbZgKWN2CUnYeBp8OUG4dRHC0dDf7vdZcVGPEVaXrsH5WrdRm993Z+umMbVHYsm/9767ntifBnSxLGz2rHgmBFkZGU00y2bTb0A75dYmruIbGQXG+cp1yC//OnlW0YsL2FC3po2RvBSGQiubmoZncFIUTk4uff1DiSoCak2jaIYMOfthO8dA2P7456mX79jBlwbV7WP0/8gg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yF6XEfBv9/K7fwYmSJj/UkmPT3lmFfgREMfr2Pn7cZA=; b=ZehZNTE/Fg0NcONeW9S3SJTN2WRw8R8ebbmwiKFNSHTumOzdT+OpdYKequ5U+5YS1i5wJc83UACKgAs7Y6VtR4mkmDgj+BF2+Ib9rjtmDc5e+RGYkfnDp6ZRgkZoWGdcn9FTgATDr9SkCbDgepOacLx3u/Y2c5H/qdlLZoO/l1R5qr1Nj8YqPR5bYUKFwqNVkpBUwXHKqZSJtUXXNqihy4uzqou23Zw0FSCfvcz03FbLoUZ5fb0oiTjw9VK/k928OzSqp6uto+Kr+MmHUGznuECK7Q4LixpeesZJjy6esgRMElxw6AUfPwitbxFEaH0s4KGrpaUhKS911FSz7Odxag== Received: from SJ0PR03MB5581.namprd03.prod.outlook.com (2603:10b6:a03:27b::20) by SJ0PR03MB5901.namprd03.prod.outlook.com (2603:10b6:a03:2ae::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.15; Fri, 13 Aug 2021 15:59:06 +0000 Received: from SJ0PR03MB5581.namprd03.prod.outlook.com ([fe80::21ed:face:296d:a4ab]) by SJ0PR03MB5581.namprd03.prod.outlook.com ([fe80::21ed:face:296d:a4ab%2]) with mapi id 15.20.4415.019; Fri, 13 Aug 2021 15:59:06 +0000 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Subject: Re: [PATCH nixpkgs] chromiumOSPackages.libqmi: don't enable doc twice From: "Cole Helbling" To: "Alyssa Ross" , Date: Fri, 13 Aug 2021 08:58:02 -0700 Message-ID: In-Reply-To: <20210812093108.137327-1-hi@alyssa.is> X-TMN: [yS8xTnM6wTYWysoVruXBNhpq2PaDxzNz] X-ClientProxiedBy: SJ0PR13CA0146.namprd13.prod.outlook.com (2603:10b6:a03:2c6::31) To SJ0PR03MB5581.namprd03.prod.outlook.com (2603:10b6:a03:27b::20) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost (73.48.197.220) by SJ0PR13CA0146.namprd13.prod.outlook.com (2603:10b6:a03:2c6::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4436.10 via Frontend Transport; Fri, 13 Aug 2021 15:59:05 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5bc26bc9-6e49-441e-550c-08d95e734739 X-MS-TrafficTypeDiagnostic: SJ0PR03MB5901: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PFX8YBf3KeM5ZPHfdFSGvvd9NuO0DBGC1Yu4oPbAG8WS3yLKzryVM49gmcag1EMDPbOZy8GUfVIFGMbOlMzbwCPO2tELkzSFrz9wZm4loerCPj9sAUVel3rGtYk+tZDwh0Nc0I5C0YSLQDD0+VUYRKVQY4PcwyRXgCNAiYl8w6eoUnuhGsXlHASsQB6BcBv/cbZGPl5M5PKa5AZ9pfJSrSCislv82FosrYKVDwucRqjmfCAYCpS3ThPSAs2a33vyOH0E4IrMK59S9r5/BkVsxC/wkJTxB9WtU9dQzg4MEDOEYAVMpb4eYWmhnSGN0HWlpHKStN+Wou+MWw+Z1X26lIYe1i3idoAxXqnPFESJszzJPfady/eT13j97MJzttqSnife4OhtD3x+U0O288ossPh+f/uIYGLdBLqdxu8jBy42KnO9Dzx8vd1mAcSw3mrB X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: AaZrhHy+XBWFfLNXlI5vdT/xr1dOkZd7KbhIppDGXOUADQCxTv6kjLAp6eRVZkslGQ8efBjHB1zy5wkt711G9aOB2NpflgYP0eUryTNfQEj5LcbgsZughA5c9xpVIXrZTNOzrhoubtysKaQ75ju0aw== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5bc26bc9-6e49-441e-550c-08d95e734739 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB5581.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Aug 2021 15:59:06.1424 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5901 Message-ID-Hash: YYIQVCKOX46JHSSWW7XZSUCKUVKIII7D X-Message-ID-Hash: YYIQVCKOX46JHSSWW7XZSUCKUVKIII7D X-MailFrom: cole.e.helbling@outlook.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.4 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu Aug 12, 2021 at 2:31 AM PDT, Alyssa Ross wrote: > This is already enabled in the original derivation, so overriding it > to add it here just means we end up passing the option twice. > --- > pkgs/os-specific/linux/chromium-os/libqmi/default.nix | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/pkgs/os-specific/linux/chromium-os/libqmi/default.nix b/pkgs= /os-specific/linux/chromium-os/libqmi/default.nix > index b96b5224b57..7328642d0b4 100644 > --- a/pkgs/os-specific/linux/chromium-os/libqmi/default.nix > +++ b/pkgs/os-specific/linux/chromium-os/libqmi/default.nix > @@ -15,7 +15,7 @@ libqmi.overrideAttrs ( > =20 > # ModemManager tests fail with QRTR in Chromium OS 91. > # Will hopefully be fixed in CrOS 92. > - configureFlags =3D configureFlags ++ [ "--enable-gtk-doc" "--disable= -qrtr" ]; > + configureFlags =3D configureFlags ++ [ "--disable-qrtr" ]; > =20 > passthru =3D passthru // { > updateScript =3D ../update.py; > --=20 > 2.32.0 But what if we want twice the amount of documentation? Joking aside, LGTM. Reviewed-by: Cole Helbling