From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FORGED_SPF_HELO,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2, SPF_HELO_PASS autolearn=no autolearn_force=no version=3.4.4 Received: by atuin.qyliss.net (Postfix, from userid 496) id 682B814D5A; Wed, 10 Mar 2021 17:46:40 +0000 (UTC) Received: from [127.0.0.1] (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 64C3214DB7; Wed, 10 Mar 2021 17:46:31 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 496) id 367EF14D3A; Wed, 10 Mar 2021 17:46:30 +0000 (UTC) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10olkn2015.outbound.protection.outlook.com [40.92.42.15]) by atuin.qyliss.net (Postfix) with ESMTPS id ED30A14D95 for ; Wed, 10 Mar 2021 17:46:26 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WpJ/4ig0NxFajiZtdgLimwuDoBkvHINNDpSOmgyeUn+6L7ttySsHlhBgFPjGUWpGp2cVySZhl3mnZwN5JWwIaVX5sjFEy1/CZhFPsjEmbpAFOTAxrqyoapKqVmwWdasCg2uMLvCAxtPftYpG+DMuIAKTS6dWUwlyagqu5Hx8uZiBO2kJmpvMQg1BonYcMytkef3NdNs8UfY1bSbfuOCk+ESdlQ0U3cIMgUkIS2qt2+6kfM1HJWOECZJyL9bqdxjaEw7LYRZt9vJCFCrd1Th7qfgMrF8s2naUtknzfSXaIlaB2IGR3eTkSJB7q6Rc2oSCwcvg2QIcIorQKPdqqsnTog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IhMB1MPYDd6eHoX1cCF+RDSQnYEaij2yxuAi45sCVjQ=; b=G89g9bWiORlk46liq6ZyZnpnlF0uiblQrHbLMFXcVg8aOY5zYQPNQ7i6SYHho8U36lK1P/t7bw4s17QOOXbBCo3yNm4UqOWzf/z5093I4ePhsMMSlbk9tIHh77RhPZnpl+/3f51LpwWMq5te9qwln0GbuwGFbNaliErmF9ywvfBZQcb1vpiQXF6uc2pyt55jbEf0ckSGcHA3SVcX6oZabq0CdRN2dy45HMJuyRoenjEYHrk7K8dE09TS0zeIB4/ACzSZIpgIi4SgrVYbi7iyHXSUSc8YIQf4y6w+6beBaos36l1n5xO0xQbv8lxIbHM2gu9cJvhlAsE5uJJdYf/yuA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IhMB1MPYDd6eHoX1cCF+RDSQnYEaij2yxuAi45sCVjQ=; b=L7JEsF1vXbYz6/b4GI4oOR5JBRhEpsbGcnT1M+796Hucy50VGuzoKnRxBU/saEjVqZJWfJEsdERm/XwkzS9onuqyQES2Q3fYV4Ke9wLtT61e9ZnwVLES0dr0+DbL2SKnZYaBrM66t79Z7tkTBtlHDKHa7D2G5ICzGhTA/KR3kY+s3QoyT0uyL/fCh3+sv7htivPoblABIn41HGqQ7Q5DWf6hmUJCy4dB4k/Mn9zkFc3+N6C/fnm6vYeVF+dTFwN9Iegf+nwZFWPZugRmAA06lzXJo8Qmi18tTSrDVAZYEP2Ptlov9XmV/XfToeNxvgXERL5ZuB50LSFPwV6tNcpLdQ== Received: from MW2NAM10FT051.eop-nam10.prod.protection.outlook.com (2a01:111:e400:7e87::52) by MW2NAM10HT114.eop-nam10.prod.protection.outlook.com (2a01:111:e400:7e87::494) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.25; Wed, 10 Mar 2021 17:46:24 +0000 Received: from SJ0PR03MB5581.namprd03.prod.outlook.com (2a01:111:e400:7e87::4d) by MW2NAM10FT051.mail.protection.outlook.com (2a01:111:e400:7e87::227) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.31 via Frontend Transport; Wed, 10 Mar 2021 17:46:24 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:C0AB7FF6656ACFCD0233ED7215EE68A055A402EBFA2A81B279C09D7B54B0FFCF;UpperCasedChecksum:680A9C51E90272DB008CCACEFA5179A2AC90A9431A52CFA7036689C4301E9EDA;SizeAsReceived:8450;Count:44 Received: from SJ0PR03MB5581.namprd03.prod.outlook.com ([fe80::ed0b:679f:905f:4c94]) by SJ0PR03MB5581.namprd03.prod.outlook.com ([fe80::ed0b:679f:905f:4c94%4]) with mapi id 15.20.3912.030; Wed, 10 Mar 2021 17:46:24 +0000 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Subject: Re: [PATCH ucspi-vsock] vsockserver: use fclose instead of close From: "Cole Helbling" To: "Alyssa Ross" , Date: Wed, 10 Mar 2021 09:41:01 -0800 Message-ID: In-Reply-To: <20210309154048.14474-1-hi@alyssa.is> X-TMN: [FtjoSpW3gzsR6tfo9Joh3NFQYiiQywwe] X-ClientProxiedBy: PH0PR07CA0085.namprd07.prod.outlook.com (2603:10b6:510:f::30) To SJ0PR03MB5581.namprd03.prod.outlook.com (2603:10b6:a03:27b::20) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost (73.48.197.220) by PH0PR07CA0085.namprd07.prod.outlook.com (2603:10b6:510:f::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17 via Frontend Transport; Wed, 10 Mar 2021 17:46:23 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 44 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: a6207db6-a2ad-426d-471e-08d8e3ec6c39 X-MS-TrafficTypeDiagnostic: MW2NAM10HT114: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OnkHWoMW2lj8U/OTuejGLyZuoCZu0UjcZqjOVud3DD6jV32s7//l7w67dz4aAD1Wcc/SWt2/oZWuoEtuUFYwWJ5E+/3ahdbstwDpNLzPbRRcUaNSNSCHpr+FxsYNKeBrFKJznjq6QyJRLbxsa3B7UQW1R/jBP9UI9UA4maX4LUmIEYLzUsD0y5J/WmILNmMQQvsX5nUADmdKm2OsK9FH3k2+VprsCapHP01yUYY3uiy+ZHsDvZR4RtM/AWDmtoamtgiSjIL1YwzVDeyw+TQjloKLSvajXh/U1fFAzsveBfUK8bRoBFKjPtMww19QikoSQ4SqxEeTIsrOJJ+lZWrcsV4D82t3n8hC84dHqdnaYTx3JpSupcryDsdkrzu8iwe057XTHjW+O3W0mISM17wXug== X-MS-Exchange-AntiSpam-MessageData: ZRx/q5v+oVqSEd0W4c3B/E0ZBo1pPjua8sAS7FqebsSdA6VxwgaE62WfsL/lKBjxh3W8+bfew/vfS3tVdNp7I7zi7w9jFDmgdhuTi753lu8+bN8XaXg7B3cLr0qYLNOsuCglkCjvvK9Q+Rq4mAZ1Iw== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a6207db6-a2ad-426d-471e-08d8e3ec6c39 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Mar 2021 17:46:24.2565 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: MW2NAM10FT051.eop-nam10.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2NAM10HT114 Message-ID-Hash: F7726R74WZJLTB55LXHUCFLV5FQ5SBSQ X-Message-ID-Hash: F7726R74WZJLTB55LXHUCFLV5FQ5SBSQ X-MailFrom: cole.e.helbling@outlook.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.3.1 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: On Tue Mar 9, 2021 at 7:40 AM PST, Alyssa Ross wrote: > stdio can buffer output, so if we close stdout without going through > stdio, there might be buffered output that is never written. > --- > vsockserver.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/vsockserver.c b/vsockserver.c > index dd9a74a..196056a 100644 > --- a/vsockserver.c > +++ b/vsockserver.c > @@ -90,7 +90,7 @@ int main(int argc, char *argv[]) > =20 > if (notify) { > printf("%" PRIu32 "\n", lport); > - close(STDOUT_FILENO); > + fclose(stdout); > } > =20 > setenvf("VSOCKLOCALCID", 1, "%" PRIu32, lcid); > -- > 2.30.0 I don't write much (if any) C, so I never knew there was both STDOUT_FILENO (as an int) _and_ stdout (as a FILE*). I suppose the most important part is that fclose() uses fflush(3) under the hood to make sure we actually write everything. Reviewed-by: Cole Helbling