From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FORGED_SPF_HELO,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2, SPF_HELO_PASS autolearn=no autolearn_force=no version=3.4.5 Received: by atuin.qyliss.net (Postfix, from userid 496) id E95CB46DA0; Mon, 28 Jun 2021 20:37:33 +0000 (UTC) Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id D3C3546CFA; Mon, 28 Jun 2021 20:37:25 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 496) id C771946D3D; Mon, 28 Jun 2021 20:37:23 +0000 (UTC) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam07olkn2015.outbound.protection.outlook.com [40.92.43.15]) by atuin.qyliss.net (Postfix) with ESMTPS id C5E3646CEF for ; Mon, 28 Jun 2021 20:37:19 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nBUFZfyAcaeWYn4tUgV8i7r0RDBAf6nFLzFEAGDNuSBa0fqsu53iHeG6CpROpG1HGOX5rEdonAHm5qokNkbkg+MbejvleIHSt8ahWDwOyac6eD0zoaMpLKAQ50KX0M0H6h+E7jdzGUaWeEn+3AZJUntp6yV4QSrfKG+QnOf+Aw35r67tzfv6x+SOAGrM/QXAZkazCvJtLDEe1razgfJSse+pagnllLb1x9trG8BJeH0ky95PxhCaxufZ4HKBgAHt/1AixWJsqmajLpwtaeAS/USUl+HKENFUAELOfPfcGq8EMWJQWcD+3Hc7ECcdjj/UEoDAO4A49JWk2AiCY4k/SQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=inKsayUICTgZISHHIHiKKGtgMynVADTaueJPeb0Axr4=; b=f2fuYb5aShhY1pBSfwqlBXcpZheMWFPz7FpL23RKCSEiIxwBZfEhFTIyizQ4VW6xkTkDnPXtfL+EavvO3E8RgBw/rmNCzJi5LVgAOSBXcKDd60Ez93oTsA3Tlf26LbLhSbzSHDu9jXZl/9WVukCc3Wg7NV+2AgnV7C56LvOqYeGRo4us8fWQAb93ekuLoFJAeCM7oCw6tiW/JzPtXk7XgP65A7Hj4bBEEcu8BYlgx1Ck42/F6WwJHsImtHvk7P5Pgptep9zqlwAUZA/4RARS4t38XBAnhVApoo3xt1yCGg1eSfpkOGnETpvFOdkpIs8OuwcOIgtZ90ZFUYAUy5JJCA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=inKsayUICTgZISHHIHiKKGtgMynVADTaueJPeb0Axr4=; b=OLo+j3UHVUZvgOEV3VQiYpGLfMv9PM4XDAYBXWV93+TssApsUWsQqRV3JX9EQ7HrP1TUHK0G1ivlDHxt2vucs6u8U7vrz98XAb3TXy0yMZorMnz89bAe9eg7wnj0RKloPDXpgqqlP37AWej+4nhPF6gJgCRdtCvyPIcQc9plpeWueDd7+sBZ5brd4HHdOTToKXHkRKmBUTsvnEq1/32CO4YUW/hlJYX9HccpiRtuVfGxDHrrJ1y041yWlrYb4qU3vs+MGB249a8oJfdrXJ7c7BOHoAVdD0uKyZvecU8vH9LPPGtFg6ajlQyK1DZlLyVFqOszVrt+fDr30TNAiutMzg== Received: from SJ0PR03MB5581.namprd03.prod.outlook.com (2603:10b6:a03:27b::20) by SJ0PR03MB6376.namprd03.prod.outlook.com (2603:10b6:a03:395::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.18; Mon, 28 Jun 2021 20:37:16 +0000 Received: from SJ0PR03MB5581.namprd03.prod.outlook.com ([fe80::6d2c:60f7:5584:579a]) by SJ0PR03MB5581.namprd03.prod.outlook.com ([fe80::6d2c:60f7:5584:579a%9]) with mapi id 15.20.4264.026; Mon, 28 Jun 2021 20:37:16 +0000 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Subject: Re: [PATCH platform2 0/2] Make vm_protos compatible with protoc-gen-go 1.5.x From: "Cole Helbling" To: "Alyssa Ross" , Date: Mon, 28 Jun 2021 13:35:51 -0700 Message-ID: In-Reply-To: <20210628173106.1128138-1-hi@alyssa.is> X-TMN: [yBMBmWyczqQgJtovhvNVkaTKwjhHlZlq] X-ClientProxiedBy: BYAPR02CA0054.namprd02.prod.outlook.com (2603:10b6:a03:54::31) To SJ0PR03MB5581.namprd03.prod.outlook.com (2603:10b6:a03:27b::20) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost (73.48.197.220) by BYAPR02CA0054.namprd02.prod.outlook.com (2603:10b6:a03:54::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.18 via Frontend Transport; Mon, 28 Jun 2021 20:37:16 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c5473da3-7006-446d-db75-08d93a748474 X-MS-TrafficTypeDiagnostic: SJ0PR03MB6376: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HnJ0JafU4Y4LWzeuZ0UwxZFsDo0rw1OP3sKz4NTwocMR6PDmXk5XyNbqbCjj/Pivs5kUyQN9UZQprngzAEDf8xxFGkfp5+rKw53qUGFyIuNLCbChT2vDxaJZwQUbk4hyflnaQ6H1chsZVvPkEySw6hufycRIegdJtvkq36KUJE/bfvbGSuBlrKMRSru0puAap6XKnflqciYYyeMLPW7D1Mk2ByB8vWSUKbLdDTjgZWqwrYj7Az7/2U5I5vDUFQCuOHtX/aCoKL86LwB6cIYBHYOnI+bqL8pB0+IM5JAORpP7u+42ah3YykbRlWCAc6sxlwY8ffGr8NFZhuEm8KKiIjvlub6rEThCR6APm0l+z45CNSr9iucKbolLJa8POOhccAaR0iQ/c4hR5OG+WjrTI+cRbYTQfXUmvh4pGR3jfOwCmJDpx1q0f0bQjrVJQb27+iWTsab07RB0aOZ9VDeIYHrjyXTzdMJdSOr9smEJEtviLwnWtDfOf3UnEWUaiw7g6kZ99vCqvyzwnw7fzHQNqQ== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: IussX9adgW5GlIB39n4iUJsEMRJ/HNgQADpTtlCASHh4hdq6NczL3UB6RbAemgfuA8q+hUa9uSGojgrmKUAQpugtZvwhu18l0s21wW06qsX+JV47NwLxbeFTMAE54oMZW5ERsVIigry/B5BgMRGsgw== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c5473da3-7006-446d-db75-08d93a748474 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB5581.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2021 20:37:16.5271 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6376 Message-ID-Hash: 6QPCJJ6A6TF7UZCNIUC3SXDC5Y4C7ZQI X-Message-ID-Hash: 6QPCJJ6A6TF7UZCNIUC3SXDC5Y4C7ZQI X-MailFrom: cole.e.helbling@outlook.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Puck Meerburg X-Mailman-Version: 3.3.4 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon Jun 28, 2021 at 10:31 AM PDT, Alyssa Ross wrote: > My previous attempt[1] at this was totally wrong, because I didn't > understand what change needed to be made, and didn't have any way of > testing it. > > To make sure this time that I got it right, I wrote a package for > tremplin[2], which was the only Chromium OS component I could find > that was written in Go and actually used vm_protos. With these > changes, I was able to add "${vm_protos}/lib/gopath" to tremplin's > extraSrcPaths, and get a successful build. > > [1]: https://spectrum-os.org/lists/archives/spectrum-devel/20210627165035= .899276-1-hi@alyssa.is/ > [2]: https://chromium.googlesource.com/chromiumos/platform/tremplin > > Alyssa Ross (2): > common-mk: add goproto_library source_relative opt > vm_tools: proto: set go_package correctly > > common-mk/proto_library.gni | 7 +++++++ > vm_tools/proto/BUILD.gn | 5 +++++ > vm_tools/proto/tremplin.proto | 2 +- > vm_tools/proto/vm_crash.proto | 2 +- > vm_tools/proto/vm_guest.proto | 1 + > vm_tools/proto/vm_host.proto | 1 + > 6 files changed, 16 insertions(+), 2 deletions(-) > > --=20 > 2.31.1 Good thing I didn't (have enough time to) review that previous patch :P Is this something unique to this project, or should / will this be upstream= ed (if it isn't already)? That aside, diff LGTM. Reviewed-by: Cole Helbling