From: Yureka <yuka@yuka.dev>
To: Demi Marie Obenour <demiobenour@gmail.com>, devel@spectrum-os.org
Subject: Re: [PATCH v1 RFC 4/4] host: integrate router
Date: Mon, 24 Nov 2025 21:06:44 +0100 [thread overview]
Message-ID: <a6ee7f3f-092a-451b-b12c-91bddc2d11b1@yuka.dev> (raw)
In-Reply-To: <137cf373-f1e3-4d63-895d-875a9b44df24@gmail.com>
The code review of the router code is not helpful at this stage, as I
hoped to convey in the cover letter.
We should however address the IPv4 support question (see below).
On 11/24/25 20:10, Demi Marie Obenour wrote:
> On 11/24/25 11:35, Yureka Lilian wrote:
>> This removes the old host bridge + taps glue, and instead connects the
>> apps to their net provider's router instance.
> As mentioned in my reply to the last email, I'd like to see the old
> code kept as an option until the router gains IPv4 support. Right now,
> I have no way of testing this code except by setting up a VPN.
You will be able to test the code using the integration tests once I
have adapted them. You can also always test against a local IPv6
link-local target in your home network, or using pasta/passt emulation
for testing handling of router advertisements.
Supporting both the host network path and the spectrum router at the
same time adds a lot of complexity in start-vmm because of how
differently they function, and I wouldn't consider it an option.
If IPv4 support is a requirement, I would propose adding rudimentary
support for it to the router early in a similar fashion as IPv6 (with
one IP per VM). Otherwise, I'm planning to add IPv4 support later with
connection tracking and network address translation.
prev parent reply other threads:[~2025-11-24 20:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-24 16:35 [PATCH v1 RFC 0/4] spectrum-router Yureka Lilian
2025-11-24 16:35 ` [PATCH v1 RFC 1/4] vm/sys/net: remove connman & dbus Yureka Lilian
2025-11-25 10:15 ` Alyssa Ross
2025-11-25 11:37 ` Yureka
2025-11-26 1:25 ` Demi Marie Obenour
2025-11-24 16:35 ` [PATCH v1 RFC 2/4] vm/sys/net: integrate xdp-forwarder Yureka Lilian
2025-11-26 10:53 ` Alyssa Ross
2025-11-24 16:35 ` [PATCH v1 RFC 3/4] tools: add spectrum-router Yureka Lilian
2025-11-24 19:05 ` Demi Marie Obenour
2025-11-24 16:35 ` [PATCH v1 RFC 4/4] host: integrate router Yureka Lilian
2025-11-24 19:10 ` Demi Marie Obenour
2025-11-24 20:06 ` Yureka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6ee7f3f-092a-451b-b12c-91bddc2d11b1@yuka.dev \
--to=yuka@yuka.dev \
--cc=demiobenour@gmail.com \
--cc=devel@spectrum-os.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://spectrum-os.org/git/crosvm
https://spectrum-os.org/git/doc
https://spectrum-os.org/git/mktuntap
https://spectrum-os.org/git/nixpkgs
https://spectrum-os.org/git/spectrum
https://spectrum-os.org/git/ucspi-vsock
https://spectrum-os.org/git/www
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).