From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id 4099F1E127; Mon, 24 Nov 2025 20:06:57 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 993) id 759981E11E; Mon, 24 Nov 2025 20:06:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-0.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DMARC_PASS,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=4.0.1 Received: from mail.cyberchaos.dev (mail.cyberchaos.dev [195.39.247.168]) by atuin.qyliss.net (Postfix) with ESMTPS id B406E1E11C for ; Mon, 24 Nov 2025 20:06:53 +0000 (UTC) Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yuka.dev; s=mail; t=1764014811; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=tfVqLh4BH+Wne7s4T1sSWKvez9EJGBuKDn8J2agdVDQ=; b=e6IlviwpxwrJvOnEzhs0zFJQfUMsSIFZ/Kge5PaX2O7FuBmpUVkpgTt5aB4o0isxhjs9tN TiCD4nz4QCbSNoe3nzKVDTdbF6YDliHv8L79wQo0Y48oamY3Tep37jwd+IvVBFlLycyWG3 c9O88NJKzkru/orroHuXCfHgzT7KKKU= Date: Mon, 24 Nov 2025 21:06:44 +0100 MIME-Version: 1.0 Subject: Re: [PATCH v1 RFC 4/4] host: integrate router To: Demi Marie Obenour , devel@spectrum-os.org References: <20251124163531.91029-1-yureka@cyberchaos.dev> <20251124163531.91029-5-yureka@cyberchaos.dev> <137cf373-f1e3-4d63-895d-875a9b44df24@gmail.com> Content-Language: en-US From: Yureka Autocrypt: addr=yuka@yuka.dev; keydata= xjMEZ3vnnhYJKwYBBAHaRw8BAQdAn6RVMnaxLzmDDx+J3jSUGY7BqjyDhsWhdwKBSI6QpXfN Fll1cmVrYSA8eXVrYUB5dWthLmRldj7CjgQTFgoANhYhBPGINbLQ3ypM7JNhigKbtnC7kwpH BQJne+eeAhsDBAsJCAcEFQoJCAUWAgMBAAIeBQIXgAAKCRACm7Zwu5MKRx1qAP9ToLaOMd73 VVf1JdwoMc5G44OZfKNk/+ezt9Dl2oqZdQD/Xvgd0lytU3BZ4WnYeMNzo2xHeRxXmX+MfXhA D33tzQ/OOARne+eeEgorBgEEAZdVAQUBAQdAIs9uImfvgSCnJOcfvzshLuaSRJ/a0Vp/9rUA eBGZq10DAQgHwngEGBYKACAWIQTxiDWy0N8qTOyTYYoCm7Zwu5MKRwUCZ3vnngIbDAAKCRAC m7Zwu5MKRyW9AP0dBOuwgWso+QjBZUsbuEmGGUz2OWtszs2Yb7087RMerwEA3al6E7vqq0HC 7LiB3nisU+xqQojJ4n/fWCu70iEkjQw= In-Reply-To: <137cf373-f1e3-4d63-895d-875a9b44df24@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: 66KACD2QOFWNLEOSVPC4NRH5CECHLYUU X-Message-ID-Hash: 66KACD2QOFWNLEOSVPC4NRH5CECHLYUU X-MailFrom: yuka@yuka.dev X-Mailman-Rule-Hits: member-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address X-Mailman-Version: 3.3.9 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The code review of the router code is not helpful at this stage, as I hoped to convey in the cover letter. We should however address the IPv4 support question (see below). On 11/24/25 20:10, Demi Marie Obenour wrote: > On 11/24/25 11:35, Yureka Lilian wrote: >> This removes the old host bridge + taps glue, and instead connects the >> apps to their net provider's router instance. > As mentioned in my reply to the last email, I'd like to see the old > code kept as an option until the router gains IPv4 support. Right now, > I have no way of testing this code except by setting up a VPN. You will be able to test the code using the integration tests once I have adapted them. You can also always test against a local IPv6 link-local target in your home network, or using pasta/passt emulation for testing handling of router advertisements. Supporting both the host network path and the spectrum router at the same time adds a lot of complexity in start-vmm because of how differently they function, and I wouldn't consider it an option. If IPv4 support is a requirement, I would propose adding rudimentary support for it to the router early in a similar fashion as IPv6 (with one IP per VM). Otherwise, I'm planning to add IPv4 support later with connection tracking and network address translation.