patches and low-level development discussion
 help / color / mirror / code / Atom feed
From: Demi Marie Obenour <demiobenour@gmail.com>
To: Spectrum OS Development <devel@spectrum-os.org>
Subject: config.nix validation?
Date: Fri, 7 Nov 2025 17:08:06 -0500	[thread overview]
Message-ID: <b0eecb51-e222-469f-906c-e1b8e12bad44@gmail.com> (raw)


[-- Attachment #1.1.1: Type: text/plain, Size: 692 bytes --]

Should the values from config.nix be validated in any way?  They are
obviously trusted, but it is very easy for the users to make mistakes
that could cause extremely confusing problems.  For instance, the
update patch doesn't support URLs with a query string or a fragment
specifier.  In fact, such URLs could get mangled.  There are other
URLs that tools like curl will accept but which will break the build.

Should these be validated with regular expressions before use?
That will result in build-time errors that at least somewhat point
to the source of the problem, rather than mysterious build-time or
runtime misbehavior.
-- 
Sincerely,
Demi Marie Obenour (she/her/hers)

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 7253 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

             reply	other threads:[~2025-11-07 22:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-07 22:08 Demi Marie Obenour [this message]
2025-11-09 11:13 ` config.nix validation? Alyssa Ross
2025-11-09 20:09   ` Demi Marie Obenour
2025-11-09 21:10     ` Alyssa Ross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b0eecb51-e222-469f-906c-e1b8e12bad44@gmail.com \
    --to=demiobenour@gmail.com \
    --cc=devel@spectrum-os.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://spectrum-os.org/git/crosvm
	https://spectrum-os.org/git/doc
	https://spectrum-os.org/git/mktuntap
	https://spectrum-os.org/git/nixpkgs
	https://spectrum-os.org/git/spectrum
	https://spectrum-os.org/git/ucspi-vsock
	https://spectrum-os.org/git/www

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).