From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on atuin.qyliss.net X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.6 Received: from atuin.qyliss.net (localhost [IPv6:::1]) by atuin.qyliss.net (Postfix) with ESMTP id BAD9C745E1; Fri, 23 Sep 2022 12:26:17 +0000 (UTC) Received: by atuin.qyliss.net (Postfix, from userid 496) id 32991745DB; Fri, 23 Sep 2022 12:26:16 +0000 (UTC) Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by atuin.qyliss.net (Postfix) with ESMTPS id 672C0745D5 for ; Fri, 23 Sep 2022 12:26:13 +0000 (UTC) Received: by mail-lj1-x229.google.com with SMTP id p5so14415766ljc.13 for ; Fri, 23 Sep 2022 05:26:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=unikie.com; s=google; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=NHK7w1FmRLrXEt+YvWS5BINSMmESPaWUkuM46EbpyUo=; b=EoDlrIi6LRcMfz0WrtC0BggLhtquvZcXeyxZmi4rKNIubOexiKgXzBj4hVT+43B2wW WadIOx5wyc4BMYFCfr0AePsDiZK94KzyDje0ci5M/NGxE5VSEh/Gm3njBenoAChI54LP EVLjiyKKRd1HNkEvZpg/lkcpzvd8KNROuXa9kh0MOXdaZHNj1wmJoprG6hAVu4OHDJ+O O2Sn9uMWGSccDWYjCCMRQgziouukjGW1r5rlN8yesYIh0vTPl66QwIbNnJckTR6vsIJB LmEMYXe4fTd7tDkIv67tcZuNRAgJepI3eYpfI2eqqOL5vDamDhRo6jXLP8inBmN+5hDV VgVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=NHK7w1FmRLrXEt+YvWS5BINSMmESPaWUkuM46EbpyUo=; b=2VVC2LcP7gMKJnnMtn2o8TDEhyzdNw7ZeZYSEbQn7n6oTlNAebUJDC6ZgLO7kWYYpC Ax/WvPswdf446gN/bJbSsFfC9XsFZOmol2O3BelR5NUjBXygXyX2C7hp49PXXqzejL8S uFm4pqzW4NIsLa/P9ZVZs0kd0905rRpkbSH3qI/oKCvC+e7K931N36mh5yZGYQ6iRXul XEluMyQlyUe4kMbzuViGM2u/eRyIDB1rRGF+tQL3RkdlSOuF7LAfrihW7BjqvB7tRDjT nu2NptwmrZd7xYc+W5j2LAIwapaqAnQoBaMLAGKhgmT0Ouh+Chh61jPOKBiAMRc14tyH 0Geg== X-Gm-Message-State: ACrzQf2DxEe3FJdapBLRIcGb/xoO2XK3EM23S3k5CP5kIALIH0j9Fs0u XcbxhZTdkmhufz0lruohVGR2ew== X-Google-Smtp-Source: AMsMyM52I0lmYheZerHq0xWAK8WV4kmv5Y5LFg1I5An/xqKkOfU5sG86gTb315hCc+umbwVXOfY57A== X-Received: by 2002:a2e:9e81:0:b0:268:894f:8118 with SMTP id f1-20020a2e9e81000000b00268894f8118mr2910151ljk.371.1663935972318; Fri, 23 Sep 2022 05:26:12 -0700 (PDT) Received: from [192.168.1.26] (mobile-access-6df023-175.dhcp.inet.fi. [109.240.35.175]) by smtp.gmail.com with ESMTPSA id f18-20020ac24992000000b0048b003c4bf7sm1426790lfl.169.2022.09.23.05.26.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Sep 2022 05:26:11 -0700 (PDT) Message-ID: Date: Fri, 23 Sep 2022 15:26:10 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH] img/live: add rootfs attribute passthru Content-Language: en-US To: Ivan Nikolaenko , Yuri Nesterov , devel@spectrum-os.org References: <20220922144719.816016-1-yuriy.nesterov@unikie.com> <7883c598-446a-c78d-8e80-2b1fe88ff2fb@unikie.com> <47cef5cc-58e8-3842-3714-f696cbbdcfb1@unikie.com> From: Ville Ilvonen In-Reply-To: <47cef5cc-58e8-3842-3714-f696cbbdcfb1@unikie.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Message-ID-Hash: K3DSR24ZRB6T3X66FS2V6NQ56VHKEFSQ X-Message-ID-Hash: K3DSR24ZRB6T3X66FS2V6NQ56VHKEFSQ X-MailFrom: ville.ilvonen@unikie.com X-Mailman-Rule-Hits: header-match-devel.spectrum-os.org-0 X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1 X-Mailman-Version: 3.3.5 Precedence: list List-Id: Patches and low-level development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 9/23/22 13:10, Ivan Nikolaenko wrote: > Hello, > There is a typo in imx8qxp config file: Thanks Ivan, I noticed it in the morning and fixed it in the out-of-spectrum-tree config at https://github.com/tiiuae/spectrum-config-imx8/blob/main/imx8qxp/default.nix#L27 -Ville > diff --git a/imx8qxp/default.nix b/imx8qxp/default.nix > index 096d6aa..dc1d41f 100644 > --- a/imx8qxp/default.nix > +++ b/imx8qxp/default.nix > @@ -24,7 +24,7 @@ stdenvNoCC.mkDerivation { >    ]; > >    buildCommand = '' > -    install -m 0644 $(spectrum) spectrum-live-imx8qxp.img > +    install -m 0644 ${spectrum} spectrum-live-imx8qxp.img >      dd if=${uboot}/flash.bin of=spectrum-live-imx8qxp.img bs=1k > seek=32 conv=notrunc >      IMG=spectrum-live-imx8qxp.img >      ESP_OFFSET=$(sfdisk --json $IMG | jq -r ' > > Fixing this allows to proceed to the next error: > make: *** No rule to make target '.......systemd-bootx64.efi', needed by > 'build/boot.fat'.  Stop. > But this one is pretty straightforward. > > Ivan > > On 9/23/22 10:51, Ville Ilvonen wrote: >> On 9/22/22 17:47, Yuri Nesterov wrote: >>> This allows to get access to rootfs and kernel from device images. >>> >>> Signed-off-by: Yuri Nesterov >>> --- >>>   img/live/default.nix | 2 ++ >>>   1 file changed, 2 insertions(+) >>> >>> diff --git a/img/live/default.nix b/img/live/default.nix >>> index 65ad058..5461384 100644 >>> --- a/img/live/default.nix >>> +++ b/img/live/default.nix >>> @@ -45,4 +45,6 @@ stdenvNoCC.mkDerivation { >>>     ''; >>>       enableParallelBuilding = true; >>> + >>> +  passthru = { inherit rootfs; }; >>>   } >> >> Thanks, fixes the issue and takes us to the next issue before >> out-of-tree build reference configs with imx8 variants are supported. >> >> ~/out-of-tree-build >> ❯ nix-build spectrum-config-imx8/imx8qxp/ -I nixpkgs=nixpkgs-spectrum/ >> this derivation will be built: >> >> /nix/store/0xgldphzh2kjgckd13k3azarzvkdqqvs-spectrum-live-imx8qxp.img-0.1.drv >> building >> '/nix/store/0xgldphzh2kjgckd13k3azarzvkdqqvs-spectrum-live-imx8qxp.img-0.1.drv'... >> /nix/store/nlzy51mvniqk080jlszm37j0hzi6m9rv-stdenv-linux/setup: line >> 1340: spectrum: command not found >> >> Tested-by: Ville Ilvonen >> >> -Ville >> >>