Re: [PATCH] tools/router: trace unicast packets

[Yureka <yuka@yuka.dev>]

On 6/19/26 15:09, Alyssa Ross wrote:
> I found this useful for debugging.
> ("Is it actually sending anything?")
>
> Signed-off-by: Alyssa Ross <hi@alyssa.is>
> ---
>   tools/router/src/router.rs | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tools/router/src/router.rs b/tools/router/src/router.rs
> index a91e4155..f36866d8 100644
> --- a/tools/router/src/router.rs
> +++ b/tools/router/src/router.rs
> @@ -11,7 +11,7 @@ use crate::packet::*;
>   use crate::protocol::*;
>   
>   use futures_util::{FutureExt, Sink, SinkExt, Stream, StreamExt};
> -use log::{debug, info, warn};
> +use log::{debug, info, trace, warn};
>   use tokio_stream::StreamMap;
>   use vhost_device_net::IncomingPacket;
>   use vm_memory::GuestMemory;
> @@ -128,6 +128,7 @@ impl<M: GuestMemory> Router<M> {
>                       .await?;
>                   }
>                   ref unicast => {
> +                    trace!("got unicast packet {:?} -> {:?}", in_iface, out_iface);
>                       let Some(sink) = self.sinks.get_mut(unicast) else {
>                           warn!("dropped packet because interface is not ready");
>                           continue;
>
> base-commit: 57bf21eaf65ca5a42d18999ba65f96dcd338113c

In general useful, yes. I think logging on this level could affect 
performance (even if disabled at run-time). There is some crate feature 
of the log crate to conditionally compile the trace log level for debug 
builds.


— Yureka