patches and low-level development discussion
 help / color / mirror / code / Atom feed
* Best practices for submitting tree-wide changes
@ 2025-10-31 21:11 Demi Marie Obenour
  2025-11-01 12:22 ` Alyssa Ross
  0 siblings, 1 reply; 2+ messages in thread
From: Demi Marie Obenour @ 2025-10-31 21:11 UTC (permalink / raw)
  To: Spectrum OS Development


[-- Attachment #1.1.1: Type: text/plain, Size: 458 bytes --]

In some cases, the same change should be made to many parts of
the codebase.  This includes things like adding set -o pipefail to
shell scripts or moving command substitutions to their own commands.
Should one send a single patch that makes all the changes, or should
one send a bunch of tiny patches?

Preferably, the answer should be added to the documentation so people
don't need to ask again :)
-- 
Sincerely,
Demi Marie Obenour (she/her/hers)

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 7253 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Best practices for submitting tree-wide changes
  2025-10-31 21:11 Best practices for submitting tree-wide changes Demi Marie Obenour
@ 2025-11-01 12:22 ` Alyssa Ross
  0 siblings, 0 replies; 2+ messages in thread
From: Alyssa Ross @ 2025-11-01 12:22 UTC (permalink / raw)
  To: Demi Marie Obenour, Spectrum OS Development

[-- Attachment #1: Type: text/plain, Size: 675 bytes --]

Demi Marie Obenour <demiobenour@gmail.com> writes:

> In some cases, the same change should be made to many parts of
> the codebase.  This includes things like adding set -o pipefail to
> shell scripts or moving command substitutions to their own commands.
> Should one send a single patch that makes all the changes, or should
> one send a bunch of tiny patches?
>
> Preferably, the answer should be added to the documentation so people
> don't need to ask again :)

A single patch with no component prefix in the subject line is fine.

Documentation doesn't currently have a good place for this sort of thing
but I'll note the request for when we restructure it next year.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-11-01 12:22 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-31 21:11 Best practices for submitting tree-wide changes Demi Marie Obenour
2025-11-01 12:22 ` Alyssa Ross

Code repositories for project(s) associated with this public inbox

	https://spectrum-os.org/git/crosvm
	https://spectrum-os.org/git/doc
	https://spectrum-os.org/git/mktuntap
	https://spectrum-os.org/git/nixpkgs
	https://spectrum-os.org/git/spectrum
	https://spectrum-os.org/git/ucspi-vsock
	https://spectrum-os.org/git/www

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).